Commit a3c30e72 authored by Jan Wilken Dörrie's avatar Jan Wilken Dörrie Committed by Commit Bot

[base] Apply BindOnceRewriter in //chrome/browser/chromeos/dbus

This change applies the BindOnceRewriter in //chrome/browser/chromeos/dbus.
This rewriter replaces calls to base::Bind and base::BindRepeating with
calls to base::BindOnce, in case the result is immediately assigned to a
base::OnceCallback. Given that base::RepeatingCallback is implicitly
convertible to base::OnceCallback, there is no change in functionality.

Steps:
  1. run_tool.py --tool base_bind_rewriters \
                 --tool-arg='--rewriter=bind_to_bind_once'
  2. git cl format

This CL was uploaded by git cl split.

R=stevenjb@chromium.org

Bug: 714018
Change-Id: I322fc624930cfeb5fcebc0f24c243a408cee4af4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132328Reviewed-by: default avatarSteven Bennetts <stevenjb@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#760399}
parent 1fe78d50
......@@ -73,29 +73,29 @@ void ChromeFeaturesServiceProvider::Start(
kChromeFeaturesServiceIsFeatureEnabledMethod,
base::BindRepeating(&ChromeFeaturesServiceProvider::IsFeatureEnabled,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&ChromeFeaturesServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&ChromeFeaturesServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
exported_object->ExportMethod(
kChromeFeaturesServiceInterface,
kChromeFeaturesServiceIsCrostiniEnabledMethod,
base::BindRepeating(&ChromeFeaturesServiceProvider::IsCrostiniEnabled,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&ChromeFeaturesServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&ChromeFeaturesServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
exported_object->ExportMethod(
kChromeFeaturesServiceInterface,
kChromeFeaturesServiceIsPluginVmEnabledMethod,
base::BindRepeating(&ChromeFeaturesServiceProvider::IsPluginVmEnabled,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&ChromeFeaturesServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&ChromeFeaturesServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
exported_object->ExportMethod(
kChromeFeaturesServiceInterface,
kChromeFeaturesServiceIsUsbguardEnabledMethod,
base::BindRepeating(&ChromeFeaturesServiceProvider::IsUsbguardEnabled,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&ChromeFeaturesServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&ChromeFeaturesServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
exported_object->ExportMethod(
kChromeFeaturesServiceInterface,
kChromeFeaturesServiceIsCryptohomeDistributedModelEnabledMethod,
......@@ -110,8 +110,8 @@ void ChromeFeaturesServiceProvider::Start(
base::BindRepeating(
&ChromeFeaturesServiceProvider::IsVmManagementCliAllowed,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&ChromeFeaturesServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&ChromeFeaturesServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
}
void ChromeFeaturesServiceProvider::OnExported(
......
......@@ -68,16 +68,16 @@ void ComponentUpdaterServiceProvider::Start(
kComponentUpdaterServiceLoadComponentMethod,
base::Bind(&ComponentUpdaterServiceProvider::LoadComponent,
weak_ptr_factory_.GetWeakPtr()),
base::Bind(&ComponentUpdaterServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&ComponentUpdaterServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
exported_object->ExportMethod(
kComponentUpdaterServiceInterface,
kComponentUpdaterServiceUnloadComponentMethod,
base::Bind(&ComponentUpdaterServiceProvider::UnloadComponent,
weak_ptr_factory_.GetWeakPtr()),
base::Bind(&ComponentUpdaterServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&ComponentUpdaterServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
exported_object_ = exported_object;
}
......
......@@ -205,8 +205,8 @@ void CryptohomeKeyDelegateServiceProvider::Start(
base::BindRepeating(
&CryptohomeKeyDelegateServiceProvider::HandleChallengeKey,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating([](const std::string& interface_name,
const std::string& method_name, bool success) {
base::BindOnce([](const std::string& interface_name,
const std::string& method_name, bool success) {
LOG_IF(ERROR, !success)
<< "Failed to export " << interface_name << "." << method_name;
}));
......
......@@ -24,8 +24,8 @@ void DriveFileStreamServiceProvider::Start(
drivefs::kDriveFileStreamOpenIpcChannelMethod,
base::BindRepeating(&DriveFileStreamServiceProvider::HandleOpenIpcChannel,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating([](const std::string& interface_name,
const std::string& method_name, bool success) {
base::BindOnce([](const std::string& interface_name,
const std::string& method_name, bool success) {
LOG_IF(ERROR, !success)
<< "Failed to export " << interface_name << "." << method_name;
}));
......
......@@ -26,8 +26,8 @@ void KioskInfoService::Start(
kKioskAppServiceGetRequiredPlatformVersionMethod,
base::Bind(&KioskInfoService::GetKioskAppRequiredPlatformVersion,
weak_ptr_factory_.GetWeakPtr()),
base::Bind(&KioskInfoService::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&KioskInfoService::OnExported,
weak_ptr_factory_.GetWeakPtr()));
}
void KioskInfoService::OnExported(const std::string& interface_name,
......
......@@ -28,8 +28,8 @@ void LibvdaServiceProvider::Start(
libvda::kLibvdaServiceInterface, libvda::kProvideMojoConnectionMethod,
base::BindRepeating(&LibvdaServiceProvider::ProvideMojoConnection,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&LibvdaServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&LibvdaServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
}
void LibvdaServiceProvider::OnExported(const std::string& interface_name,
......
......@@ -22,8 +22,8 @@ void LockToSingleUserServiceProvider::Start(
lock_to_single_user::kNotifyVmStartingMethod,
base::BindRepeating(&LockToSingleUserServiceProvider::NotifyVmStarting,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&LockToSingleUserServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&LockToSingleUserServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
}
void LockToSingleUserServiceProvider::OnExported(
......
......@@ -29,8 +29,8 @@ void MachineLearningDecisionServiceProvider::Start(
base::BindRepeating(
&MachineLearningDecisionServiceProvider::ShouldDeferScreenDim,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&MachineLearningDecisionServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&MachineLearningDecisionServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
}
void MachineLearningDecisionServiceProvider::OnExported(
......
......@@ -35,14 +35,14 @@ void PluginVmServiceProvider::Start(
kPluginVmServiceInterface, kPluginVmServiceGetLicenseDataMethod,
base::BindRepeating(&PluginVmServiceProvider::GetLicenseData,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&PluginVmServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&PluginVmServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
exported_object->ExportMethod(
kPluginVmServiceInterface, kPluginVmServiceShowSettingsPage,
base::BindRepeating(&PluginVmServiceProvider::ShowSettingsPage,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&PluginVmServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&PluginVmServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
}
void PluginVmServiceProvider::OnExported(const std::string& interface_name,
......
......@@ -106,8 +106,8 @@ void ProxyResolutionServiceProvider::Start(
kNetworkProxyServiceInterface, kNetworkProxyServiceResolveProxyMethod,
base::BindRepeating(&ProxyResolutionServiceProvider::DbusResolveProxy,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&ProxyResolutionServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&ProxyResolutionServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
}
bool ProxyResolutionServiceProvider::OnOriginThread() {
......
......@@ -22,8 +22,8 @@ void ScreenLockServiceProvider::Start(
kScreenLockServiceInterface, kScreenLockServiceShowLockScreenMethod,
base::BindRepeating(&ScreenLockServiceProvider::ShowLockScreen,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&ScreenLockServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&ScreenLockServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
}
void ScreenLockServiceProvider::OnExported(const std::string& interface_name,
......
......@@ -26,8 +26,8 @@ void SmbFsServiceProvider::Start(
smbfs::kSmbFsInterface, smbfs::kOpenIpcChannelMethod,
base::BindRepeating(&SmbFsServiceProvider::HandleOpenIpcChannel,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating([](const std::string& interface_name,
const std::string& method_name, bool success) {
base::BindOnce([](const std::string& interface_name,
const std::string& method_name, bool success) {
LOG_IF(ERROR, !success)
<< "Failed to export " << interface_name << "." << method_name;
}));
......
......@@ -45,8 +45,8 @@ void VirtualFileRequestServiceProvider::Start(
kVirtualFileRequestServiceHandleReadRequestMethod,
base::Bind(&VirtualFileRequestServiceProvider::HandleReadRequest,
weak_ptr_factory_.GetWeakPtr()),
base::Bind([](const std::string& interface_name,
const std::string& method_name, bool success) {
base::BindOnce([](const std::string& interface_name,
const std::string& method_name, bool success) {
LOG_IF(ERROR, !success)
<< "Failed to export " << interface_name << "." << method_name;
}));
......@@ -55,8 +55,8 @@ void VirtualFileRequestServiceProvider::Start(
kVirtualFileRequestServiceHandleIdReleasedMethod,
base::Bind(&VirtualFileRequestServiceProvider::HandleIdReleased,
weak_ptr_factory_.GetWeakPtr()),
base::Bind([](const std::string& interface_name,
const std::string& method_name, bool success) {
base::BindOnce([](const std::string& interface_name,
const std::string& method_name, bool success) {
LOG_IF(ERROR, !success)
<< "Failed to export " << interface_name << "." << method_name;
}));
......
......@@ -35,22 +35,22 @@ void VmApplicationsServiceProvider::Start(
vm_tools::apps::kVmApplicationsServiceUpdateApplicationListMethod,
base::BindRepeating(&VmApplicationsServiceProvider::UpdateApplicationList,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&VmApplicationsServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&VmApplicationsServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
exported_object->ExportMethod(
vm_tools::apps::kVmApplicationsServiceInterface,
vm_tools::apps::kVmApplicationsServiceLaunchTerminalMethod,
base::BindRepeating(&VmApplicationsServiceProvider::LaunchTerminal,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&VmApplicationsServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&VmApplicationsServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
exported_object->ExportMethod(
vm_tools::apps::kVmApplicationsServiceInterface,
vm_tools::apps::kVmApplicationsServiceUpdateMimeTypesMethod,
base::BindRepeating(&VmApplicationsServiceProvider::UpdateMimeTypes,
weak_ptr_factory_.GetWeakPtr()),
base::BindRepeating(&VmApplicationsServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
base::BindOnce(&VmApplicationsServiceProvider::OnExported,
weak_ptr_factory_.GetWeakPtr()));
}
void VmApplicationsServiceProvider::OnExported(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment