Commit a3f2d6fe authored by Victor Costan's avatar Victor Costan Committed by Commit Bot

IndexedDB: Rework usage metric.

Switch from counting usage of the indexedDB property on the global
object to counting indexedDB.open(). The former can get triggered by
code that walks all global properties, while the latter is real
IndexedDB usage.

Change-Id: I36d003321ea0ca24a07034cbce89c33c39c67959
Reviewed-on: https://chromium-review.googlesource.com/1170392Reviewed-by: default avatarDaniel Murphy <dmurph@chromium.org>
Reviewed-by: default avatarKinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582534}
parent 7aaf9dbf
...@@ -17,7 +17,6 @@ enum WebFeature { ...@@ -17,7 +17,6 @@ enum WebFeature {
kOBSOLETE_PageDestruction = 0, kOBSOLETE_PageDestruction = 0,
kWorkerStart = 4, kWorkerStart = 4,
kSharedWorkerStart = 5, kSharedWorkerStart = 5,
kUnprefixedIndexedDB = 9,
kOpenWebDatabase = 10, kOpenWebDatabase = 10,
kUnprefixedRequestAnimationFrame = 13, kUnprefixedRequestAnimationFrame = 13,
kPrefixedRequestAnimationFrame = 14, kPrefixedRequestAnimationFrame = 14,
...@@ -1981,6 +1980,7 @@ enum WebFeature { ...@@ -1981,6 +1980,7 @@ enum WebFeature {
kPPAPIWebSocket = 2524, kPPAPIWebSocket = 2524,
kV8MediaStreamTrack_ContentHint_AttributeGetter = 2525, kV8MediaStreamTrack_ContentHint_AttributeGetter = 2525,
kV8MediaStreamTrack_ContentHint_AttributeSetter = 2526, kV8MediaStreamTrack_ContentHint_AttributeSetter = 2526,
kV8IDBFactory_Open_Method = 2527,
// Add new features immediately above this line. Don't change assigned // Add new features immediately above this line. Don't change assigned
// numbers of any item, and don't reuse removed slots. // numbers of any item, and don't reuse removed slots.
......
...@@ -28,8 +28,13 @@ ...@@ -28,8 +28,13 @@
[ [
Exposed=(Window,Worker) Exposed=(Window,Worker)
] interface IDBFactory { ] interface IDBFactory {
[NewObject, CallWith=ScriptState, RaisesException] IDBOpenDBRequest open(DOMString name, [
optional [EnforceRange] unsigned long long version); NewObject,
CallWith=ScriptState,
Measure,
RaisesException
] IDBOpenDBRequest open(DOMString name,
optional [EnforceRange] unsigned long long version);
[NewObject, CallWith=ScriptState, RaisesException] IDBOpenDBRequest deleteDatabase(DOMString name); [NewObject, CallWith=ScriptState, RaisesException] IDBOpenDBRequest deleteDatabase(DOMString name);
[CallWith=ScriptState, RaisesException] short cmp(any first, any second); [CallWith=ScriptState, RaisesException] short cmp(any first, any second);
......
...@@ -27,5 +27,5 @@ ...@@ -27,5 +27,5 @@
[ [
ImplementedAs=GlobalIndexedDB ImplementedAs=GlobalIndexedDB
] partial interface Window { ] partial interface Window {
[MeasureAs=UnprefixedIndexedDB] readonly attribute IDBFactory indexedDB; readonly attribute IDBFactory indexedDB;
}; };
...@@ -19581,6 +19581,7 @@ Called by update_net_error_codes.py.--> ...@@ -19581,6 +19581,7 @@ Called by update_net_error_codes.py.-->
<int value="2524" label="PPAPIWebSocket"/> <int value="2524" label="PPAPIWebSocket"/>
<int value="2525" label="V8MediaStreamTrack_ContentHint_AttributeGetter"/> <int value="2525" label="V8MediaStreamTrack_ContentHint_AttributeGetter"/>
<int value="2526" label="V8MediaStreamTrack_ContentHint_AttributeSetter"/> <int value="2526" label="V8MediaStreamTrack_ContentHint_AttributeSetter"/>
<int value="2527" label="V8IDBFactory_Open_Method"/>
</enum> </enum>
<enum name="FeedbackSource"> <enum name="FeedbackSource">
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment