Commit a4214e99 authored by Maksim Ivanov's avatar Maksim Ivanov Committed by Commit Bot

Fix use-after-move in //components/update_client/

Fix use-after-move (potential) bugs found by the
"bugprone-use-after-move" clang-tidy check.

Bug: 1122844
Change-Id: I77f9140c2c573a0f969c09f9eb5adc46e2b1d503
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2384029Reviewed-by: default avatarSorin Jianu <sorin@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802957}
parent 9f0ba878
......@@ -1879,9 +1879,7 @@ TEST_F(UpdateClientTest, OneCrxInstallError) {
class MockInstaller : public CrxInstaller {
public:
MOCK_METHOD1(OnUpdateError, void(int error));
MOCK_METHOD2(DoInstall,
void(const base::FilePath& unpack_path,
const Callback& callback));
MOCK_METHOD1(DoInstall, void(const base::FilePath& unpack_path));
MOCK_METHOD2(GetInstalledFile,
bool(const std::string& file, base::FilePath* installed_file));
MOCK_METHOD0(Uninstall, bool());
......@@ -1891,7 +1889,7 @@ TEST_F(UpdateClientTest, OneCrxInstallError) {
std::unique_ptr<InstallParams> /*install_params*/,
ProgressCallback progress_callback,
Callback callback) override {
DoInstall(unpack_path, std::move(callback));
DoInstall(unpack_path);
unpack_path_ = unpack_path;
EXPECT_TRUE(base::DirectoryExists(unpack_path_));
......@@ -1923,7 +1921,7 @@ TEST_F(UpdateClientTest, OneCrxInstallError) {
base::MakeRefCounted<MockInstaller>();
EXPECT_CALL(*installer, OnUpdateError(_)).Times(0);
EXPECT_CALL(*installer, DoInstall(_, _)).Times(1);
EXPECT_CALL(*installer, DoInstall(_)).Times(1);
EXPECT_CALL(*installer, GetInstalledFile(_, _)).Times(0);
EXPECT_CALL(*installer, Uninstall()).Times(0);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment