Commit a443292b authored by Gabriel Charette's avatar Gabriel Charette Committed by Commit Bot

Migrate off BrowserThread::DeleteSoon in /components/safe_browsing

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=vakh@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I9adb0b38d8b12adb9a7571c40928e5ac0de078db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1894885
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: default avatarVarun Khaneja <vakh@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#713149}
parent 234dac3e
...@@ -310,8 +310,8 @@ void BrowserURLLoaderThrottle::NotifySlowCheck() { ...@@ -310,8 +310,8 @@ void BrowserURLLoaderThrottle::NotifySlowCheck() {
} }
void BrowserURLLoaderThrottle::DeleteCheckerOnIO() { void BrowserURLLoaderThrottle::DeleteCheckerOnIO() {
content::BrowserThread::DeleteSoon(content::BrowserThread::IO, FROM_HERE, base::DeleteSoon(FROM_HERE, {content::BrowserThread::IO},
std::move(io_checker_)); std::move(io_checker_));
} }
} // namespace safe_browsing } // namespace safe_browsing
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment