Commit a45fa214 authored by felt's avatar felt Committed by Commit bot

Delete dead error reporting code from the Safe Browsing interstitial

The phishing warning no longer supports error reporting. This CL deletes
the dead code associated with the error reports.

BUG=
R=mattm@chromium.org

Review URL: https://codereview.chromium.org/575723002

Cr-Commit-Position: refs/heads/master@{#295065}
parent 2c8708cc
...@@ -8,7 +8,6 @@ var SB_CMD_DONT_REPORT = 'dontReport'; ...@@ -8,7 +8,6 @@ var SB_CMD_DONT_REPORT = 'dontReport';
var SB_CMD_EXPANDED_SEE_MORE = 'expandedSeeMore'; var SB_CMD_EXPANDED_SEE_MORE = 'expandedSeeMore';
var SB_CMD_LEARN_MORE_2 = 'learnMore2'; var SB_CMD_LEARN_MORE_2 = 'learnMore2';
var SB_CMD_PROCEED = 'proceed'; var SB_CMD_PROCEED = 'proceed';
var SB_CMD_REPORT_ERROR = 'reportError';
var SB_CMD_SHOW_DIAGNOSTIC = 'showDiagnostic'; var SB_CMD_SHOW_DIAGNOSTIC = 'showDiagnostic';
var SB_CMD_SHOW_PRIVACY = 'showPrivacy'; var SB_CMD_SHOW_PRIVACY = 'showPrivacy';
var SB_CMD_TAKE_ME_BACK = 'takeMeBack'; var SB_CMD_TAKE_ME_BACK = 'takeMeBack';
......
...@@ -73,9 +73,6 @@ const char* const kSbDiagnosticUrl = ...@@ -73,9 +73,6 @@ const char* const kSbDiagnosticUrl =
"http://safebrowsing.clients.google.com/safebrowsing/diagnostic?site=%s&client=chromium"; "http://safebrowsing.clients.google.com/safebrowsing/diagnostic?site=%s&client=chromium";
#endif #endif
const char kSbReportPhishingErrorUrl[] =
"http://www.google.com/safebrowsing/report_error/";
// URL for malware and phishing, V2. // URL for malware and phishing, V2.
const char kLearnMoreMalwareUrlV2[] = const char kLearnMoreMalwareUrlV2[] =
"https://www.google.com/transparencyreport/safebrowsing/"; "https://www.google.com/transparencyreport/safebrowsing/";
...@@ -98,7 +95,6 @@ const char kDontReportCommand[] = "dontReport"; ...@@ -98,7 +95,6 @@ const char kDontReportCommand[] = "dontReport";
const char kExpandedSeeMoreCommand[] = "expandedSeeMore"; const char kExpandedSeeMoreCommand[] = "expandedSeeMore";
const char kLearnMoreCommand[] = "learnMore2"; const char kLearnMoreCommand[] = "learnMore2";
const char kProceedCommand[] = "proceed"; const char kProceedCommand[] = "proceed";
const char kReportErrorCommand[] = "reportError";
const char kShowDiagnosticCommand[] = "showDiagnostic"; const char kShowDiagnosticCommand[] = "showDiagnostic";
const char kShowPrivacyCommand[] = "showPrivacy"; const char kShowPrivacyCommand[] = "showPrivacy";
const char kTakeMeBackCommand[] = "takeMeBack"; const char kTakeMeBackCommand[] = "takeMeBack";
...@@ -389,25 +385,6 @@ void SafeBrowsingBlockingPage::CommandReceived(const std::string& cmd) { ...@@ -389,25 +385,6 @@ void SafeBrowsingBlockingPage::CommandReceived(const std::string& cmd) {
} }
std::string bad_url_spec = unsafe_resources_[element_index].url.spec(); std::string bad_url_spec = unsafe_resources_[element_index].url.spec();
if (command == kReportErrorCommand) {
// User pressed "Report error" for a phishing site.
// Note that we cannot just put a link in the interstitial at this point.
// It is not OK to navigate in the context of an interstitial page.
SBThreatType threat_type = unsafe_resources_[element_index].threat_type;
DCHECK(threat_type == SB_THREAT_TYPE_URL_PHISHING ||
threat_type == SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL);
GURL report_url =
safe_browsing_util::GeneratePhishingReportUrl(
kSbReportPhishingErrorUrl,
bad_url_spec,
threat_type == SB_THREAT_TYPE_CLIENT_SIDE_PHISHING_URL);
OpenURLParams params(
report_url, Referrer(), CURRENT_TAB, content::PAGE_TRANSITION_LINK,
false);
web_contents_->OpenURL(params);
return;
}
if (command == kShowDiagnosticCommand) { if (command == kShowDiagnosticCommand) {
// We're going to take the user to Google's SafeBrowsing diagnostic page. // We're going to take the user to Google's SafeBrowsing diagnostic page.
std::string diagnostic = std::string diagnostic =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment