Commit a485b3ae authored by Jinsuk Kim's avatar Jinsuk Kim Committed by Commit Bot

Android: Fix a crash in BrowserControlsManager

Checks if the curren Tab is in destroyed state in order to
prevent BrowserControlsManager from accessing
TabBrowserControlsConstraintsHelper after the tab becomes
invalid.

Bug: 1110909
Change-Id: Ib6cccfdf61abcc18f1f0f5300bc80901c696cef9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418274Reviewed-by: default avatarDavid Trainor <dtrainor@chromium.org>
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809253}
parent 5ec500fe
......@@ -504,7 +504,7 @@ public class BrowserControlsManager
*/
private void setPositionsForTabToNonFullscreen() {
Tab tab = getTab();
if (tab == null
if (tab == null || !tab.isInitialized()
|| TabBrowserControlsConstraintsHelper.getConstraints(tab)
!= BrowserControlsState.HIDDEN) {
setPositionsForTab(0, 0, getTopControlsHeight(), getTopControlsMinHeight(),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment