[Passwords] Init PasswordSaveUpdate*View members in the header

Bug: 1044038
Change-Id: I48ac13f6ffc6f44f990c5dfd7f3248ab3b614d85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248629Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#779336}

chrome/browser/ui/views/passwords/password_save_update_view.cc

@@ -256,11 +256,6 @@ PasswordSaveUpdateView::PasswordSaveUpdateView(
               : PasswordBubbleControllerBase::DisplayReason::kUserAction),
       is_update_bubble_(controller_.state() ==
                         password_manager::ui::PENDING_PASSWORD_UPDATE_STATE),
-      sign_in_promo_(nullptr),
-
-      username_dropdown_(nullptr),
-      password_view_button_(nullptr),
-      password_dropdown_(nullptr),
       are_passwords_revealed_(
           controller_.are_passwords_revealed_when_bubble_is_opened()) {
   DCHECK(controller_.state() == password_manager::ui::PENDING_PASSWORD_STATE ||

chrome/browser/ui/views/passwords/password_save_update_view.h

@@ -74,13 +74,13 @@ class PasswordSaveUpdateView : public PasswordBubbleViewBase,
   // Different promo dialogs that helps the user get access to credentials
   // across devices. One of these are non-null when the promotion dialog is
   // active.
-  PasswordSignInPromoView* sign_in_promo_;
+  PasswordSignInPromoView* sign_in_promo_ = nullptr;
 
-  views::EditableCombobox* username_dropdown_;
-  views::ToggleImageButton* password_view_button_;
+  views::EditableCombobox* username_dropdown_ = nullptr;
+  views::ToggleImageButton* password_view_button_ = nullptr;
 
   // The view for the password value.
-  views::EditableCombobox* password_dropdown_;
+  views::EditableCombobox* password_dropdown_ = nullptr;
 
   bool are_passwords_revealed_;
 };

chrome/browser/ui/views/passwords/password_save_update_with_account_store_view.cc

@@ -345,10 +345,6 @@ PasswordSaveUpdateWithAccountStoreView::PasswordSaveUpdateWithAccountStoreView(
               : PasswordBubbleControllerBase::DisplayReason::kUserAction),
       is_update_bubble_(controller_.state() ==
                         password_manager::ui::PENDING_PASSWORD_UPDATE_STATE),
-
-      username_dropdown_(nullptr),
-      password_view_button_(nullptr),
-      password_dropdown_(nullptr),
       are_passwords_revealed_(
           controller_.are_passwords_revealed_when_bubble_is_opened()) {
   DCHECK(controller_.state() == password_manager::ui::PENDING_PASSWORD_STATE ||

chrome/browser/ui/views/passwords/password_save_update_with_account_store_view.h

@@ -103,11 +103,11 @@ class PasswordSaveUpdateWithAccountStoreView
 
   views::Combobox* destination_dropdown_ = nullptr;
 
-  views::EditableCombobox* username_dropdown_;
-  views::ToggleImageButton* password_view_button_;
+  views::EditableCombobox* username_dropdown_ = nullptr;
+  views::ToggleImageButton* password_view_button_ = nullptr;
 
   // The view for the password value.
-  views::EditableCombobox* password_dropdown_;
+  views::EditableCombobox* password_dropdown_ = nullptr;
   bool are_passwords_revealed_;
 
   feature_engagement::Tracker* iph_tracker_ = nullptr;