Commit a49d219d authored by Peng Huang's avatar Peng Huang Committed by Commit Bot

Use logic rotation with SurfaceControl on Android

For some devices, the hardwarerotation doesn't work with SurfaceControl,
so disable it for now.

Bug: 1136033
Change-Id: Id1ed7971d50ec815fd315fb728315f05e6be9637
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2461550
Auto-Submit: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: default avatarJonathan Backer <backer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#815198}
parent 1752ce3b
......@@ -115,14 +115,12 @@ SkiaOutputDeviceBufferQueue::SkiaOutputDeviceBufferQueue(
capabilities_.number_of_buffers = 3;
capabilities_.orientation_mode = OutputSurface::OrientationMode::kHardware;
#if defined(OS_ANDROID)
// With vulkan, if the chrome is launched in landscape mode, the chrome is
// always blank until chrome window is rotated once. Workaround this problem
// by using logic rotation mode.
// TODO(https://crbug.com/1115065): use hardware orientation mode for vulkan,
if (dependency_->GetSharedContextState()->GrContextIsVulkan() &&
base::FeatureList::GetFieldTrial(features::kVulkan)) {
capabilities_.orientation_mode = OutputSurface::OrientationMode::kLogic;
}
// With some devices, if the chrome is launched in landscape mode, the chrome
// is always blank until chrome window is rotated once. Workaround this
// problem by using logic rotation mode.
// TODO(https://crbug.com/1115065 & https://crbug.com/1136033): use hardware
// orientation mode for vulkan.
capabilities_.orientation_mode = OutputSurface::OrientationMode::kLogic;
#endif
// Force the number of max pending frames to one when the switch
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment