Remove the assertion check for closing the regular Tab.
The code which should close the regular tab was behind an assert and assertion check gets removed in release build which effectively made the code of closing the regular tab non-existent in release build. TabModelImpl#closeTab returns a boolean indicating whether the tab was found which is ambiguous on whether the tab was closed. Hence the assertion on "found the tab" may be misleading for "closed the tab". Bug: 1132000 Change-Id: I15eba93453a58beaa32770017545f045b5b310e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435085Reviewed-by:Alice Wang <aliceywang@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#811198}
Showing
Please register or sign in to comment