Commit a49e7ad6 authored by Rohit Agarwal's avatar Rohit Agarwal Committed by Commit Bot

Remove the assertion check for closing the regular Tab.

The code which should close the regular tab was behind an assert and
assertion check gets removed in release build which effectively made
the code of closing the regular tab non-existent in release build.

TabModelImpl#closeTab returns a boolean indicating whether the tab
was found which is ambiguous on whether the tab was closed. Hence the
assertion on "found the tab" may be misleading for "closed the tab".

Bug: 1132000

Change-Id: I15eba93453a58beaa32770017545f045b5b310e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435085Reviewed-by: default avatarAlice Wang <aliceywang@chromium.org>
Commit-Queue: Rohit Agarwal <roagarwal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#811198}
parent b79e8b80
...@@ -73,6 +73,6 @@ public class IncognitoInterstitialDelegate { ...@@ -73,6 +73,6 @@ public class IncognitoInterstitialDelegate {
Tab currentRegularTab = TabModelUtils.getCurrentTab(mRegularTabModel); Tab currentRegularTab = TabModelUtils.getCurrentTab(mRegularTabModel);
mIncognitoTabCreator.launchUrl( mIncognitoTabCreator.launchUrl(
currentRegularTab.getUrlString(), TabLaunchType.FROM_CHROME_UI); currentRegularTab.getUrlString(), TabLaunchType.FROM_CHROME_UI);
assert mRegularTabModel.closeTab(currentRegularTab); mRegularTabModel.closeTab(currentRegularTab);
} }
} }
\ No newline at end of file
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment