Commit a4e01f2a authored by jvoung@chromium.org's avatar jvoung@chromium.org

Revert "Add a dependency on the AOT shi..." and remove adhoc pexe->nexe disables.

This reverts commit r284737.

It's no longer needed since build_pnacl_newlib plus
enable_${arch} no longer imply that the pexe should be
translated. That's controlled by the 
translate_pexe_with_build flag instead.

Also remove the adhoc uses of enable_x86_32: 0, etc.
now that pexe -> nexe is off by default.

BUG=none

Review URL: https://codereview.chromium.org/433943004

Cr-Commit-Position: refs/heads/master@{#289144}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@289144 0039d316-1c4b-4281-b951-d872f2087c98
parent f55b0b36
...@@ -62,12 +62,6 @@ ...@@ -62,12 +62,6 @@
'nacl_load_test.html', 'nacl_load_test.html',
], ],
}, },
# We only need the pexe for this test. However, build_pnacl_newlib: 1
# will also translate that pexe into a nexe, so add the shim
# just in case of a race condition.
'dependencies': [
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
],
}, },
{ {
'target_name': 'exit_status_test', 'target_name': 'exit_status_test',
...@@ -85,9 +79,6 @@ ...@@ -85,9 +79,6 @@
'exit_status/pm_exit_status_test.html', 'exit_status/pm_exit_status_test.html',
], ],
}, },
'dependencies': [
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
],
}, },
{ {
'target_name': 'extension_validation_cache', 'target_name': 'extension_validation_cache',
...@@ -140,9 +131,6 @@ ...@@ -140,9 +131,6 @@
'sysconf_nprocessors_onln/sysconf_nprocessors_onln_test.html', 'sysconf_nprocessors_onln/sysconf_nprocessors_onln_test.html',
], ],
}, },
'dependencies': [
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
],
}, },
{ {
'target_name': 'ppapi_test_lib', 'target_name': 'ppapi_test_lib',
...@@ -215,7 +203,6 @@ ...@@ -215,7 +203,6 @@
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib', '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib', '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib', '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
'<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib', '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
'ppapi_test_lib', 'ppapi_test_lib',
], ],
...@@ -394,7 +381,6 @@ ...@@ -394,7 +381,6 @@
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib', '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib', '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib', '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
'<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib', '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
'ppapi_test_lib', 'ppapi_test_lib',
], ],
...@@ -423,7 +409,6 @@ ...@@ -423,7 +409,6 @@
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib', '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib', '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib', '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
'<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib', '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
'ppapi_test_lib', 'ppapi_test_lib',
], ],
...@@ -452,7 +437,6 @@ ...@@ -452,7 +437,6 @@
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib', '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib', '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib', '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
'<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib', '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
'ppapi_test_lib', 'ppapi_test_lib',
], ],
...@@ -481,7 +465,6 @@ ...@@ -481,7 +465,6 @@
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib', '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib', '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib', '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
'<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib', '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
'ppapi_test_lib', 'ppapi_test_lib',
], ],
...@@ -510,7 +493,6 @@ ...@@ -510,7 +493,6 @@
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib', '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib', '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib', '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
'<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib', '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
'ppapi_test_lib', 'ppapi_test_lib',
], ],
...@@ -541,7 +523,6 @@ ...@@ -541,7 +523,6 @@
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib', '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib', '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib', '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
'<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib', '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
], ],
}, },
...@@ -780,7 +761,6 @@ ...@@ -780,7 +761,6 @@
'<(DEPTH)/native_client/tools.gyp:prep_toolchain', '<(DEPTH)/native_client/tools.gyp:prep_toolchain',
'<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib', '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib', '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
'<(DEPTH)/native_client/src/shared/srpc/srpc.gyp:srpc_lib', '<(DEPTH)/native_client/src/shared/srpc/srpc.gyp:srpc_lib',
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib', '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib', '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
...@@ -833,10 +813,6 @@ ...@@ -833,10 +813,6 @@
'nexe_target': 'pnacl_debug_url', 'nexe_target': 'pnacl_debug_url',
'build_pnacl_newlib': 1, 'build_pnacl_newlib': 1,
'nexe_destination_dir': 'nacl_test_data', 'nexe_destination_dir': 'nacl_test_data',
# No need to translate these AOT, when we just need the pexe.
'enable_x86_32': 0,
'enable_x86_64': 0,
'enable_arm': 0,
'generate_nmf': 0, 'generate_nmf': 0,
'sources': [ 'sources': [
'simple.cc', 'simple.cc',
...@@ -858,10 +834,6 @@ ...@@ -858,10 +834,6 @@
'variables': { 'variables': {
'build_pnacl_newlib': 1, 'build_pnacl_newlib': 1,
'nexe_destination_dir': 'nacl_test_data', 'nexe_destination_dir': 'nacl_test_data',
# No need to translate AOT.
'enable_x86_32': 0,
'enable_x86_64': 0,
'enable_arm': 0,
# Use prebuilt NMF files. # Use prebuilt NMF files.
'generate_nmf': 0, 'generate_nmf': 0,
'test_files': [ 'test_files': [
...@@ -884,10 +856,6 @@ ...@@ -884,10 +856,6 @@
'build_glibc': 1, 'build_glibc': 1,
'build_pnacl_newlib': 1, 'build_pnacl_newlib': 1,
'nexe_destination_dir': 'nacl_test_data', 'nexe_destination_dir': 'nacl_test_data',
# No need to translate AOT.
'enable_x86_32': 0,
'enable_x86_64': 0,
'enable_arm': 0,
'test_files': [ 'test_files': [
'pnacl_mime_type/pnacl_mime_type.html', 'pnacl_mime_type/pnacl_mime_type.html',
], ],
...@@ -900,10 +868,6 @@ ...@@ -900,10 +868,6 @@
'nexe_target': 'pnacl_options', 'nexe_target': 'pnacl_options',
'build_pnacl_newlib': 1, 'build_pnacl_newlib': 1,
'nexe_destination_dir': 'nacl_test_data', 'nexe_destination_dir': 'nacl_test_data',
# No need to translate these AOT, when we just need the pexe.
'enable_x86_32': 0,
'enable_x86_64': 0,
'enable_arm': 0,
'generate_nmf': 0, 'generate_nmf': 0,
'sources': [ 'sources': [
'simple.cc', 'simple.cc',
...@@ -923,12 +887,6 @@ ...@@ -923,12 +887,6 @@
'target_name': 'pnacl_dyncode_syscall_disabled_test', 'target_name': 'pnacl_dyncode_syscall_disabled_test',
'type': 'none', 'type': 'none',
'variables': { 'variables': {
# This tests that nexes produced by translation in the browser are not
# able to use the dyncode syscalls. Pre-translated nexes are not
# subject to this constraint, so we do not test them.
'enable_x86_32': 0,
'enable_x86_64': 0,
'enable_arm': 0,
'nexe_target': 'pnacl_dyncode_syscall_disabled', 'nexe_target': 'pnacl_dyncode_syscall_disabled',
'build_pnacl_newlib': 1, 'build_pnacl_newlib': 1,
'nexe_destination_dir': 'nacl_test_data', 'nexe_destination_dir': 'nacl_test_data',
...@@ -964,12 +922,6 @@ ...@@ -964,12 +922,6 @@
'target_name': 'pnacl_hw_eh_disabled_test', 'target_name': 'pnacl_hw_eh_disabled_test',
'type': 'none', 'type': 'none',
'variables': { 'variables': {
# This tests that nexes produced by translation in the browser are not
# able to use hardware exception handling. Pre-translated nexes are
# not subject to this constraint, so we do not test them.
'enable_x86_32': 0,
'enable_x86_64': 0,
'enable_arm': 0,
'nexe_target': 'pnacl_hw_eh_disabled', 'nexe_target': 'pnacl_hw_eh_disabled',
'build_pnacl_newlib': 1, 'build_pnacl_newlib': 1,
'nexe_destination_dir': 'nacl_test_data', 'nexe_destination_dir': 'nacl_test_data',
...@@ -1029,7 +981,6 @@ ...@@ -1029,7 +981,6 @@
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib', '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib', '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib', '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
'<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib', '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
'ppapi_test_lib', 'ppapi_test_lib',
], ],
...@@ -1061,7 +1012,6 @@ ...@@ -1061,7 +1012,6 @@
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib', '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib', '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib', '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
'<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib', '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
'ppapi_test_lib', 'ppapi_test_lib',
], ],
...@@ -1094,7 +1044,6 @@ ...@@ -1094,7 +1044,6 @@
'<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib', '<(DEPTH)/native_client/src/shared/platform/platform.gyp:platform_lib',
'<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib', '<(DEPTH)/native_client/src/shared/gio/gio.gyp:gio_lib',
'<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib', '<(DEPTH)/ppapi/native_client/native_client.gyp:ppapi_lib',
'<(DEPTH)/ppapi/native_client/src/untrusted/pnacl_irt_shim/pnacl_irt_shim.gyp:aot',
'<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib', '<(DEPTH)/ppapi/ppapi_nacl.gyp:ppapi_cpp_lib',
'ppapi_test_lib', 'ppapi_test_lib',
], ],
......
...@@ -146,8 +146,6 @@ ...@@ -146,8 +146,6 @@
'build_glibc': 0, 'build_glibc': 0,
'build_newlib': 0, 'build_newlib': 0,
'build_pnacl_newlib': 1, 'build_pnacl_newlib': 1,
'enable_x86_32': 0,
'enable_x86_64': 0,
'extra_deps_pnacl_newlib': [ 'extra_deps_pnacl_newlib': [
'>(tc_lib_dir_pnacl_newlib)/libbase_i18n_nacl.a', '>(tc_lib_dir_pnacl_newlib)/libbase_i18n_nacl.a',
'>(tc_lib_dir_pnacl_newlib)/libbase_nacl.a', '>(tc_lib_dir_pnacl_newlib)/libbase_nacl.a',
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment