Commit a4e106d4 authored by Alex Cooper's avatar Alex Cooper Committed by Commit Bot

Delete WebVR Rappor Metrics

Support for Rappor metrics is being removed, and WebVr is also being
removed.  This change removes some WebVr Rappor metrics (note that some
instances where these metrics were logged has been previously deleted)

Bug: 1016906,960132
Change-Id: Idd4f8de112de0eb5c714dc616c850bf1e92f2ef1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879697Reviewed-by: default avatarRobert Kaplow <rkaplow@chromium.org>
Reviewed-by: default avatarKlaus Weidner <klausw@chromium.org>
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709146}
parent 79aee8c7
...@@ -7,7 +7,6 @@ ...@@ -7,7 +7,6 @@
#include "base/logging.h" #include "base/logging.h"
#include "base/metrics/histogram_functions.h" #include "base/metrics/histogram_functions.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
#include "components/rappor/public/rappor_utils.h"
#include "components/ukm/content/source_url_recorder.h" #include "components/ukm/content/source_url_recorder.h"
#include "content/public/browser/browser_thread.h" #include "content/public/browser/browser_thread.h"
#include "content/public/browser/navigation_handle.h" #include "content/public/browser/navigation_handle.h"
...@@ -31,36 +30,6 @@ constexpr base::TimeDelta kMinimumHeadsetSessionDuration( ...@@ -31,36 +30,6 @@ constexpr base::TimeDelta kMinimumHeadsetSessionDuration(
constexpr base::TimeDelta kMaximumHeadsetSessionGap( constexpr base::TimeDelta kMaximumHeadsetSessionGap(
base::TimeDelta::FromSecondsD(0)); base::TimeDelta::FromSecondsD(0));
void SendRapporEnteredMode(const GURL& origin, Mode mode) {
switch (mode) {
case Mode::kVrBrowsingFullscreen:
rappor::SampleDomainAndRegistryFromGURL(rappor::GetDefaultService(),
"VR.FullScreenMode", origin);
break;
default:
break;
}
}
void SendRapporEnteredVideoMode(const GURL& origin, Mode mode) {
switch (mode) {
case Mode::kVrBrowsingRegular:
rappor::SampleDomainAndRegistryFromGURL(rappor::GetDefaultService(),
"VR.Video.Browser", origin);
break;
case Mode::kWebXrVrPresentation:
rappor::SampleDomainAndRegistryFromGURL(rappor::GetDefaultService(),
"VR.Video.WebVR", origin);
break;
case Mode::kVrBrowsingFullscreen:
rappor::SampleDomainAndRegistryFromGURL(
rappor::GetDefaultService(), "VR.Video.FullScreenMode", origin);
break;
default:
break;
}
}
// Handles the lifetime of the helper which is attached to a WebContents. // Handles the lifetime of the helper which is attached to a WebContents.
class SessionMetricsHelperData : public base::SupportsUserData::Data { class SessionMetricsHelperData : public base::SupportsUserData::Data {
public: public:
...@@ -438,10 +407,7 @@ void SessionMetricsHelper::SetVrMode(Mode new_mode) { ...@@ -438,10 +407,7 @@ void SessionMetricsHelper::SetVrMode(Mode new_mode) {
mode_timer_->StartSession(switch_time); mode_timer_->StartSession(switch_time);
if (num_videos_playing_ > 0) { if (num_videos_playing_ > 0) {
mode_video_timer_->StartSession(switch_time); mode_video_timer_->StartSession(switch_time);
SendRapporEnteredVideoMode(origin_, new_mode);
} }
SendRapporEnteredMode(origin_, new_mode);
} }
mode_ = new_mode; mode_ = new_mode;
...@@ -570,7 +536,6 @@ void SessionMetricsHelper::MediaStartedPlaying( ...@@ -570,7 +536,6 @@ void SessionMetricsHelper::MediaStartedPlaying(
if (mode_ != Mode::kNoVr) { if (mode_ != Mode::kNoVr) {
session_video_timer_->StartSession(start_time); session_video_timer_->StartSession(start_time);
mode_video_timer_->StartSession(start_time); mode_video_timer_->StartSession(start_time);
SendRapporEnteredVideoMode(origin_, mode_);
} }
} }
......
...@@ -1309,50 +1309,6 @@ now we are only interested in H264, VP8 and VP9. ...@@ -1309,50 +1309,6 @@ now we are only interested in H264, VP8 and VP9.
</summary> </summary>
</rappor-metric> </rappor-metric>
<rappor-metric name="VR.FullScreenMode" type="ETLD_PLUS_ONE">
<owner>billorr@chromium.org</owner>
<summary>
The host of the URL for pages that enter a fullscreen experience while in
VR.
</summary>
</rappor-metric>
<rappor-metric name="VR.Video.Browser" type="ETLD_PLUS_ONE">
<owner>billorr@chromium.org</owner>
<summary>
The host of URL that played video while in the VR browser
</summary>
</rappor-metric>
<rappor-metric name="VR.Video.Fullscreen" type="ETLD_PLUS_ONE">
<owner>billorr@chromium.org</owner>
<summary>
The host of the URL that played video while in a fullscreen experience in
VR.
</summary>
</rappor-metric>
<rappor-metric name="VR.Video.WebVR" type="ETLD_PLUS_ONE">
<owner>billorr@chromium.org</owner>
<summary>
The host of the URL that played video while in WebVR.
</summary>
</rappor-metric>
<rappor-metric name="VR.WebVR.GetDisplays" type="ETLD_PLUS_ONE">
<owner>billorr@chromium.org</owner>
<summary>
The host of the URL that called WebVR APIs to obtain the list of VRDisplays.
</summary>
</rappor-metric>
<rappor-metric name="VR.WebVR.PresentSuccess" type="ETLD_PLUS_ONE">
<owner>billorr@chromium.org</owner>
<summary>
The host of the URL that succeeded in presenting WebVR content.
</summary>
</rappor-metric>
<rappor-metric name="WebComponents.EventPath" type="ETLD_PLUS_ONE"> <rappor-metric name="WebComponents.EventPath" type="ETLD_PLUS_ONE">
<owner>kojii@chromium.org</owner> <owner>kojii@chromium.org</owner>
<summary> <summary>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment