Bad-cast to blink::RTCVoidRequest from invalid vptr in blink::OnReplaceTrackCompleted
This CL fixes the clusterfuzz issues reported (see "Fixed" below) by using WTF::Bind and WrapPersistent in RTCRtpSenderImpl::ReplaceTrack. This is a regression from crrev.com/c/1899786, where code used to have a WebRTCVoidRequest wrapping RTCVoidRequest instances (garbage collected). Now that RTCVoidRequest is used directly, we need to properly wrap-persist its instances with WTF::WrapPersistent when passing it to callbacks. Reason: With Oilpan and WTF::Bind, raw pointers of garbage collected objects are not allowed. Fixed:1022558 R=hbos@chormium.org, jbroman@chromium.org Change-Id: I8f0fcf7275c9e07240e3b2e20f89c4cf96c72439 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1906506 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#713853}
Showing
Please register or sign in to comment