Fix HintsFetcher request status histogram name

Got botched during migration but kept it with the old naming for
consistency

Change-Id: I66730a4e98868981a5f9536ee2e27b0d0b461d2a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025230Reviewed-by: Michael Crouse <mcrouse@chromium.org>
Commit-Queue: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736158}

components/optimization_guide/hints_fetcher.cc

@@ -70,7 +70,7 @@ std::vector<GURL> GetValidURLsForFetching(const std::vector<GURL>& urls) {
 void RecordRequestStatusHistogram(proto::RequestContext request_context,
                                   HintsFetcherRequestStatus status) {
   base::UmaHistogramEnumeration(
-      "OptimizationGuide.HintsFetcher.GetHintsRequest.RequestStatus." +
+      "OptimizationGuide.HintsFetcher.RequestStatus." +
           GetStringNameForRequestContext(request_context),
       status);
 }

components/optimization_guide/hints_fetcher_unittest.cc

@@ -171,8 +171,7 @@ TEST_F(HintsFetcherTest, FetchOptimizationGuideServiceHints) {
       "OptimizationGuide.HintsFetcher.GetHintsRequest.FetchLatency.BatchUpdate",
       1);
   histogram_tester.ExpectUniqueSample(
-      "OptimizationGuide.HintsFetcher.GetHintsRequest.RequestStatus."
-      "BatchUpdate",
+      "OptimizationGuide.HintsFetcher.RequestStatus.BatchUpdate",
       HintsFetcherRequestStatus::kSuccess, 1);
 }
 
@@ -189,8 +188,7 @@ TEST_F(HintsFetcherTest, FetchInProgress) {
     EXPECT_TRUE(FetchHints({"foo.com"}, {} /* urls */));
     EXPECT_FALSE(FetchHints({"bar.com"}, {} /* urls */));
     histogram_tester.ExpectUniqueSample(
-        "OptimizationGuide.HintsFetcher.GetHintsRequest.RequestStatus."
-        "BatchUpdate",
+        "OptimizationGuide.HintsFetcher.RequestStatus.BatchUpdate",
         HintsFetcherRequestStatus::kFetcherBusy, 1);
   }
 
@@ -201,8 +199,7 @@ TEST_F(HintsFetcherTest, FetchInProgress) {
     SimulateResponse(response_content, net::HTTP_OK);
     EXPECT_TRUE(FetchHints({"bar.com"}, {} /* urls */));
     histogram_tester.ExpectUniqueSample(
-        "OptimizationGuide.HintsFetcher.GetHintsRequest.RequestStatus."
-        "BatchUpdate",
+        "OptimizationGuide.HintsFetcher.RequestStatus.BatchUpdate",
         HintsFetcherRequestStatus::kSuccess, 1);
   }
 }
@@ -277,8 +274,7 @@ TEST_F(HintsFetcherTest, FetchReturned404) {
   histogram_tester.ExpectTotalCount(
       "OptimizationGuide.HintsFetcher.GetHintsRequest.FetchLatency", 0);
   histogram_tester.ExpectUniqueSample(
-      "OptimizationGuide.HintsFetcher.GetHintsRequest.RequestStatus."
-      "BatchUpdate",
+      "OptimizationGuide.HintsFetcher.RequestStatus.BatchUpdate",
       HintsFetcherRequestStatus::kResponseError, 1);
 }
 
@@ -295,8 +291,7 @@ TEST_F(HintsFetcherTest, FetchReturnBadResponse) {
   histogram_tester.ExpectTotalCount(
       "OptimizationGuide.HintsFetcher.GetHintsRequest.FetchLatency", 0);
   histogram_tester.ExpectUniqueSample(
-      "OptimizationGuide.HintsFetcher.GetHintsRequest.RequestStatus."
-      "BatchUpdate",
+      "OptimizationGuide.HintsFetcher.RequestStatus.BatchUpdate",
       HintsFetcherRequestStatus::kResponseError, 1);
 }
 
@@ -312,8 +307,7 @@ TEST_F(HintsFetcherTest, FetchAttemptWhenNetworkOffline) {
   histogram_tester.ExpectTotalCount(
       "OptimizationGuide.HintsFetcher.GetHintsRequest.FetchLatency", 0);
   histogram_tester.ExpectUniqueSample(
-      "OptimizationGuide.HintsFetcher.GetHintsRequest.RequestStatus."
-      "BatchUpdate",
+      "OptimizationGuide.HintsFetcher.RequestStatus.BatchUpdate",
       HintsFetcherRequestStatus::kNetworkOffline, 1);
 
   SetConnectionOnline();
@@ -557,8 +551,7 @@ TEST_F(HintsFetcherTest, OnlyURLsToFetch) {
       "OptimizationGuide.HintsFetcher.GetHintsRequest.FetchLatency.BatchUpdate",
       1);
   histogram_tester.ExpectUniqueSample(
-      "OptimizationGuide.HintsFetcher.GetHintsRequest.RequestStatus."
-      "BatchUpdate",
+      "OptimizationGuide.HintsFetcher.RequestStatus.BatchUpdate",
       static_cast<int>(HintsFetcherRequestStatus::kSuccess), 1);
 }
 
@@ -569,8 +562,7 @@ TEST_F(HintsFetcherTest, NoHostsOrURLsToFetch) {
   EXPECT_FALSE(FetchHints({} /* hosts */, {} /* urls */));
   EXPECT_FALSE(hints_fetched());
   histogram_tester.ExpectUniqueSample(
-      "OptimizationGuide.HintsFetcher.GetHintsRequest.RequestStatus."
-      "BatchUpdate",
+      "OptimizationGuide.HintsFetcher.RequestStatus.BatchUpdate",
       static_cast<int>(HintsFetcherRequestStatus::kNoHostsOrURLsToFetch), 1);
 }