Commit a523cc82 authored by Sergey Ulanov's avatar Sergey Ulanov Committed by Commit Bot

Reland "Add NotoSansCJK font to content_shell_fonts collection."

This is a reland of 81325ee9.

Fixed issue in base.py: NotoSansCJKkr-Regular.otf -> NotoSansCJKjp-Regular.otf

Original change's description:
> Add NotoSansCJK font to content_shell_fonts collection.
>
> Currently the set of fonts used for layout tests on Android and Fuchsia
> doesn't include any Chinese, Japanese or Korean fonts, so they render tofu
> on the pixel tests that contain text in these languages. Adding NotoSansCJK
> so these tests can render properly.
>
> Bug: 778467, 787020
> Change-Id: Id29b65525d5af0be96984db69e62d9d198b87fd4
> Reviewed-on: https://chromium-review.googlesource.com/910122
> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
> Reviewed-by: Scott Violet <sky@chromium.org>
> Reviewed-by: Dirk Pranke <dpranke@chromium.org>
> Reviewed-by: Dominik Röttsches <drott@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#536920}

TBR=sky@chromium.org,dpranke@chromium.org,drott@chromium.org

Bug: 778467, 787020
Change-Id: I722cb2989504848a7ecc131ab5a8209fe8cafca6
Reviewed-on: https://chromium-review.googlesource.com/923720Reviewed-by: default avatarSergey Ulanov <sergeyu@chromium.org>
Reviewed-by: default avatarDirk Pranke <dpranke@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#537394}
parent 3f2e2f3a
......@@ -30,6 +30,11 @@
<file>MuktiNarrow.ttf</file>
</fileset>
</family>
<family>
<fileset>
<file>NotoSansCJKkr-Regular.otf</file>
</fileset>
</family>
<family>
<fileset>
<file>NotoSansKhmer-Regular.ttf</file>
......
......@@ -109,6 +109,7 @@ FONT_FILES = [
[[CONTENT_SHELL_FONTS_DIR], 'Lohit-Tamil.ttf', None],
[[CONTENT_SHELL_FONTS_DIR], 'MuktiNarrow.ttf', None],
[[CONTENT_SHELL_FONTS_DIR], 'NotoSansKhmer-Regular.ttf', None],
[[CONTENT_SHELL_FONTS_DIR], 'NotoSansCJKjp-Regular.otf', None],
]
......
......@@ -11,6 +11,7 @@ copy("content_shell_fonts") {
"content_shell_test_fonts/Lohit-Gurmukhi.ttf",
"content_shell_test_fonts/Lohit-Tamil.ttf",
"content_shell_test_fonts/MuktiNarrow.ttf",
"content_shell_test_fonts/NotoSansCJKjp-Regular.otf",
"content_shell_test_fonts/NotoSansKhmer-Regular.ttf",
]
......
......@@ -28,7 +28,8 @@ How to update or add fonts:
by executing the following command:
$ git add ./third_party/content_shell_fonts/content_shell_test_fonts.tar.gz.sha1
7. (optional) Modify loaded kSystemFontsForFontconfig and
kCloudStorageSyncedFonts lists in fontconfig_util_linux.cc
kCloudStorageSyncedFonts lists in fontconfig_util_linux.cc . Also update
FONT_FILES in third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py .
If you need access to the chromium-fonts bucket, contact Chrome infra. For
details, please refer to
......@@ -42,4 +43,5 @@ Lohit-Devanagari.ttf https://pagure.io/lohit
Lohit-Gurmukhi.ttf https://pagure.io/lohit
Lohit-Tamil.ttf https://pagure.io/lohit
MuktiNarrow.ttf http://www.nongnu.org/freebangfont/downloads.html#mukti
NotoSansCJKjp-Regular.otf https://www.google.com/get/noto/#sans-jpan
NotoSansKhmer-Regular.ttf https://www.google.com/get/noto/#sans-khmr
df8105c58d91885e7cf812488a26cdcb6363f187
\ No newline at end of file
eea1fc91877797451ff7cff29e49a3e15e1d9ee1
\ No newline at end of file
......@@ -56,8 +56,14 @@ const size_t kNumSystemFontsForFontconfig =
const char* const kCloudStorageSyncedFonts[] = {
// The DejaVuSans font is used by the css2.1 tests.
"DejaVuSans.ttf", "Garuda.ttf", "Lohit-Devanagari.ttf",
"Lohit-Tamil.ttf", "Lohit-Gurmukhi.ttf", "MuktiNarrow.ttf",
"DejaVuSans.ttf",
"Garuda.ttf",
"Lohit-Devanagari.ttf",
"Lohit-Tamil.ttf",
"Lohit-Gurmukhi.ttf",
"MuktiNarrow.ttf",
// TODO(sergeyu): Uncomment this and update test expectations.
// "NotoSansCJKjp-Regular.otf",
"NotoSansKhmer-Regular.ttf"};
const size_t kNumCloudStorageSyncedFonts = arraysize(kCloudStorageSyncedFonts);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment