Commit a52cf20a authored by dominich@chromium.org's avatar dominich@chromium.org

Adding histograms for better Omnibox prerender performance tracking.


Review URL: http://codereview.chromium.org/8602005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@111207 0039d316-1c4b-4281-b951-d872f2087c98
parent 9fc72569
...@@ -289,6 +289,9 @@ void NetworkActionPredictor::OnOmniboxOpenedUrl(const AutocompleteLog& log) { ...@@ -289,6 +289,9 @@ void NetworkActionPredictor::OnOmniboxOpenedUrl(const AutocompleteLog& log) {
if (log.text.length() < kMinimumUserTextLength) if (log.text.length() < kMinimumUserTextLength)
return; return;
UMA_HISTOGRAM_COUNTS("NetworkActionPredictor.NavigationCount_" +
prerender::GetOmniboxHistogramSuffix(), 1);
const GURL& opened_url = const GURL& opened_url =
log.result.match_at(log.selected_index).destination_url; log.result.match_at(log.selected_index).destination_url;
......
...@@ -9,6 +9,7 @@ ...@@ -9,6 +9,7 @@
#include "base/metrics/field_trial.h" #include "base/metrics/field_trial.h"
#include "base/metrics/histogram.h" #include "base/metrics/histogram.h"
#include "chrome/browser/prerender/prerender_util.h" #include "chrome/browser/prerender/prerender_util.h"
#include "chrome/browser/prerender/prerender_field_trial.h"
namespace prerender { namespace prerender {
...@@ -147,6 +148,21 @@ void PrerenderHistograms::RecordPrerender(Origin origin, const GURL& url) { ...@@ -147,6 +148,21 @@ void PrerenderHistograms::RecordPrerender(Origin origin, const GURL& url) {
seen_pageload_started_after_prerender_ = false; seen_pageload_started_after_prerender_ = false;
} }
void PrerenderHistograms::RecordPrerenderFromOmnibox() const {
UMA_HISTOGRAM_COUNTS("Prerender.OmniboxPrerenderCount_" +
GetOmniboxHistogramSuffix(), 1);
}
void PrerenderHistograms::RecordOmniboxUsedPrerender(Origin origin) const {
if (origin == ORIGIN_OMNIBOX_ORIGINAL ||
origin == ORIGIN_OMNIBOX_CONSERVATIVE ||
origin == ORIGIN_OMNIBOX_EXACT ||
origin == ORIGIN_OMNIBOX_EXACT_FULL) {
UMA_HISTOGRAM_COUNTS("Prerender.OmniboxNavigationsUsedPrerenderCount_" +
GetOmniboxHistogramSuffix(), 1);
}
}
base::TimeTicks PrerenderHistograms::GetCurrentTimeTicks() const { base::TimeTicks PrerenderHistograms::GetCurrentTimeTicks() const {
return base::TimeTicks::Now(); return base::TimeTicks::Now();
} }
......
...@@ -55,6 +55,13 @@ class PrerenderHistograms { ...@@ -55,6 +55,13 @@ class PrerenderHistograms {
// To be called when a new prerender is added. // To be called when a new prerender is added.
void RecordPrerender(Origin origin, const GURL& url); void RecordPrerender(Origin origin, const GURL& url);
// Called when a prerender is added with an Omnibox origin.
void RecordPrerenderFromOmnibox() const;
// Called when we swap in a prerender. Checks if the origin is Omnibox before
// recording the count.
void RecordOmniboxUsedPrerender(Origin origin) const;
private: private:
base::TimeTicks GetCurrentTimeTicks() const; base::TimeTicks GetCurrentTimeTicks() const;
......
...@@ -358,6 +358,8 @@ bool PrerenderManager::AddPrerenderFromOmnibox( ...@@ -358,6 +358,8 @@ bool PrerenderManager::AddPrerenderFromOmnibox(
break; break;
}; };
histograms_->RecordPrerenderFromOmnibox();
return AddPrerender(origin, std::make_pair(-1, -1), url, GURL(), return AddPrerender(origin, std::make_pair(-1, -1), url, GURL(),
session_storage_namespace); session_storage_namespace);
} }
...@@ -646,6 +648,8 @@ bool PrerenderManager::MaybeUsePrerenderedPage(TabContents* tab_contents, ...@@ -646,6 +648,8 @@ bool PrerenderManager::MaybeUsePrerenderedPage(TabContents* tab_contents,
histograms_->RecordPerSessionCount(++prerenders_per_session_count_); histograms_->RecordPerSessionCount(++prerenders_per_session_count_);
prerender_contents->set_final_status(FINAL_STATUS_USED); prerender_contents->set_final_status(FINAL_STATUS_USED);
histograms_->RecordOmniboxUsedPrerender(prerender_contents->origin());
new_render_view_host->Send( new_render_view_host->Send(
new ChromeViewMsg_SetIsPrerendering(new_render_view_host->routing_id(), new ChromeViewMsg_SetIsPrerendering(new_render_view_host->routing_id(),
false)); false));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment