Skip to content

GitLab

T
tangled
Commit a532f9f7 authored by Edward Jung's avatar Edward Jung Committed by Commit Bot
Browse files
Options

Remove SecurityInterstitialsDarkMode experiment 

Experiment period has not seen any statistically differences in
proceed or action rates on the security interstitials.

Removing all experiment code. This will also fix the refresh flicker
from the JS classname switching.

Bug: 978002
Change-Id: Ida9649772ff6e5e0ddbcc10f779c3545884e42ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010947
Commit-Queue: Edward Jung (EMEA) <edwardjung@chromium.org>
Reviewed-by: default avatarJohn Delaney <johnidel@chromium.org>
Reviewed-by: default avatarCarlos IL <carlosil@chromium.org>
Reviewed-by: default avatarSteven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736789}
parent a27f05c1
Hide whitespace changes
Inline Side-by-side
Showing with 1 addition and 82 deletions
chrome/browser/about_flags.cc
View file @ a532f9f7
......@@ -4367,12 +4367,6 @@ const FeatureEntry kFeatureEntries[] = {
flag_descriptions::kEvDetailsInPageInfoDescription, kOsDesktop,
FEATURE_VALUE_TYPE(features::kEvDetailsInPageInfo)},
{"security-interstitials-dark-mode",
flag_descriptions::kSecurityInterstitialsDarkModeName,
flag_descriptions::kSecurityInterstitialsDarkModeDescription, kOsAll,
FEATURE_VALUE_TYPE(
security_interstitials::kSecurityInterstitialsDarkMode)},
{"enable-autofill-credit-card-upload-feedback",
flag_descriptions::kEnableAutofillCreditCardUploadFeedbackName,
flag_descriptions::kEnableAutofillCreditCardUploadFeedbackDescription,
......
chrome/browser/flag_descriptions.cc
View file @ a532f9f7
......@@ -1650,12 +1650,6 @@ const char kScrollableTabStripDescription[] =
"Allows users to access tabs by scrolling when they no longer fit in the "
"tabstrip.";
const char kSecurityInterstitialsDarkModeName[] =
"Security interstitials dark mode";
const char kSecurityInterstitialsDarkModeDescription[] =
"Allows security intersitials to take on a dark theme when the OS is "
"switched to dark mode.";
const char kSendTabToSelfBroadcastName[] = "Send tab to self broadcast";
const char kSendTabToSelfBroadcastDescription[] =
"Allows users to broadcast the tab they send to all of their devices "
......
chrome/browser/flag_descriptions.h
View file @ a532f9f7
......@@ -963,9 +963,6 @@ extern const char kScalableAppListDescription[];
extern const char kScrollableTabStripName[];
extern const char kScrollableTabStripDescription[];
extern const char kSecurityInterstitialsDarkModeName[];
extern const char kSecurityInterstitialsDarkModeDescription[];
extern const char kSendTabToSelfBroadcastName[];
extern const char kSendTabToSelfBroadcastDescription[];
......
chrome/browser/heavy_ad_intervention/heavy_ad_helper.cc
View file @ a532f9f7
......@@ -47,9 +47,6 @@ std::string PrepareHeavyAdPage() {
load_time_data.SetBoolean("overridable", false);
load_time_data.SetBoolean("is_giant", false);
security_interstitials::common_string_util::PopulateDarkModeDisplaySetting(
&load_time_data);
webui::SetLoadTimeDataDefaults(g_browser_process->GetApplicationLocale(),
&load_time_data);
......
chrome/browser/lookalikes/lookalike_url_interstitial_page.cc
View file @ a532f9f7
......@@ -84,8 +84,6 @@ void LookalikeUrlInterstitialPage::PopulateInterstitialStrings(
CHECK(load_time_data);
PopulateStringsForSharedHTML(load_time_data);
security_interstitials::common_string_util::PopulateDarkModeDisplaySetting(
load_time_data);
const base::string16 hostname =
security_interstitials::common_string_util::GetFormattedHostName(
......
components/security_interstitials/core/bad_clock_ui.cc
View file @ a532f9f7
......@@ -42,7 +42,6 @@ void BadClockUI::PopulateStringsForHTML(base::DictionaryValue* load_time_data) {
common_string_util::PopulateSSLLayoutStrings(cert_error_, load_time_data);
common_string_util::PopulateSSLDebuggingStrings(ssl_info_, time_triggered_,
load_time_data);
common_string_util::PopulateDarkModeDisplaySetting(load_time_data);
// Clock-specific strings.
PopulateClockStrings(load_time_data);
......
components/security_interstitials/core/blocked_interception_ui.cc
View file @ a532f9f7
......@@ -47,7 +47,6 @@ void BlockedInterceptionUI::PopulateStringsForHTML(
common_string_util::PopulateSSLLayoutStrings(cert_error_, load_time_data);
common_string_util::PopulateSSLDebuggingStrings(
ssl_info_, base::Time::NowFromSystemTime(), load_time_data);
common_string_util::PopulateDarkModeDisplaySetting(load_time_data);
load_time_data->SetBoolean("overridable", true);
load_time_data->SetBoolean("hide_primary_button", false);
......
components/security_interstitials/core/browser/resources/interstitial_large.js
View file @ a532f9f7
......@@ -78,11 +78,6 @@ function setupEvents() {
const showRecurrentErrorParagraph = loadTimeData.getBoolean(
'show_recurrent_error_paragraph');
if (loadTimeData.valueExists('darkModeAvailable') &&
loadTimeData.getBoolean('darkModeAvailable')) {
$('body').classList.add('dark-mode-available');
}
if (ssl || originPolicy || blockedInterception || legacyTls) {
$('body').classList.add(badClock ? 'bad-clock' : 'ssl');
$('error-code').textContent = loadTimeData.getString('errorCode');
......
components/security_interstitials/core/browser/resources/interstitial_webview_quiet.js
View file @ a532f9f7
......@@ -20,17 +20,12 @@ function onResize() {
function initPage() {
const isGiantWebView = loadTimeData.getBoolean('is_giant');
const darkModeAvailable = loadTimeData.getBoolean('darkModeAvailable');
const interstitialType = loadTimeData.getString('type');
const safebrowsing = interstitialType === 'SAFEBROWSING';
const heavyAd = interstitialType === 'HEAVYAD';
document.body.className = isGiantWebView ? 'giant' : '';
if (darkModeAvailable) {
document.body.classList.add('dark-mode-available');
}
if (heavyAd) {
document.body.classList.add('heavy-ad');
}
......
components/security_interstitials/core/common/resources/interstitial_core.css
View file @ a532f9f7
......@@ -64,11 +64,7 @@ html {
}
@media (prefers-color-scheme: dark) {
body.captive-portal,
body.dark-mode-available,
body.neterror,
body.supervised-user-block,
.offline body {
body {
--background-color: var(--google-gray-900);
--error-code-color: var(--google-gray-500);
--heading-color: var(--google-gray-500);
......
components/security_interstitials/core/common_string_util.cc
View file @ a532f9f7
......@@ -64,13 +64,6 @@ void PopulateSSLDebuggingStrings(const net::SSLInfo ssl_info,
load_time_data->SetString("pem", base::StrCat(encoded_chain));
}
void PopulateDarkModeDisplaySetting(base::DictionaryValue* load_time_data) {
load_time_data->SetBoolean(
"darkModeAvailable",
base::FeatureList::IsEnabled(
security_interstitials::kSecurityInterstitialsDarkMode));
}
} // namespace common_string_util
} // namespace security_interstitials
components/security_interstitials/core/common_string_util.h
View file @ a532f9f7
......@@ -32,10 +32,6 @@ void PopulateSSLDebuggingStrings(const net::SSLInfo ssl_info,
// For determining whether to use the old or new icon sets.
void PopulateNewIconStrings(base::DictionaryValue* load_time_data);
// Populate a 'darkModeAvailable' boolean in |load_time_data| that specifies
// whether dark mode styling is available.
void PopulateDarkModeDisplaySetting(base::DictionaryValue* load_time_data);
} // common_string_util
} // namespace security_interstitials
......
components/security_interstitials/core/features.cc
View file @ a532f9f7
......@@ -6,7 +6,4 @@
namespace security_interstitials {
const base::Feature kSecurityInterstitialsDarkMode{
"SecurityInterstitialsDarkMode", base::FEATURE_DISABLED_BY_DEFAULT};
} // namespace security_interstitials
components/security_interstitials/core/features.h
View file @ a532f9f7
......@@ -9,9 +9,6 @@
namespace security_interstitials {
// Controls whether dark mode themes are applied to security interstitials.
extern const base::Feature kSecurityInterstitialsDarkMode;
} // namespace security_interstitials
#endif // COMPONENTS_SECURITY_INTERSTITIALS_CORE_FEATURES_H_
components/security_interstitials/core/legacy_tls_ui.cc
View file @ a532f9f7
......@@ -54,7 +54,6 @@ void LegacyTLSUI::PopulateStringsForHTML(
common_string_util::PopulateSSLLayoutStrings(cert_error_, load_time_data);
common_string_util::PopulateSSLDebuggingStrings(
ssl_info_, base::Time::NowFromSystemTime(), load_time_data);
common_string_util::PopulateDarkModeDisplaySetting(load_time_data);
load_time_data->SetBoolean("overridable", true);
load_time_data->SetBoolean("hide_primary_button", false);
load_time_data->SetBoolean("bad_clock", false);
......
components/security_interstitials/core/mitm_software_ui.cc
View file @ a532f9f7
......@@ -44,7 +44,6 @@ void MITMSoftwareUI::PopulateStringsForHTML(
common_string_util::PopulateSSLLayoutStrings(cert_error_, load_time_data);
common_string_util::PopulateSSLDebuggingStrings(
ssl_info_, base::Time::NowFromSystemTime(), load_time_data);
common_string_util::PopulateDarkModeDisplaySetting(load_time_data);
// Set display booleans.
load_time_data->SetBoolean("overridable", false);
......
components/security_interstitials/core/safe_browsing_loud_error_ui.cc
View file @ a532f9f7
......@@ -316,8 +316,6 @@ void SafeBrowsingLoudErrorUI::PopulateExtendedReportingOption(
void SafeBrowsingLoudErrorUI::PopulateBillingLoadTimeData(
base::DictionaryValue* load_time_data) {
common_string_util::PopulateDarkModeDisplaySetting(load_time_data);
load_time_data->SetBoolean("phishing", false);
load_time_data->SetBoolean("overridable", true);
......
components/security_interstitials/core/safe_browsing_quiet_error_ui.cc
View file @ a532f9f7
......@@ -51,8 +51,6 @@ void SafeBrowsingQuietErrorUI::PopulateStringsForHtml(
base::DictionaryValue* load_time_data) {
DCHECK(load_time_data);
common_string_util::PopulateDarkModeDisplaySetting(load_time_data);
load_time_data->SetString("type", "SAFEBROWSING");
load_time_data->SetString(
"tabTitle", l10n_util::GetStringUTF16(IDS_SAFEBROWSING_V3_TITLE));
......
components/security_interstitials/core/ssl_error_ui.cc
View file @ a532f9f7
......@@ -68,7 +68,6 @@ void SSLErrorUI::PopulateStringsForHTML(base::DictionaryValue* load_time_data) {
common_string_util::PopulateSSLLayoutStrings(cert_error_, load_time_data);
common_string_util::PopulateSSLDebuggingStrings(ssl_info_, time_triggered_,
load_time_data);
common_string_util::PopulateDarkModeDisplaySetting(load_time_data);
// Shared values for both the overridable and non-overridable versions.
load_time_data->SetBoolean("bad_clock", false);
......
testing/variations/fieldtrial_testing_config.json
View file @ a532f9f7
......@@ -6030,27 +6030,6 @@
]
}
],
"SecurityInterstitialsDarkMode": [
{
"platforms": [
"android",
"android_webview",
"chromeos",
"ios",
"linux",
"mac",
"windows"
],
"experiments": [
{
"name": "Enabled",
"enable_features": [
"SecurityInterstitialsDarkMode"
]
}
]
}
],
"ServiceGroupImportance": [
{
"platforms": [
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment