Commit a538aaa3 authored by Joe DeBlasio's avatar Joe DeBlasio Committed by Commit Bot

Safety Tips: Update default lookalike parameter values to enabled.

This CL swaps the default parameter values for lookalike heuristics in
Safety Tips to default to enabled. This mitigates an issue in metrics
recording where we were not identifying lookalike sites in the control
group, since their parameters were enabled.

This is not a user-visible change.

Bug: 1022016
Change-Id: Ie1373ce1543a2916de1a442ccc2371f485427cb7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1910844
Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: default avatarMustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#714600}
parent 9da03c10
...@@ -19,12 +19,12 @@ namespace { ...@@ -19,12 +19,12 @@ namespace {
using MatchType = LookalikeUrlInterstitialPage::MatchType; using MatchType = LookalikeUrlInterstitialPage::MatchType;
const base::FeatureParam<bool> kEnableLookalikeTopSites{ const base::FeatureParam<bool> kEnableLookalikeTopSites{
&security_state::features::kSafetyTipUI, "topsites", false}; &security_state::features::kSafetyTipUI, "topsites", true};
const base::FeatureParam<bool> kEnableLookalikeEditDistance{ const base::FeatureParam<bool> kEnableLookalikeEditDistance{
&security_state::features::kSafetyTipUI, "editdistance", false}; &security_state::features::kSafetyTipUI, "editdistance", true};
const base::FeatureParam<bool> kEnableLookalikeEditDistanceSiteEngagement{ const base::FeatureParam<bool> kEnableLookalikeEditDistanceSiteEngagement{
&security_state::features::kSafetyTipUI, "editdistance_siteengagement", &security_state::features::kSafetyTipUI, "editdistance_siteengagement",
false}; true};
} // namespace } // namespace
......
...@@ -167,7 +167,10 @@ class SafetyTipPageInfoBubbleViewBrowserTest ...@@ -167,7 +167,10 @@ class SafetyTipPageInfoBubbleViewBrowserTest
break; break;
case UIStatus::kEnabled: case UIStatus::kEnabled:
feature_list_.InitWithFeaturesAndParameters( feature_list_.InitWithFeaturesAndParameters(
{{security_state::features::kSafetyTipUI, {}}, {{security_state::features::kSafetyTipUI,
{{"topsites", "false"},
{"editdistance", "false"},
{"editdistance_siteengagement", "false"}}},
{features::kLookalikeUrlNavigationSuggestionsUI, {features::kLookalikeUrlNavigationSuggestionsUI,
{{"topsites", "true"}}}}, {{"topsites", "true"}}}},
{}); {});
...@@ -610,9 +613,11 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest, ...@@ -610,9 +613,11 @@ IN_PROC_BROWSER_TEST_P(SafetyTipPageInfoBubbleViewBrowserTest,
const GURL kLookalikeUrl = GetURL("googlé.sk"); const GURL kLookalikeUrl = GetURL("googlé.sk");
SetEngagementScore(browser(), kLookalikeUrl, kLowEngagement); SetEngagementScore(browser(), kLookalikeUrl, kLowEngagement);
NavigateToURL(browser(), kLookalikeUrl, WindowOpenDisposition::CURRENT_TAB); NavigateToURL(browser(), kLookalikeUrl, WindowOpenDisposition::CURRENT_TAB);
histograms.ExpectBucketCount(
kHistogramName, security_state::SafetyTipStatus::kLookalike, // Record metrics for lookalike domains unless explicitly disabled.
ui_status() == UIStatus::kEnabledWithAllFeatures ? 1 : 0); histograms.ExpectBucketCount(kHistogramName,
security_state::SafetyTipStatus::kLookalike,
ui_status() == UIStatus::kEnabled ? 0 : 1);
histograms.ExpectTotalCount(kHistogramName, 3); histograms.ExpectTotalCount(kHistogramName, 3);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment