Fix inconsistency and saving bug in price drop experiment
Two bugs were discovered 1) If a Tab navigates to a new URL, the ShoppingPersistedTabData should be invalidated. Otherwise we will return ShoppingPersistedTabData for the previous URL. To achieve this an observer on onUrlUpdated is added to delete the saved ShoppingPersistedTabData and disassociate the object with the Tab via UserDataHost. We should also do this on a tab close. 2) An observable supplier was not registered for ShoppingPersistedTabData. This pattern is used to control turning saving of the PersistedTabData object (in this case ShoppingPersistedTabData) on and off. Bug: 1159657 Change-Id: I5ac0d914cb1f03e0bdc9efc7914458dc16877d4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596435 Commit-Queue: David Maunder <davidjm@chromium.org> Reviewed-by:Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#838424}
Showing
Please register or sign in to comment