Commit a562a2c7 authored by edchin's avatar edchin Committed by Commit Bot

[ios] Add Flag Ownership for iOS flags with unknown expiry

iOS flag owners were asked to claim ownership and state an expiry in
this announcement email:
https://groups.google.com/a/google.com/g/bling-team/c/7YC_3l6yEzo/m/1-iZg1fPAAAJ

For these flags, ownership was claimed, but no expiration milestone was
given.

This CL attempts to act as a forcing function for owners to choose
an expiration milestone. This CL sets M85 as the default expiry milestone
for every flag in this CL. All owners have been responded with an LGTM
or with a comment to change the expiry.

Bug: 1058614
Change-Id: I40b40103f6a74aab185e8c7cebeceeb183476bac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094238Reviewed-by: default avatarKurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: default avatarElly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: default avatarJustin Cohen <justincohen@chromium.org>
Reviewed-by: default avatarMike Dougherty <michaeldo@chromium.org>
Reviewed-by: default avatarSergio Collazos <sczs@chromium.org>
Reviewed-by: default avataredchin <edchin@chromium.org>
Reviewed-by: default avatarGauthier Ambard <gambard@chromium.org>
Reviewed-by: default avatarChris Lu <thegreenfrog@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#748707}
parent e1bce6c3
......@@ -739,6 +739,11 @@
// encoding for debugging purpose and temporary workaround for some issues.
"expiry_milestone": -1
},
{
"name": "disable-animation-on-low-battery",
"owners": [ "djean" ],
"expiry_milestone": 85
},
{
"name": "disable-best-effort-tasks",
"owners": [ "catan-team@chromium.org" ],
......@@ -890,6 +895,12 @@
"owners": [ "bgeffon", "sonnyrao" ],
"expiry_milestone": 89
},
{
"name": "embedder-block-restore-url",
"owners": [ "justincohen", "rohitrao" ],
// Needed for manual testing of fallback flow on iOS.
"expiry_milestone": -1
},
{
"name": "enable-accessibility-expose-aria-annotations",
"owners": [ "aleventhal@chromium.org", "//third_party/blink/renderer/modules/accessibility/OWNERS", "//ui/accessibility/OWNERS" ],
......@@ -2340,6 +2351,17 @@
"owners": [ "yoavweiss", "aarontag" ],
"expiry_milestone": 85
},
{
"name": "fullscreen-controller-browser-scoped",
"owners": [ "thegreenfrog", "kkhorimoto" ],
"expiry_milestone": 85
},
{
"name": "fullscreen-viewport-adjustment-experiment",
"owners": [ "thegreenfrog", "kkhorimoto" ],
// Needed for manual testing of fallback flow on iOS.
"expiry_milestone": -1
},
{
"name": "fuzzy-app-search",
"owners": [ "thanhdng", "jiameng" ],
......@@ -2475,6 +2497,11 @@
// as well as by QA; this feature is difficult to test without this.
"expiry_milestone": -1
},
{
"name": "infobar-overlay-ui",
"owners": [ "kkhorimoto", "sczs" ],
"expiry_milestone": 85
},
{
"name": "infobar-ui-reboot",
"owners": [ "sczs", "thegreenfrog" ],
......@@ -2510,6 +2537,13 @@
"owners": [ "iwells", "//chrome/android/feed/OWNERS" ],
"expiry_milestone": 80
},
{
"name": "ios-breadcrumbs",
"owners": [ "michaeldo" ],
// Breadcrumbs is not a launching feature, but rather a tool used on
// pre-stable channels for diagnosing crashes.
"expiry_milestone": -1
},
{
"name": "isolate-origins",
"owners": [ "site-isolation-dev", "alexmos", "creis", "lukasza" ],
......@@ -2615,6 +2649,11 @@
"owners": [ "sczs", "thegreenfrog" ],
"expiry_milestone": 83
},
{
"name": "messages-download-infobar",
"owners": [ "sczs" ],
"expiry_milestone": 85
},
{
"name": "messages-save-card-infobar",
"owners": [ "sczs", "thegreenfrog" ],
......@@ -2690,6 +2729,11 @@
"owners": [ "//components/payments/OWNERS" ],
"expiry_milestone": 79
},
{
"name": "non-modal-dialogs",
"owners": [ "kkhorimoto" ],
"expiry_milestone": 85
},
{
"name": "notification-scheduler-debug-options",
"owners": [ "//chrome/browser/notifications/scheduler/OWNERS" ],
......@@ -3296,6 +3340,11 @@
// have no access to commandline flags.
"expiry_milestone": -1
},
{
"name": "settings-refresh",
"owners": [ "gambard" ],
"expiry_milestone": 85
},
{
"name": "share-button-in-top-toolbar",
"owners": ["jeffreycohen"],
......@@ -3477,6 +3526,11 @@
"owners": [ "goto", "fugu-dev" ],
"expiry_milestone": 85
},
{
"name": "snapshot-draw-view",
"owners": [ "//ios/chrome/browser/snapshots/OWNERS" ],
"expiry_milestone": 85
},
{
"name": "split-settings-sync",
"owners": [ "jamescook", "cros-system-services@google.com" ],
......@@ -3594,6 +3648,11 @@
"owners": [ "davidben", "svaldez" ],
"expiry_milestone": 85
},
{
"name": "toolbar-container",
"owners": [ "thegreenfrog", "kkhorimoto" ],
"expiry_milestone": 85
},
{
"name": "toolbar-new-tab-button",
"owners": [ "gambard" ],
......
......@@ -29,6 +29,7 @@
"disable-webrtc-hw-decoding",
"disable-webrtc-hw-encoding",
"disallow-doc-written-script-loads",
"embedder-block-restore-url",
"enable-autofill-credit-card-upload",
"enable-command-line-on-non-rooted-devices",
"enable-data-reduction-proxy-server-experiment",
......@@ -61,11 +62,13 @@
"force-text-direction",
"force-ui-direction",
"force-update-menu-type",
"fullscreen-viewport-adjustment-experiment",
"gesture-properties-dbus-service",
"ignore-gpu-blacklist",
"ignore-previews-blocklist",
"in-product-help-demo-mode-choice",
"instant-tethering",
"ios-breadcrumbs",
"list-all-display-modes",
"load-media-router-component-extension",
"media-router-cast-allow-all-ips",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment