Commit a5782299 authored by Hayato Ito's avatar Hayato Ito Committed by Commit Bot

Reland "[Sheriff] Disable BookmarkBarInvisibleOnShutdown on Linux"

This reverts commit 8f8c19f0.

Reason for revert: flakiness again
See https://bugs.chromium.org/p/chromium/issues/detail?id=1000251#c25

Original change's description:
> Revert "[Sheriff] Disable BookmarkBarInvisibleOnShutdown on Linux"
> 
> This reverts commit 2e452bbf.
> 
> Reason for revert: https://crbug.com/1000251 is fixed. 
> 
> Original change's description:
> > [Sheriff] Disable BookmarkBarInvisibleOnShutdown on Linux
> > 
> > TBR=weidongg@chromium.org
> > 
> > Bug: 1000251
> > Change-Id: I8e3372766ab9e560c9f47f7c2f8292ebc8af644c
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782637
> > Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#692666}
> 
> TBR=jdoerrie@chromium.org,weidongg@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 1000251
> Change-Id: Id9af5a221f5ca04873ce30737c2a9be58afd9fb3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1844854
> Reviewed-by: kylechar <kylechar@chromium.org>
> Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
> Commit-Queue: kylechar <kylechar@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#703303}

TBR=kylechar@chromium.org,jdoerrie@chromium.org,weidongg@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1000251
Change-Id: I5f798d35aee20756268151c510c27a7a5bcf5515
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1855245Reviewed-by: default avatarHayato Ito <hayato@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#704985}
parent 92f0dff9
......@@ -212,7 +212,14 @@ TEST_F(BrowserViewTest, DISABLED_RepeatedAccelerators) {
#endif // !defined(OS_MACOSX)
// Test that bookmark bar view becomes invisible when closing the browser.
TEST_F(BrowserViewTest, BookmarkBarInvisibleOnShutdown) {
// TODO(https://crbug.com/1000251): Flaky on Linux.
#if defined(OS_LINUX)
#define MAYBE_BookmarkBarInvisibleOnShutdown \
DISABLED_BookmarkBarInvisibleOnShutdown
#else
#define MAYBE_BookmarkBarInvisibleOnShutdown BookmarkBarInvisibleOnShutdown
#endif
TEST_F(BrowserViewTest, MAYBE_BookmarkBarInvisibleOnShutdown) {
BookmarkBarView::DisableAnimationsForTesting(true);
Browser* browser = browser_view()->browser();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment