[iOS][Password Check] Changed selection highlight style

This change adds default selection style to Password Check Details cell
on Passwords screen and to Change password button on Passwords details
screen.

Bug: 1113816
Change-Id: I7ae74f009e62c9700c4a85480ddf416102e71d70
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353260Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com>
Cr-Commit-Position: refs/heads/master@{#798485}

ios/chrome/browser/ui/settings/cells/settings_check_item.mm

@@ -29,7 +29,6 @@
   [super configureCell:cell withStyler:styler];
   cell.textLabel.text = self.text;
   cell.detailTextLabel.text = self.detailText;
-  cell.selectionStyle = UITableViewCellSelectionStyleNone;
   if (self.enabled) {
     [cell setInfoButtonHidden:self.infoButtonHidden];
     [cell setLeadingImage:self.leadingImage

ios/chrome/browser/ui/settings/password/password_details/password_details_table_view_controller.mm

@@ -266,8 +266,6 @@ typedef NS_ENUM(NSInteger, ReauthenticationReason) {
 
   cell.selectionStyle = UITableViewCellSelectionStyleNone;
 
-  // TODO:(crbug.com/1075494) - Add action to Show/Hide password when user tap
-  // eye icon.
   NSInteger itemType = [self.tableViewModel itemTypeForIndexPath:indexPath];
   switch (itemType) {
     case ItemTypePassword: {
@@ -280,9 +278,11 @@ typedef NS_ENUM(NSInteger, ReauthenticationReason) {
           forControlEvents:UIControlEventTouchUpInside];
       return textFieldCell;
     }
+    case ItemTypeChangePasswordButton:
+      cell.selectionStyle = UITableViewCellSelectionStyleDefault;
+      break;
     case ItemTypeWebsite:
     case ItemTypeUsername:
-    case ItemTypeChangePasswordButton:
     case ItemTypeChangePasswordRecommendation:
       break;
   }

ios/chrome/browser/ui/settings/password/passwords_table_view_controller.mm

@@ -1382,8 +1382,17 @@ std::vector<std::unique_ptr<autofill::PasswordForm>> CopyOf(
 
 - (BOOL)tableView:(UITableView*)tableView
     shouldHighlightRowAtIndexPath:(NSIndexPath*)indexPath {
-  return [self.tableViewModel sectionIdentifierForSection:indexPath.section] !=
-         SectionIdentifierSavePasswordsSwitch;
+  NSInteger itemType = [self.tableViewModel itemTypeForIndexPath:indexPath];
+  switch (itemType) {
+    case ItemTypeSavePasswordsSwitch:
+      return NO;
+    case ItemTypePasswordCheckStatus:
+      return self.passwordCheckState == PasswordCheckStateUnSafe;
+    case ItemTypeCheckForProblemsButton:
+      return self.passwordCheckState != PasswordCheckStateRunning &&
+             self.passwordCheckState != PasswordCheckStateDisabled;
+  }
+  return YES;
 }
 
 - (UIView*)tableView:(UITableView*)tableView