Commit a58ec46b authored by Richard Knoll's avatar Richard Knoll Committed by Commit Bot

Extend/Remove ClickToCall histograms

Extends the following useful metrics for this launched feature:
- Sharing.ClickToCallAppsToShow
- Sharing.ClickToCallDevicesToShow
- Sharing.ClickToCallDialerPresent
- Sharing.ClickToCallDialogShown
- Sharing.ClickToCallSelectedAppIndex
- Sharing.ClickToCallSelectedDeviceIndex

Removes collection of these metrics as the data is not used:
- Sharing.ClickToCallPhoneNumberPrecompileTime

Bug: 1125769
Change-Id: I28fdeff408c4326f13dddaacbf9266b82452761d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440838Reviewed-by: default avatarMichael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: default avatarIlya Sherman <isherman@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#813099}
parent 4f5cf7a0
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
#include "base/bind.h" #include "base/bind.h"
#include "base/feature_list.h" #include "base/feature_list.h"
#include "base/metrics/histogram_macros.h"
#include "base/task/post_task.h" #include "base/task/post_task.h"
#include "base/task/thread_pool.h" #include "base/task/thread_pool.h"
#include "base/time/time.h" #include "base/time/time.h"
...@@ -26,7 +25,6 @@ const char kPhoneNumberRegexPatternSimple[] = ...@@ -26,7 +25,6 @@ const char kPhoneNumberRegexPatternSimple[] =
R"((?:^|\p{Z})((?:\(?\+[0-9]+\)?)?(?:[.\p{Z}\-(]?[0-9][\p{Z}\-)]?){8,}))"; R"((?:^|\p{Z})((?:\(?\+[0-9]+\)?)?(?:[.\p{Z}\-(]?[0-9][\p{Z}\-)]?){8,}))";
void PrecompilePhoneNumberRegexes() { void PrecompilePhoneNumberRegexes() {
SCOPED_UMA_HISTOGRAM_TIMER("Sharing.ClickToCallPhoneNumberPrecompileTime");
static const char kExampleInput[] = "+01(2)34-5678 9012"; static const char kExampleInput[] = "+01(2)34-5678 9012";
std::string parsed; std::string parsed;
......
...@@ -86,13 +86,7 @@ class BaseClickToCallBrowserTest : public SharingBrowserTest { ...@@ -86,13 +86,7 @@ class BaseClickToCallBrowserTest : public SharingBrowserTest {
base::HistogramTester::CountsMap GetTotalHistogramCounts( base::HistogramTester::CountsMap GetTotalHistogramCounts(
const base::HistogramTester& histograms) { const base::HistogramTester& histograms) {
base::HistogramTester::CountsMap counts = return histograms.GetTotalCountsForPrefix(HistogramName(""));
histograms.GetTotalCountsForPrefix(HistogramName(""));
// PhoneNumberPrecompileTime will be logged 15 seconds after startup but
// we want to ignore it in these browser tests as we don't know if the
// test takes more or less time than that.
counts.erase(HistogramName("PhoneNumberPrecompileTime"));
return counts;
} }
}; };
......
...@@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -22,7 +22,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histograms> <histograms>
<histogram name="Sharing.ClickToCallAppsToShow" units="apps" <histogram name="Sharing.ClickToCallAppsToShow" units="apps"
expires_after="M88"> expires_after="M91">
<!-- Name completed by histogram_suffixes name="SharingClickToCallUi" --> <!-- Name completed by histogram_suffixes name="SharingClickToCallUi" -->
<owner>mvanouwerkerk@chromium.org</owner> <owner>mvanouwerkerk@chromium.org</owner>
...@@ -34,7 +34,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -34,7 +34,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="Sharing.ClickToCallDevicesToShow" units="devices" <histogram name="Sharing.ClickToCallDevicesToShow" units="devices"
expires_after="M88"> expires_after="M91">
<!-- Name completed by histogram_suffixes name="SharingClickToCallUi" --> <!-- Name completed by histogram_suffixes name="SharingClickToCallUi" -->
<owner>mvanouwerkerk@chromium.org</owner> <owner>mvanouwerkerk@chromium.org</owner>
...@@ -46,7 +46,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -46,7 +46,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="Sharing.ClickToCallDialerPresent" enum="BooleanPresent" <histogram name="Sharing.ClickToCallDialerPresent" enum="BooleanPresent"
expires_after="M87"> expires_after="M91">
<owner>mvanouwerkerk@chromium.org</owner> <owner>mvanouwerkerk@chromium.org</owner>
<owner>knollr@chromium.org</owner> <owner>knollr@chromium.org</owner>
<summary> <summary>
...@@ -57,7 +57,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -57,7 +57,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="Sharing.ClickToCallDialogShown" enum="SharingDialogType" <histogram name="Sharing.ClickToCallDialogShown" enum="SharingDialogType"
expires_after="M88"> expires_after="M91">
<owner>mvanouwerkerk@chromium.org</owner> <owner>mvanouwerkerk@chromium.org</owner>
<owner>knollr@chromium.org</owner> <owner>knollr@chromium.org</owner>
<summary> <summary>
...@@ -68,6 +68,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -68,6 +68,9 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
<histogram name="Sharing.ClickToCallPhoneNumberPrecompileTime" units="ms" <histogram name="Sharing.ClickToCallPhoneNumberPrecompileTime" units="ms"
expires_after="M87"> expires_after="M87">
<obsolete>
Removed in M87.
</obsolete>
<owner>knollr@chromium.org</owner> <owner>knollr@chromium.org</owner>
<owner>mvanouwerkerk@chromium.org</owner> <owner>mvanouwerkerk@chromium.org</owner>
<summary> <summary>
...@@ -77,7 +80,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -77,7 +80,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="Sharing.ClickToCallSelectedAppIndex" units="index" <histogram name="Sharing.ClickToCallSelectedAppIndex" units="index"
expires_after="M88"> expires_after="M91">
<!-- Name completed by histogram_suffixes name="SharingClickToCallUi" --> <!-- Name completed by histogram_suffixes name="SharingClickToCallUi" -->
<owner>mvanouwerkerk@chromium.org</owner> <owner>mvanouwerkerk@chromium.org</owner>
...@@ -89,7 +92,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit. ...@@ -89,7 +92,7 @@ reviews. Googlers can read more about this at go/gwsq-gerrit.
</histogram> </histogram>
<histogram name="Sharing.ClickToCallSelectedDeviceIndex" units="index" <histogram name="Sharing.ClickToCallSelectedDeviceIndex" units="index"
expires_after="M88"> expires_after="M91">
<!-- Name completed by histogram_suffixes name="SharingClickToCallUi" --> <!-- Name completed by histogram_suffixes name="SharingClickToCallUi" -->
<owner>mvanouwerkerk@chromium.org</owner> <owner>mvanouwerkerk@chromium.org</owner>
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment