Revert "Switch tabs on mouse down instead of mouse up."
This reverts commit a47974de. Reason for revert: https://crbug.com/819339 This breaks the flow of: 1. Click a tab. 2. Shift-click to select a range of tabs. 3. Release shift and drag the tabs out into a new window. …because the ListSelectionModel which backs the tab strip clears the selection when the active item is changed. It's going to take some work to make it behave the right way. Original change's description: > Switch tabs on mouse down instead of mouse up. > > This is consistent with other Mac apps and with Views, and makes the tab > strip feel more responsive. > > Bug: 799230 > Change-Id: I45a375f5892c10e5886e18f27ba049eb6215a17f > Reviewed-on: https://chromium-review.googlesource.com/895925 > Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> > Commit-Queue: Sidney San Martín <sdy@chromium.org> > Cr-Commit-Position: refs/heads/master@{#533373} TBR=ellyjones@chromium.org,sdy@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 819339, 799230 Change-Id: I9921e0d41669d6783ff0f8f3f0d4b0746eb72b68 Reviewed-on: https://chromium-review.googlesource.com/953304 Commit-Queue: Sidney San Martín <sdy@chromium.org> Reviewed-by:Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#541597}
Showing
Please register or sign in to comment