Commit a59dbcd6 authored by Scott Haseley's avatar Scott Haseley Committed by Commit Bot

Revert "[scheduler] Replace DCHECK for frozen and visible state with DumpWithoutCrashing"

This reverts commit fd47d8d8.

Reason for revert: Collected sufficient initial crash reports.

Original change's description:
> [scheduler] Replace DCHECK for frozen and visible state with DumpWithoutCrashing
> 
> Changing the DCHECK that checks for the page scheduler being frozen when
> the page is visible to DumpWithoutCrashing to collect more crash dump data.
> 
> Bug: 873214
> Change-Id: I0f10ef13b0cf790cb38189273adf1ddc03030fc2
> Reviewed-on: https://chromium-review.googlesource.com/1172709
> Commit-Queue: Scott Haseley <shaseley@google.com>
> Reviewed-by: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#582713}

TBR=altimin@chromium.org,shaseley@google.com

Change-Id: If15864678725a3939f5e0e03ddd4bcb97d220dcf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 873214
Reviewed-on: https://chromium-review.googlesource.com/1175011Reviewed-by: default avatarNate Chapin <japhet@chromium.org>
Commit-Queue: Scott Haseley <shaseley@google.com>
Cr-Commit-Position: refs/heads/master@{#582996}
parent eca797ab
...@@ -8,7 +8,6 @@ ...@@ -8,7 +8,6 @@
#include <set> #include <set>
#include <string> #include <string>
#include "base/debug/dump_without_crashing.h"
#include "base/metrics/field_trial_params.h" #include "base/metrics/field_trial_params.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
#include "base/trace_event/blame_context.h" #include "base/trace_event/blame_context.h"
...@@ -705,10 +704,6 @@ SchedulingLifecycleState FrameSchedulerImpl::CalculateLifecycleState( ...@@ -705,10 +704,6 @@ SchedulingLifecycleState FrameSchedulerImpl::CalculateLifecycleState(
if (parent_page_scheduler_->IsFrozen() && if (parent_page_scheduler_->IsFrozen() &&
!parent_page_scheduler_->KeepActive()) { !parent_page_scheduler_->KeepActive()) {
DCHECK(!parent_page_scheduler_->IsPageVisible()); DCHECK(!parent_page_scheduler_->IsPageVisible());
// TODO(crbug.com/873214): Remove this after collecting sufficient crash
// data.
if (parent_page_scheduler_->IsPageVisible())
base::debug::DumpWithoutCrashing();
return SchedulingLifecycleState::kStopped; return SchedulingLifecycleState::kStopped;
} }
if (subresource_loading_paused_ && type == ObserverType::kLoader) if (subresource_loading_paused_ && type == ObserverType::kLoader)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment