Commit a5a3e4d6 authored by Solomon Kinard's avatar Solomon Kinard Committed by Commit Bot

[Extensions] Quick comment change for method consistency.

InitValue changed to InitFromValue.

Bug: None
Change-Id: I96fb88b03de83f6252c313c1ef0447552b75c61c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506040
Commit-Queue: Solomon Kinard <solomonkinard@chromium.org>
Reviewed-by: default avatarIstiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823469}
parent 853001a6
...@@ -245,11 +245,11 @@ class Extension : public base::RefCountedThreadSafe<Extension> { ...@@ -245,11 +245,11 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
bool ShouldExposeViaManagementAPI() const; bool ShouldExposeViaManagementAPI() const;
// Get the manifest data associated with the key, or NULL if there is none. // Get the manifest data associated with the key, or NULL if there is none.
// Can only be called after InitValue is finished. // Can only be called after InitFromValue is finished.
ManifestData* GetManifestData(const std::string& key) const; ManifestData* GetManifestData(const std::string& key) const;
// Sets |data| to be associated with the key. // Sets |data| to be associated with the key.
// Can only be called before InitValue is finished. Not thread-safe; // Can only be called before InitFromValue is finished. Not thread-safe;
// all SetManifestData calls should be on only one thread. // all SetManifestData calls should be on only one thread.
void SetManifestData(const std::string& key, void SetManifestData(const std::string& key,
std::unique_ptr<ManifestData> data); std::unique_ptr<ManifestData> data);
...@@ -444,7 +444,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> { ...@@ -444,7 +444,7 @@ class Extension : public base::RefCountedThreadSafe<Extension> {
using ManifestDataMap = std::map<std::string, std::unique_ptr<ManifestData>>; using ManifestDataMap = std::map<std::string, std::unique_ptr<ManifestData>>;
ManifestDataMap manifest_data_; ManifestDataMap manifest_data_;
// Set to true at the end of InitValue when initialization is finished. // Set to true at the end of InitFromValue when initialization is finished.
bool finished_parsing_manifest_; bool finished_parsing_manifest_;
// Ensures that any call to GetManifestData() prior to finishing // Ensures that any call to GetManifestData() prior to finishing
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment