Commit a5adc873 authored by Marc Treib's avatar Marc Treib Committed by Commit Bot

Disable flaky SelectFileDialogImplGtkTest.Select*Folder

TBR=thomasanderson@chromium.org
NOTRY=true

Bug: 853079
Change-Id: I982e23595e1ca923c6ebbc09470b74e7b41ab20f
Reviewed-on: https://chromium-review.googlesource.com/1104171
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567968}
parent 788170a4
...@@ -91,19 +91,14 @@ class FilePicker : public ui::SelectFileDialog::Listener { ...@@ -91,19 +91,14 @@ class FilePicker : public ui::SelectFileDialog::Listener {
DISALLOW_COPY_AND_ASSIGN(FilePicker); DISALLOW_COPY_AND_ASSIGN(FilePicker);
}; };
// Note: The tests below were disabled for defined(ADDRESS_SANITIZER) with the
// following reasoning:
// Glib runs glib_init() when it is loaded by dl, and in the process // Glib runs glib_init() when it is loaded by dl, and in the process
// allocates some memory that is intentionally never freed. // allocates some memory that is intentionally never freed.
// Targeted suppression of the memory leak was not possible. // Targeted suppression of the memory leak was not possible.
#if defined(ADDRESS_SANITIZER)
#define MAYBE_SelectExistingFolder DISABLED_SelectExistingFolder // Flaky, see crbug.com/853079.
#define MAYBE_SelectUploadFolder DISABLED_SelectUploadFolder TEST_F(SelectFileDialogImplGtkTest, DISABLED_SelectExistingFolder) {
#define MAYBE_SelectFolder DISABLED_SelectFolder
#else
#define MAYBE_SelectExistingFolder SelectExistingFolder
#define MAYBE_SelectUploadFolder SelectUploadFolder
#define MAYBE_SelectFolder SelectFolder
#endif
TEST_F(SelectFileDialogImplGtkTest, MAYBE_SelectExistingFolder) {
content::TestBrowserThreadBundle test_browser_thread_bundle_; content::TestBrowserThreadBundle test_browser_thread_bundle_;
ScopedTestingLocalState local_state(TestingBrowserProcess::GetGlobal()); ScopedTestingLocalState local_state(TestingBrowserProcess::GetGlobal());
...@@ -117,7 +112,8 @@ TEST_F(SelectFileDialogImplGtkTest, MAYBE_SelectExistingFolder) { ...@@ -117,7 +112,8 @@ TEST_F(SelectFileDialogImplGtkTest, MAYBE_SelectExistingFolder) {
RunLoop().RunUntilIdle(); RunLoop().RunUntilIdle();
} }
TEST_F(SelectFileDialogImplGtkTest, MAYBE_SelectUploadFolder) { // Flaky, see crbug.com/853079.
TEST_F(SelectFileDialogImplGtkTest, DISABLED_SelectUploadFolder) {
content::TestBrowserThreadBundle test_browser_thread_bundle_; content::TestBrowserThreadBundle test_browser_thread_bundle_;
ScopedTestingLocalState local_state(TestingBrowserProcess::GetGlobal()); ScopedTestingLocalState local_state(TestingBrowserProcess::GetGlobal());
...@@ -131,7 +127,8 @@ TEST_F(SelectFileDialogImplGtkTest, MAYBE_SelectUploadFolder) { ...@@ -131,7 +127,8 @@ TEST_F(SelectFileDialogImplGtkTest, MAYBE_SelectUploadFolder) {
RunLoop().RunUntilIdle(); RunLoop().RunUntilIdle();
} }
TEST_F(SelectFileDialogImplGtkTest, MAYBE_SelectFolder) { // Flaky, see crbug.com/853079.
TEST_F(SelectFileDialogImplGtkTest, DISABLED_SelectFolder) {
content::TestBrowserThreadBundle test_browser_thread_bundle_; content::TestBrowserThreadBundle test_browser_thread_bundle_;
ScopedTestingLocalState local_state(TestingBrowserProcess::GetGlobal()); ScopedTestingLocalState local_state(TestingBrowserProcess::GetGlobal());
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment