Commit a5b2fc98 authored by vitalybuka's avatar vitalybuka Committed by Commit bot

Revert of Add Autofill to webview (patchset #5 id:160001 of...

Revert of Add Autofill to webview (patchset #5 id:160001 of https://codereview.chromium.org/866523002/)

Reason for revert:
BUG=456215

Original issue's description:
> Add Autofill to webview
>
> The change in the chrome_autofill_client.cc is needed to enable the autofill popup on
> Mac.
>
> BUG=447938
> TEST=Start Chrome. Navigate to chrome://chrome-signin. Enter a correct username
> with an incorrect password. After the password error appears, you should be able
> to autofill that username.
>
> Committed: https://crrev.com/4a1e13b16b5ef2cb6f7c800ad3c08f1f44bef285
> Cr-Commit-Position: refs/heads/master@{#314889}

TBR=estade@chromium.org,fsamuel@chromium.org,lazyboy@chromium.org,noms@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=447938

Review URL: https://codereview.chromium.org/887003007

Cr-Commit-Position: refs/heads/master@{#315122}
parent 8b6f2beb
......@@ -2,17 +2,14 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
#include "chrome/browser/guest_view/web_view/chrome_web_view_guest_delegate.h"
#include "chrome/browser/browser_process.h"
#include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
#include "chrome/browser/favicon/favicon_tab_helper.h"
#include "chrome/browser/password_manager/chrome_password_manager_client.h"
#include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
#include "chrome/browser/ui/autofill/chrome_autofill_client.h"
#include "chrome/browser/ui/pdf/chrome_pdf_web_contents_helper_client.h"
#include "chrome/common/chrome_version_info.h"
#include "components/autofill/content/browser/content_autofill_driver_factory.h"
#include "components/pdf/browser/pdf_web_contents_helper.h"
#include "components/renderer_context_menu/context_menu_delegate.h"
#include "extensions/browser/api/web_request/web_request_api.h"
......@@ -78,17 +75,6 @@ void ChromeWebViewGuestDelegate::OnAttachWebViewHelpers(
contents,
scoped_ptr<pdf::PDFWebContentsHelperClient>(
new ChromePDFWebContentsHelperClient()));
autofill::ChromeAutofillClient::CreateForWebContents(contents);
ChromePasswordManagerClient::CreateForWebContentsWithAutofillClient(
contents,
autofill::ChromeAutofillClient::FromWebContents(contents));
autofill::ContentAutofillDriverFactory::CreateForWebContentsAndDelegate(
contents,
autofill::ChromeAutofillClient::FromWebContents(contents),
g_browser_process->GetApplicationLocale(),
autofill::AutofillManager::ENABLE_AUTOFILL_DOWNLOAD_MANAGER);
}
void ChromeWebViewGuestDelegate::OnDidCommitProvisionalLoadForFrame(
......
......@@ -84,3 +84,4 @@ class ChromeWebViewGuestDelegate : public WebViewGuestDelegate {
} // namespace extensions
#endif // CHROME_BROWSER_GUEST_VIEW_WEB_VIEW_CHROME_WEB_VIEW_GUEST_DELEGATE_H_
......@@ -186,13 +186,13 @@ void ChromeAutofillClient::ShowAutofillPopup(
element_bounds + client_area.OffsetFromOrigin();
// Will delete or reuse the old |popup_controller_|.
popup_controller_ = AutofillPopupControllerImpl::GetOrCreate(
popup_controller_,
delegate,
web_contents(),
web_contents()->GetContentNativeView(),
element_bounds_in_screen_space,
text_direction);
popup_controller_ =
AutofillPopupControllerImpl::GetOrCreate(popup_controller_,
delegate,
web_contents(),
web_contents()->GetNativeView(),
element_bounds_in_screen_space,
text_direction);
popup_controller_->Show(suggestions);
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment