Commit a5c05b07 authored by Egor Pasko's avatar Egor Pasko Committed by Commit Bot

PRESUBMIT: Skip checking Log for customtabs_benchmark

The CCT benchmark is a small app with minimal dependencies and no
proguard. If it includes Chromium java pieces, it would not fit into the
method count limits, so it would need to enable proguard. This is overly
heavy for the purposes of this app. So we would like to use
android.util.Log in this app instead.

Bug: None
Change-Id: Ia44c6d60a97721bce827061e022d4c5cb8c2fa81
Reviewed-on: https://chromium-review.googlesource.com/1251624Reviewed-by: default avataragrieve <agrieve@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#595106}
parent 5b55328c
...@@ -2252,6 +2252,9 @@ def _CheckAndroidCrLogUsage(input_api, output_api): ...@@ -2252,6 +2252,9 @@ def _CheckAndroidCrLogUsage(input_api, output_api):
# WebView license viewer code cannot depend on //base; used in stub APK. # WebView license viewer code cannot depend on //base; used in stub APK.
r"^android_webview[\\\/]glue[\\\/]java[\\\/]src[\\\/]com[\\\/]android[\\\/]" r"^android_webview[\\\/]glue[\\\/]java[\\\/]src[\\\/]com[\\\/]android[\\\/]"
r"webview[\\\/]chromium[\\\/]License.*", r"webview[\\\/]chromium[\\\/]License.*",
# The customtabs_benchmark is a small app that does not depend on Chromium
# java pieces.
r"tools[\\\/]android[\\\/]customtabs_benchmark[\\\/].*",
] ]
cr_log_import_pattern = input_api.re.compile( cr_log_import_pattern = input_api.re.compile(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment