Disable viz-dependent features on WebView

This adds a flag to disable:
- window.OffscreenCanvas
- Context2DCreation.desynchronize.
- HTMLCanvasElement.transferControlToOffscreen

Bug: 940953
Change-Id: If774e41adbaa6bef94a058f783225b27e5d0669a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736804Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Fernando Serboncini <fserb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#685170}

android_webview/browser/aw_settings.cc

@@ -42,6 +42,7 @@ void PopulateFixedWebPreferences(WebPreferences* web_prefs) {
   web_prefs->should_clear_document_background = false;
   web_prefs->viewport_meta_enabled = true;
   web_prefs->picture_in_picture_enabled = false;
+  web_prefs->disable_features_depending_on_viz = true;
 }
 
 const void* const kAwSettingsUserDataKey = &kAwSettingsUserDataKey;

content/public/common/common_param_traits_macros.h

@@ -239,6 +239,7 @@ IPC_STRUCT_TRAITS_BEGIN(content::WebPreferences)
   IPC_STRUCT_TRAITS_MEMBER(immersive_mode_enabled)
   IPC_STRUCT_TRAITS_MEMBER(css_hex_alpha_color_enabled)
   IPC_STRUCT_TRAITS_MEMBER(scroll_top_left_interop_enabled)
+  IPC_STRUCT_TRAITS_MEMBER(disable_features_depending_on_viz)
 #endif  // defined(OS_ANDROID)
   IPC_STRUCT_TRAITS_MEMBER(force_dark_mode_enabled)
   IPC_STRUCT_TRAITS_MEMBER(default_minimum_page_scale_factor)

content/public/common/web_preferences.cc

@@ -209,6 +209,7 @@ WebPreferences::WebPreferences()
       embedded_media_experience_enabled(false),
       css_hex_alpha_color_enabled(true),
       scroll_top_left_interop_enabled(true),
+      disable_features_depending_on_viz(false),
 #endif  // defined(OS_ANDROID)
 #if defined(OS_ANDROID)
       default_minimum_page_scale_factor(0.25f),

content/public/common/web_preferences.h

@@ -280,6 +280,10 @@ struct CONTENT_EXPORT WebPreferences {
   // WebView sets this to false to retain old documentElement behaviour
   // (http://crbug.com/761016).
   bool scroll_top_left_interop_enabled;
+  // Disable features such as offscreen canvas that depend on the viz
+  // architecture of surface embedding. Android WebView does not support this
+  // architecture yet.
+  bool disable_features_depending_on_viz;
 #endif  // defined(OS_ANDROID)
 
   // Enable forcibly modifying content rendering to result in a light on dark

content/renderer/render_view_impl.cc

@@ -879,6 +879,8 @@ void RenderView::ApplyWebPreferences(const WebPreferences& prefs,
   WebRuntimeFeatures::EnableCSSHexAlphaColor(prefs.css_hex_alpha_color_enabled);
   WebRuntimeFeatures::EnableScrollTopLeftInterop(
       prefs.scroll_top_left_interop_enabled);
+  WebRuntimeFeatures::EnableSurfaceEmbeddingFeatures(
+      !prefs.disable_features_depending_on_viz);
 #endif  // defined(OS_ANDROID)
 
   settings->SetForceDarkModeEnabled(prefs.force_dark_mode_enabled);

third_party/blink/public/platform/web_runtime_features.h

@@ -245,6 +245,8 @@ class WebRuntimeFeatures {
   BLINK_PLATFORM_EXPORT static void EnableMouseSubframeNoImplicitCapture(bool);
   BLINK_PLATFORM_EXPORT static void EnableBackForwardCache(bool);
 
+  BLINK_PLATFORM_EXPORT static void EnableSurfaceEmbeddingFeatures(bool);
+
  private:
   WebRuntimeFeatures();
 };

third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.idl

@@ -8,7 +8,8 @@
     Constructor([EnforceRange] unsigned long width, [EnforceRange] unsigned long height),
     Exposed=(Window,Worker),
     Transferable,
-    MeasureAs=OffscreenCanvas
+    MeasureAs=OffscreenCanvas,
+    RuntimeEnabled=SurfaceEmbeddingFeatures
 ] interface OffscreenCanvas : EventTarget {
     attribute [EnforceRange] unsigned long width;
     attribute [EnforceRange] unsigned long height;

third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d_settings.idl

@@ -9,6 +9,6 @@ dictionary CanvasRenderingContext2DSettings {
     boolean alpha = true;
     [RuntimeEnabled=CanvasColorManagement] CanvasColorSpace colorSpace = "srgb";
     [RuntimeEnabled=CanvasColorManagement] CanvasPixelFormat pixelFormat = "uint8";
-    boolean desynchronized = false;
+    [RuntimeEnabled=SurfaceEmbeddingFeatures] boolean desynchronized = false;
 };
 

third_party/blink/renderer/modules/canvas/htmlcanvas/canvas_context_creation_attributes_module.idl

@@ -40,7 +40,7 @@ dictionary CanvasContextCreationAttributesModule {
     // the bindings because origin trial bindings don't work in extensions.
     // The trial's runtime flag is instead checked inside
     // HTMLCanvasElement.getContext().
-    boolean desynchronized = false;
+    [RuntimeEnabled=SurfaceEmbeddingFeatures] boolean desynchronized = false;
 
     // Canvas 2D attributes
     boolean alpha = true;  // Also used for WebGL.

third_party/blink/renderer/modules/canvas/htmlcanvas/html_canvas_element_module.idl

@@ -4,6 +4,9 @@
 
 // https://html.spec.whatwg.org/C/#the-canvas-element
 
+// This file is currently forked between html_canvas_element_module.idl and
+// html_canvas_element_module_support_webgl2_compute.idl. Update both files.
+
 typedef (CanvasRenderingContext2D or
          WebGLRenderingContext or
          WebGL2RenderingContext or
@@ -20,5 +23,7 @@ typedef (CanvasRenderingContext2D or
     // (and is not undefined or null). The binding must ignore this.
     // Related spec issue: https://github.com/whatwg/html/issues/595
     [RaisesException] RenderingContext? getContext(DOMString contextId, [PermissiveDictionaryConversion] optional CanvasContextCreationAttributesModule attributes);
-    [RaisesException, MeasureAs=OffscreenCanvas] OffscreenCanvas transferControlToOffscreen();
+
+    [RuntimeEnabled=SurfaceEmbeddingFeatures,
+     RaisesException, MeasureAs=OffscreenCanvas] OffscreenCanvas transferControlToOffscreen();
 };

third_party/blink/renderer/modules/canvas/htmlcanvas/html_canvas_element_module_support_webgl2_compute.idl

@@ -4,6 +4,9 @@
 
 // https://html.spec.whatwg.org/C/#the-canvas-element
 
+// This file is currently forked between html_canvas_element_module.idl and
+// html_canvas_element_module_support_webgl2_compute.idl. Update both files.
+
 typedef (CanvasRenderingContext2D or
          WebGLRenderingContext or
          WebGL2RenderingContext or
@@ -21,5 +24,5 @@ typedef (CanvasRenderingContext2D or
     // (and is not undefined or null). The binding must ignore this.
     // Related spec issue: https://github.com/whatwg/html/issues/595
     [RaisesException] RenderingContext? getContext(DOMString contextId, [PermissiveDictionaryConversion] optional CanvasContextCreationAttributesModule attributes);
-    [RaisesException, MeasureAs=OffscreenCanvas] OffscreenCanvas transferControlToOffscreen();
+    [RaisesException, MeasureAs=OffscreenCanvas, RuntimeEnabled=SurfaceEmbeddingFeatures] OffscreenCanvas transferControlToOffscreen();
 };

third_party/blink/renderer/modules/canvas/offscreencanvas2d/offscreen_canvas_rendering_context_2d.idl

@@ -5,7 +5,8 @@
 // https://html.spec.whatwg.org/C/#the-offscreen-2d-rendering-context
 
 [
-    Exposed=(Window,Worker)
+    Exposed=(Window,Worker),
+    RuntimeEnabled=SurfaceEmbeddingFeatures
 ] interface OffscreenCanvasRenderingContext2D {
     // back-reference to the canvas
     [ImplementedAs=offscreenCanvasForBinding] readonly attribute OffscreenCanvas canvas;

third_party/blink/renderer/modules/webgl/webgl_context_attributes.idl

@@ -42,5 +42,5 @@ dictionary WebGLContextAttributes {
     WebGLPowerPreference powerPreference = "default";
     boolean failIfMajorPerformanceCaveat = false;
     [RuntimeEnabled=WebXR] boolean xrCompatible = false;
-    boolean desynchronized = false;
+    [RuntimeEnabled=SurfaceEmbeddingFeatures] boolean desynchronized = false;
 };

third_party/blink/renderer/platform/exported/web_runtime_features.cc

@@ -695,4 +695,8 @@ void WebRuntimeFeatures::EnableBackForwardCache(bool enable) {
   RuntimeEnabledFeatures::SetBackForwardCacheEnabled(enable);
 }
 
+void WebRuntimeFeatures::EnableSurfaceEmbeddingFeatures(bool enable) {
+  RuntimeEnabledFeatures::SetSurfaceEmbeddingFeaturesEnabled(enable);
+}
+
 }  // namespace blink

third_party/blink/renderer/platform/runtime_enabled_features.json5

@@ -1542,6 +1542,10 @@
       name: "StreamsNative",
       status: "test",
     },
+    {
+      name: "SurfaceEmbeddingFeatures",
+      status: "stable",
+    },
     {
       name: "TextFragmentIdentifiers",
       origin_trial_feature_name: "TextFragmentIdentifiers",