Commit a5f8a8a4 authored by James Cook's avatar James Cook Committed by Commit Bot

lacros: Mark SelectFile mojoms as [Stable]

We've decided to require backwards compatibility for lacros interfaces
starting now.

This requires marking mojo_base.mojom.FilePath as [Stable] as well.

Bug: 1110184
Change-Id: Ia931fe5fa7b46af1199047945d6fb273d9d82e15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363450Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
Reviewed-by: default avatarGreg Kerr <kerrnel@chromium.org>
Reviewed-by: default avatarKen Rockot <rockot@google.com>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#799960}
parent 4bbc6d00
......@@ -11,7 +11,7 @@ import "url/mojom/url.mojom";
// The type of dialog to open. The integer values intentionally do not match
// ui::SelectFileDialog::Type because there is no "none" value and kOpenFile
// is the common case.
[Extensible]
[Stable, Extensible]
enum SelectFileDialogType {
// For opening a file.
kOpenFile = 0,
......@@ -33,7 +33,7 @@ enum SelectFileDialogType {
};
// Specifies which type of paths the caller can handle.
[Extensible]
[Stable, Extensible]
enum AllowedPaths {
// Any type of path, whether local/native or remote/virtual.
kAnyPath,
......@@ -49,6 +49,7 @@ enum AllowedPaths {
};
// Information about the types of files used by the dialog.
[Stable]
struct SelectFileTypeInfo {
// The list of allowed file extensions. For example:
// { { "htm", "html" }, { "txt" } }
......@@ -78,6 +79,7 @@ struct SelectFileTypeInfo {
};
// Options for the select file dialog.
[Stable]
struct SelectFileOptions {
// Dialog type.
SelectFileDialogType type;
......@@ -97,7 +99,7 @@ struct SelectFileOptions {
};
// Result of the select file dialog.
[Extensible]
[Stable, Extensible]
enum SelectFileResult {
// Everything worked.
kSuccess = 0,
......@@ -107,6 +109,7 @@ enum SelectFileResult {
};
// Information about the selected file or files.
[Stable]
struct SelectedFileInfo {
// Path to the file, as seen in the UI.
mojo_base.mojom.FilePath file_path;
......@@ -132,6 +135,7 @@ struct SelectedFileInfo {
// Select file dialog interface. Wrapper around the C++ SelectFileDialog
// class. Called from lacros-chrome. Implemented in ash-chrome using the
// file manager dialog.
[Stable]
interface SelectFile {
// Selects one or more files. If the dialog is closed or canceled without
// selecting a file, or if there is an error, |files| will be empty.
......
......@@ -4,6 +4,7 @@
module mojo_base.mojom;
[Stable]
struct FilePath {
[EnableIf=file_path_is_string]
string path;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment