Add new DialogType enum LOCATION_SUGGESTION and handle that case

Bug: 1118207
Change-Id: Ia6930c99bf0dac607450ddf97ee57cd3e09b9c44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391507Reviewed-by: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Commit-Queue: Hung Vu <vuhung@google.com>
Cr-Commit-Position: refs/heads/master@{#804502}

chrome/browser/download/android/java/src/org/chromium/chrome/browser/download/dialogs/DownloadLocationCustomView.java

@@ -102,6 +102,12 @@ public class DownloadLocationCustomView
             case DownloadLocationDialogType.NAME_TOO_LONG:
                 mSubtitleView.setText(R.string.download_location_name_too_long);
                 break;
+
+            case DownloadLocationDialogType.LOCATION_SUGGESTION:
+                // TODO(vuhung): Add download and storage info to subtitle.
+                // Right now this subtitle is just a placeholder.
+                mSubtitleView.setText(DownloadUtils.getStringForBytes(getContext(), totalBytes));
+                break;
         }
 
         mDirectoryAdapter.update();

chrome/browser/download/android/java/src/org/chromium/chrome/browser/download/dialogs/DownloadLocationDialogCoordinator.java

@@ -170,6 +170,7 @@ public class DownloadLocationDialogCoordinator implements ModalDialogProperties.
             case DownloadLocationDialogType.NAME_TOO_LONG:
                 return mContext.getString(R.string.download_location_rename_file);
 
+            case DownloadLocationDialogType.LOCATION_SUGGESTION: // Intentional fall through.
             case DownloadLocationDialogType.DEFAULT:
                 return mContext.getString(R.string.download_location_dialog_title);
         }

chrome/browser/download/chrome_download_manager_delegate.cc

@@ -972,6 +972,14 @@ void ChromeDownloadManagerDelegate::RequestConfirmation(
       // Figure out type of dialog and display.
       DownloadLocationDialogType dialog_type =
           DownloadLocationDialogType::DEFAULT;
+
+      // Suggests an alternative location.
+      // TODO(vuhung): Conditions checking will be added in next CL.
+      if (base::FeatureList::IsEnabled(
+              download::features::kSmartSuggestionForLargeDownloads)) {
+        dialog_type = DownloadLocationDialogType::LOCATION_SUGGESTION;
+      }
+
       switch (reason) {
         case DownloadConfirmationReason::TARGET_NO_SPACE:
           dialog_type = DownloadLocationDialogType::LOCATION_FULL;

chrome/browser/download/download_dialog_types.h

@@ -17,7 +17,8 @@ enum class DownloadLocationDialogType {
   LOCATION_NOT_FOUND = 3,  // Error dialog, default location is not found.
   NAME_CONFLICT = 4,  // Error dialog, there is already a file with that name.
   NAME_TOO_LONG = 5,  // Error dialog, the file name is too long.
-  kMaxValue = NAME_TOO_LONG
+  LOCATION_SUGGESTION = 6,  // Dialog showing alternative location suggestion.
+  kMaxValue = LOCATION_SUGGESTION
 };
 
 // Result of download location dialog.

tools/metrics/histograms/enums.xml

@@ -18669,6 +18669,7 @@ Called by update_document_policy_enum.py.-->
   <int value="3" label="LOCATION_NOT_FOUND"/>
   <int value="4" label="NAME_CONFLICT"/>
   <int value="5" label="NAME_TOO_LONG"/>
+  <int value="6" label="LOCATION_SUGGESTION"/>
 </enum>
 
 <enum name="DownloadLocationDirectoryType">