Commit a6099c9b authored by Timothy Loh's avatar Timothy Loh Committed by Commit Bot

Disable flaky SitePerProcess[HighDPI]HitTestBrowserTest tests

Disables:
- ScrollEventToOOPIF on TSAN
- OverlapSurfaceHitTestTest on Linux (was: TSAN)
- HitTestWatermark on Linux (was: TSAN)
- HitTestLayerSquashing on Linux
- CrossProcessMouseCapture on Linux

TBR=kenrb@chromium.org

Bug: 833380
Change-Id: Ia8539488479c19e0dbeacf6bc0c16667f325ebd9
Reviewed-on: https://chromium-review.googlesource.com/1056775Reviewed-by: default avatarTimothy Loh <timloh@chromium.org>
Commit-Queue: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#558187}
parent c948f0f2
...@@ -1215,7 +1215,15 @@ IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest, ...@@ -1215,7 +1215,15 @@ IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest,
// results in a scroll. This is only handled by RenderWidgetHostViewAura // results in a scroll. This is only handled by RenderWidgetHostViewAura
// and is needed for trackpad scrolling on Chromebooks. // and is needed for trackpad scrolling on Chromebooks.
#if defined(USE_AURA) #if defined(USE_AURA)
IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest, ScrollEventToOOPIF) {
#if defined(THREAD_SANITIZER)
// Flaky: https://crbug.com/833380
#define MAYBE_ScrollEventToOOPIF DISABLED_ScrollEventToOOPIF
#else
#define MAYBE_ScrollEventToOOPIF ScrollEventToOOPIF
#endif
IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest,
MAYBE_ScrollEventToOOPIF) {
GURL main_url(embedded_test_server()->GetURL( GURL main_url(embedded_test_server()->GetURL(
"/frame_tree/page_with_positioned_frame.html")); "/frame_tree/page_with_positioned_frame.html"));
EXPECT_TRUE(NavigateToURL(shell(), main_url)); EXPECT_TRUE(NavigateToURL(shell(), main_url));
...@@ -1404,8 +1412,8 @@ IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest, ...@@ -1404,8 +1412,8 @@ IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest,
OverlapSurfaceHitTestHelper(shell(), embedded_test_server()); OverlapSurfaceHitTestHelper(shell(), embedded_test_server());
} }
#if defined(THREAD_SANITIZER) #if defined(OS_LINUX)
// Flaky: https://crbug.com/833380 // Flaky timeouts and failures: https://crbug.com/833380
#define MAYBE_OverlapSurfaceHitTestTest DISABLED_OverlapSurfaceHitTestTest #define MAYBE_OverlapSurfaceHitTestTest DISABLED_OverlapSurfaceHitTestTest
#else #else
#define MAYBE_OverlapSurfaceHitTestTest OverlapSurfaceHitTestTest #define MAYBE_OverlapSurfaceHitTestTest OverlapSurfaceHitTestTest
...@@ -1415,26 +1423,33 @@ IN_PROC_BROWSER_TEST_P(SitePerProcessHighDPIHitTestBrowserTest, ...@@ -1415,26 +1423,33 @@ IN_PROC_BROWSER_TEST_P(SitePerProcessHighDPIHitTestBrowserTest,
OverlapSurfaceHitTestHelper(shell(), embedded_test_server()); OverlapSurfaceHitTestHelper(shell(), embedded_test_server());
} }
#if defined(OS_LINUX)
// Flaky timeouts and failures: https://crbug.com/833380
#define MAYBE_HitTestLayerSquashing DISABLED_HitTestLayerSquashing
#else
#define MAYBE_HitTestLayerSquashing HitTestLayerSquashing
#endif
IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest, IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest,
HitTestLayerSquashing) { MAYBE_HitTestLayerSquashing) {
HitTestLayerSquashing(shell(), embedded_test_server()); HitTestLayerSquashing(shell(), embedded_test_server());
} }
IN_PROC_BROWSER_TEST_P(SitePerProcessHighDPIHitTestBrowserTest, IN_PROC_BROWSER_TEST_P(SitePerProcessHighDPIHitTestBrowserTest,
HitTestLayerSquashing) { MAYBE_HitTestLayerSquashing) {
HitTestLayerSquashing(shell(), embedded_test_server()); HitTestLayerSquashing(shell(), embedded_test_server());
} }
IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest, HitTestWatermark) { #if defined(OS_LINUX)
HitTestWatermark(shell(), embedded_test_server()); // Flaky timeouts and failures: https://crbug.com/833380
}
#if defined(THREAD_SANITIZER)
// Flaky: https://crbug.com/833380
#define MAYBE_HitTestWatermark DISABLED_HitTestWatermark #define MAYBE_HitTestWatermark DISABLED_HitTestWatermark
#else #else
#define MAYBE_HitTestWatermark HitTestWatermark #define MAYBE_HitTestWatermark HitTestWatermark
#endif #endif
IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest,
MAYBE_HitTestWatermark) {
HitTestWatermark(shell(), embedded_test_server());
}
IN_PROC_BROWSER_TEST_P(SitePerProcessHighDPIHitTestBrowserTest, IN_PROC_BROWSER_TEST_P(SitePerProcessHighDPIHitTestBrowserTest,
MAYBE_HitTestWatermark) { MAYBE_HitTestWatermark) {
HitTestWatermark(shell(), embedded_test_server()); HitTestWatermark(shell(), embedded_test_server());
...@@ -1876,11 +1891,17 @@ IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest, ...@@ -1876,11 +1891,17 @@ IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest,
EXPECT_TRUE(d_frame_monitor.EventWasReceived()); EXPECT_TRUE(d_frame_monitor.EventWasReceived());
} }
#if defined(OS_LINUX)
// Flaky timeouts and failures: https://crbug.com/833380
#define MAYBE_CrossProcessMouseCapture DISABLED_CrossProcessMouseCapture
#else
#define MAYBE_CrossProcessMouseCapture CrossProcessMouseCapture
#endif
// Verify that mouse capture works on a RenderWidgetHostView level, so that // Verify that mouse capture works on a RenderWidgetHostView level, so that
// dragging scroll bars and selecting text continues even when the mouse // dragging scroll bars and selecting text continues even when the mouse
// cursor crosses over cross-process frame boundaries. // cursor crosses over cross-process frame boundaries.
IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest, IN_PROC_BROWSER_TEST_P(SitePerProcessHitTestBrowserTest,
CrossProcessMouseCapture) { MAYBE_CrossProcessMouseCapture) {
GURL main_url(embedded_test_server()->GetURL( GURL main_url(embedded_test_server()->GetURL(
"/frame_tree/page_with_positioned_frame.html")); "/frame_tree/page_with_positioned_frame.html"));
EXPECT_TRUE(NavigateToURL(shell(), main_url)); EXPECT_TRUE(NavigateToURL(shell(), main_url));
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment