Archive chromedriver symbols windows, fix PRESUBMIT.

Also upload chromedriver symbols to symbol server.

Also add PRESUBMIT for FILES.cfg to prevent syntax errors like I made
last time.

Also fix the overall chromium PRESUBMIT to not try to run a PRESUBMIT_test.py
that doesn't exist. (This was regressed by
https://chromium-review.googlesource.com/c/chromium/src/+/966906
and then partially fixed by
https://chromium-review.googlesource.com/c/chromium/src/+/1015976 )
It was hitting this line:
https://cs.chromium.org/chromium/tools/depot_tools/presubmit_canned_checks.py?q=%22files,+found+none+that+matched%22&sq=package:chromium&dr=C&l=511
"Out of %d files, found none that matched w=%r, b=%r in directory %s"

Bug: 835950
Change-Id: I365204bb87e6f642c12ee03a646b28d28cc4abab
Reviewed-on: https://chromium-review.googlesource.com/1054967Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Michael Moss <mmoss@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Caleb Rouleau <crouleau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#557995}

PRESUBMIT.py

@@ -2851,7 +2851,8 @@ def _CommonChecks(input_api, output_api):
     path, name = input_api.os_path.split(f.LocalPath())
     if name == 'PRESUBMIT.py':
       full_path = input_api.os_path.join(input_api.PresubmitLocalPath(), path)
-      if f.Action() != 'D':
+      test_file = input_api.os_path.join(path, 'PRESUBMIT_test.py')
+      if f.Action() != 'D' and input_api.os_path.exists(test_file):
         # The PRESUBMIT.py file (and the directory containing it) might
         # have been affected by being moved or removed, so only try to
         # run the tests if they still exist.

chrome/tools/build/PRESUBMIT.py

+# Copyright (c) 2011 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Presubmit script for FILES.cfg controlling which files are archived.
+
+See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts
+for more details about the presubmit API built into depot_tools.
+"""
+
+_PLATFORMS = ['android', 'chromeos', 'linux', 'mac', 'win']
+
+def _CheckChange(input_api, output_api):
+  results = []
+  affected_files = input_api.change.LocalPaths()
+
+  for platform in _PLATFORMS:
+    files_config_path = input_api.os_path.join(platform, 'FILES.cfg')
+    for filepath in affected_files:
+      if filepath.endswith(files_config_path):
+        output, error = input_api.subprocess.Popen(
+            ['python', files_config_path],
+            stdout=input_api.subprocess.PIPE,
+            stderr=input_api.subprocess.PIPE).communicate()
+        if output or error:
+          results.append(output_api.PresubmitError(
+              files_config_path + " syntax error: \n" + output + error))
+  return results
+
+def CheckChangeOnUpload(input_api, output_api):
+  results = []
+  results.extend(_CheckChange(input_api, output_api))
+  return results
+
+def CheckChangeOnCommit(input_api, output_api):
+  results = []
+  results.extend(_CheckChange(input_api, output_api))
+  return results

chrome/tools/build/win/FILES.cfg

@@ -807,5 +807,12 @@ FILES = [
     'buildtype': ['official'],
     'archive': 'chromedriver_win32.zip',
     'optional': ['official'],
+    'filegroup': ['symsrc'],
+  },
+  {
+    'filename': 'chromedriver.exe.pdb',
+    'buildtype': ['official'],
+    'archive': 'chromedriver_win32-syms.zip',
+    'optional': ['official'],
   },
 ]