[iOS] IPH for Discover feed header menu button

Adds IPH for top-level menu button of the Discover feed header in the
NTP. Here is clip for the IPH appearing: http://shortn/_TejkyqTmah

Bug: 1085419
Change-Id: I7a713d1e8cdb66fda3902ceb1f5db843bf414f0f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354904
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#800161}

components/feature_engagement/public/feature_constants.cc

@@ -122,6 +122,8 @@ const base::Feature kIPHBadgedReadingListFeature{
     "IPH_BadgedReadingList", base::FEATURE_DISABLED_BY_DEFAULT};
 const base::Feature kIPHBadgedTranslateManualTriggerFeature{
     "IPH_BadgedTranslateManualTrigger", base::FEATURE_DISABLED_BY_DEFAULT};
+const base::Feature kIPHDiscoverFeedHeaderFeature{
+    "IPH_DiscoverFeedHeaderMenu", base::FEATURE_DISABLED_BY_DEFAULT};
 #endif  // defined(OS_IOS)
 
 }  // namespace feature_engagement

components/feature_engagement/public/feature_constants.h

@@ -81,6 +81,7 @@ extern const base::Feature kIPHNewTabTipFeature;
 extern const base::Feature kIPHNewIncognitoTabTipFeature;
 extern const base::Feature kIPHBadgedReadingListFeature;
 extern const base::Feature kIPHBadgedTranslateManualTriggerFeature;
+extern const base::Feature kIPHDiscoverFeedHeaderFeature;
 #endif  // defined(OS_IOS)
 
 }  // namespace feature_engagement

components/feature_engagement/public/feature_list.cc

@@ -62,6 +62,7 @@ const base::Feature* const kAllFeatures[] = {
     &kIPHNewIncognitoTabTipFeature,
     &kIPHBadgedReadingListFeature,
     &kIPHBadgedTranslateManualTriggerFeature,
+    &kIPHDiscoverFeedHeaderFeature,
 #endif  // defined(OS_IOS)
 #if defined(OS_WIN) || defined(OS_APPLE) || defined(OS_LINUX) || \
     defined(OS_CHROMEOS)

components/feature_engagement/public/feature_list.h

@@ -118,6 +118,8 @@ DEFINE_VARIATION_PARAM(kIPHNewIncognitoTabTipFeature, "IPH_NewIncognitoTabTip");
 DEFINE_VARIATION_PARAM(kIPHBadgedReadingListFeature, "IPH_BadgedReadingList");
 DEFINE_VARIATION_PARAM(kIPHBadgedTranslateManualTriggerFeature,
                        "IPH_BadgedTranslateManualTrigger");
+DEFINE_VARIATION_PARAM(kIPHDiscoverFeedHeaderFeature,
+                       "IPH_DiscoverFeedHeaderMenu");
 #endif  // defined(OS_IOS)
 
 #if defined(OS_WIN) || defined(OS_APPLE) || defined(OS_LINUX) || \
@@ -186,6 +188,7 @@ constexpr flags_ui::FeatureEntry::FeatureVariation
         VARIATION_ENTRY(kIPHNewIncognitoTabTipFeature),
         VARIATION_ENTRY(kIPHBadgedReadingListFeature),
         VARIATION_ENTRY(kIPHBadgedTranslateManualTriggerFeature),
+        VARIATION_ENTRY(kIPHDiscoverFeedHeaderFeature),
 #elif defined(OS_WIN) || defined(OS_APPLE) || defined(OS_LINUX) || \
     defined(OS_CHROMEOS)
         VARIATION_ENTRY(kIPHDesktopTabGroupsNewGroupFeature),

ios/chrome/app/strings/ios_strings.grd

@@ -717,6 +717,9 @@ Because your account is managed by <ph name="HOSTED_DOMAIN">$1<ex>google.com</ex
       <message name="IDS_IOS_DISCONNECT_DIALOG_TITLE_UNITY" desc="The title of the disconnect dialog [Length: 30em].">
         Sign out and turn off sync?
       </message>
+      <message name="IDS_IOS_DISCOVER_FEED_HEADER_IPH" desc="In-product help that points at the menu icon for the news feed on Chrome's new tab page. This string instructs the user to open the menu for settings that let them control the content that appears on the feed.">
+        Control your stories and activity here
+      </message>
       <message name="IDS_IOS_DISCOVER_FEED_TITLE" desc="The title in the Discover feed menu.">
         Discover
       </message>

ios/chrome/app/strings/ios_strings_grd/IDS_IOS_DISCOVER_FEED_HEADER_IPH.png.sha1

+ac7469a1b2f6aee4da011cfba151465980dd9310
\ No newline at end of file

ios/chrome/browser/ui/browser_view/browser_view_controller.mm

@@ -2219,6 +2219,7 @@ NSString* const kBrowserViewControllerSnackbarCategory =
       kNewTabButtonGuide,
       kSecondaryToolbarGuide,
       kVoiceSearchButtonGuide,
+      kDiscoverFeedHeaderMenuGuide,
     ];
     AddNamedGuidesToView(guideNames, self.view);
 

ios/chrome/browser/ui/bubble/bubble_presenter.mm

@@ -58,6 +58,8 @@ const CGFloat kBubblePresentationDelay = 1;
     BubbleViewControllerPresenter* tabTipBubblePresenter;
 @property(nonatomic, strong, readwrite)
     BubbleViewControllerPresenter* incognitoTabTipBubblePresenter;
+@property(nonatomic, strong)
+    BubbleViewControllerPresenter* discoverFeedHeaderMenuTipBubblePresenter;
 
 @property(nonatomic, assign) ChromeBrowserState* browserState;
 @property(nonatomic, weak) id<BubblePresenterDelegate> delegate;
@@ -131,6 +133,7 @@ const CGFloat kBubblePresentationDelay = 1;
   [self.incognitoTabTipBubblePresenter dismissAnimated:NO];
   [self.bottomToolbarTipBubblePresenter dismissAnimated:NO];
   [self.longPressToolbarTipBubblePresenter dismissAnimated:NO];
+  [self.discoverFeedHeaderMenuTipBubblePresenter dismissAnimated:NO];
 }
 
 - (void)userEnteredTabSwitcher {
@@ -158,9 +161,10 @@ const CGFloat kBubblePresentationDelay = 1;
   if (!self.incognitoTabTipBubblePresenter.isUserEngaged)
     [self presentNewIncognitoTabTipBubble];
 
-  // The bottom toolbar doesn't use the isUserEngaged, so don't check if the
-  // user is engaged here.
+  // The bottom toolbar and Discover feed header menu don't use the
+  // isUserEngaged, so don't check if the user is engaged here.
   [self presentBottomToolbarTipBubble];
+  [self presentDiscoverFeedHeaderTipBubble];
 }
 
 - (void)presentLongPressBubble {
@@ -259,6 +263,34 @@ presentBubbleForFeature:(const base::Feature&)feature
       ->NotifyEvent(feature_engagement::events::kBottomToolbarOpened);
 }
 
+// Presents a bubble associated with the Discover feed header's menu button.
+- (void)presentDiscoverFeedHeaderTipBubble {
+  if (![self canPresentBubble])
+    return;
+
+  BubbleArrowDirection arrowDirection = BubbleArrowDirectionDown;
+  NSString* text =
+      l10n_util::GetNSStringWithFixup(IDS_IOS_DISCOVER_FEED_HEADER_IPH);
+  CGPoint discoverFeedHeaderAnchor =
+      [self anchorPointToGuide:kDiscoverFeedHeaderMenuGuide
+                     direction:arrowDirection];
+
+  // If the feature engagement tracker does not consider it valid to display
+  // the new tab tip, then end early to prevent the potential reassignment
+  // of the existing |tabTipBubblePresenter| to nil.
+  BubbleViewControllerPresenter* presenter = [self
+      presentBubbleForFeature:feature_engagement::kIPHDiscoverFeedHeaderFeature
+                    direction:arrowDirection
+                    alignment:BubbleAlignmentTrailing
+                         text:text
+        voiceOverAnnouncement:nil
+                  anchorPoint:discoverFeedHeaderAnchor];
+  if (!presenter)
+    return;
+
+  self.discoverFeedHeaderMenuTipBubblePresenter = presenter;
+}
+
 // Optionally presents a bubble associated with the new tab tip in-product help
 // promotion. If the feature engagement tracker determines it is valid to show
 // the new tab tip, then it initializes |tabTipBubblePresenter| and presents

ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_discover_header_item.mm

@@ -5,6 +5,7 @@
 #import "ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_discover_header_item.h"
 
 #import "ios/chrome/browser/ui/content_suggestions/content_suggestions_constants.h"
+#import "ios/chrome/browser/ui/util/named_guide.h"
 #import "ios/chrome/browser/ui/util/uikit_ui_util.h"
 #import "ios/chrome/common/ui/colors/UIColor+cr_semantic_colors.h"
 #import "ios/chrome/common/ui/colors/semantic_color_names.h"
@@ -211,6 +212,14 @@ const CGFloat kHeaderBorderRadius = 8;
     [self setConstraintsForFeedVisible:visible];
   }
   self.container.layer.borderWidth = visible ? 0 : kHeaderBorderWidth;
+  [self.contentView layoutIfNeeded];
+  NamedGuide* menuButtonGuide =
+      [NamedGuide guideWithName:kDiscoverFeedHeaderMenuGuide
+                           view:self.menuButton];
+
+  menuButtonGuide.constrainedFrame =
+      [self.contentView convertRect:self.menuButton.frame toView:nil];
+  self.discoverFeedVisible = [NSNumber numberWithBool:visible];
 }
 
 // Sets header properties for when the Discover feed is visible.

ios/chrome/browser/ui/util/layout_guide_names.h

@@ -55,5 +55,8 @@ extern GuideName* const kTranslateInfobarOptionsGuide;
 // A guide that is constrained to match the frame of the last-tapped voice
 // search button.
 extern GuideName* const kVoiceSearchButtonGuide;
+// A guide that is constrained to match the frame of the Discover feed header's
+// top-level menu button.
+extern GuideName* const kDiscoverFeedHeaderMenuGuide;
 
 #endif  // IOS_CHROME_BROWSER_UI_UTIL_LAYOUT_GUIDE_NAMES_H_

ios/chrome/browser/ui/util/layout_guide_names.mm

@@ -26,3 +26,4 @@ GuideName* const kToolsMenuGuide = @"kToolsMenuGuide";
 GuideName* const kTranslateInfobarOptionsGuide =
     @"kTranslateInfobarOptionsGuide";
 GuideName* const kVoiceSearchButtonGuide = @"kVoiceSearchButtonGuide";
+GuideName* const kDiscoverFeedHeaderMenuGuide = @"kDiscoverFeedHeaderMenuGuide";