Commit a651ac6f authored by Jon Mann's avatar Jon Mann Committed by Commit Bot

Fix InternetDetailPage tests.

In crrev/c/1622415 a test.only() test was added to the suite which
prevented other tests from running.  This change replaces all the
occurrences with a regular test() and fixes the tests which have broken
since this was introduced.

Fixed: 1114252
Change-Id: Ife3dd9f4ce3a0e61c3f702d053d0304f43435aa4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343319
Commit-Queue: Jon Mann <jonmann@chromium.org>
Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796106}
parent 52843a2c
......@@ -122,7 +122,7 @@
</cr-button>
<!-- Use policy properties from vpn_config_allowed to indicate when that
pref disables buttons in this row. -->
<controlled-button id="connect" class="action-button"
<controlled-button id="connectDisconnect" class="action-button"
on-click="onConnectDisconnectTap_"
hidden$="[[shouldConnectDisconnectButtonBeHidden_(managedProperties_,
globalPolicy,managedNetworkAvailable, deviceState_)]]"
......
......@@ -232,7 +232,7 @@ suite('InternetDetailPage', function() {
prefs_.vpn_config_allowed.value = true;
internetDetailPage.prefs = Object.assign({}, prefs_);
return flushAsync().then(() => {
const disconnectButton = getButton('disconnect');
const disconnectButton = getButton('connectDisconnect');
assertFalse(disconnectButton.hasAttribute('enforced_'));
assertFalse(!!disconnectButton.$$('cr-policy-pref-indicator'));
});
......@@ -249,7 +249,7 @@ suite('InternetDetailPage', function() {
prefs_.vpn_config_allowed.value = false;
internetDetailPage.prefs = Object.assign({}, prefs_);
return flushAsync().then(() => {
const disconnectButton = getButton('disconnect');
const disconnectButton = getButton('connectDisconnect');
assertTrue(disconnectButton.hasAttribute('enforced_'));
assertTrue(!!disconnectButton.$$('cr-policy-pref-indicator'));
});
......@@ -267,7 +267,7 @@ suite('InternetDetailPage', function() {
internetDetailPage.init('cellular_guid', 'Cellular', 'cellular');
return flushAsync().then(() => {
const connectButton = getButton('connect');
const connectButton = getButton('connectDisconnect');
assertFalse(connectButton.hasAttribute('hidden'));
assertTrue(connectButton.hasAttribute('disabled'));
});
......@@ -296,7 +296,7 @@ suite('InternetDetailPage', function() {
});
suite('DetailsPageAutoConnect', function() {
test.only('Auto Connect toggle updates after GUID change', function() {
test('Auto Connect toggle updates after GUID change', function() {
const mojom = chromeos.networkConfig.mojom;
mojoApi_.setNetworkTypeEnabledState(mojom.NetworkType.kWiFi, true);
const wifi1 = getManagedProperties(
......@@ -325,7 +325,7 @@ suite('InternetDetailPage', function() {
});
});
test.only('Auto Connect updates don\'t trigger a re-save', function() {
test('Auto Connect updates don\'t trigger a re-save', function() {
const mojom = chromeos.networkConfig.mojom;
mojoApi_.setNetworkTypeEnabledState(mojom.NetworkType.kWiFi, true);
let wifi1 = getManagedProperties(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment