Commit a6604f8f authored by Darren Shen's avatar Darren Shen Committed by Commit Bot

ime: Remove flags for launched feature.

Native rule-based has already been launched for 2 milestones. Deleting
the flags code related to it.

The corresponding internal code was deleted in cl/307494837.

Bug: 1034355
Change-Id: I831816b9dd023c14f2e21017af9b2fa69983c88b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2367300Reviewed-by: default avatarKeith Lee <keithlee@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#802988}
parent ebf4a7e9
......@@ -29,9 +29,7 @@ ui::IMEInputContextHandlerInterface* GetInputContext() {
}
bool ShouldEngineUseMojo(const std::string& engine_id) {
return base::FeatureList::IsEnabled(
chromeos::features::kNativeRuleBasedTyping) &&
base::StartsWith(engine_id, "vkd_", base::CompareCase::SENSITIVE);
return base::StartsWith(engine_id, "vkd_", base::CompareCase::SENSITIVE);
}
std::string NormalizeString(const std::string& str) {
......
......@@ -141,8 +141,7 @@ class NativeInputMethodEngineTest : public InProcessBrowserTest,
public:
NativeInputMethodEngineTest() : input_method_(this) {
feature_list_.InitWithFeatures(
/*enabled_features=*/{chromeos::features::kNativeRuleBasedTyping,
chromeos::features::kAssistPersonalInfo,
/*enabled_features=*/{chromeos::features::kAssistPersonalInfo,
chromeos::features::kEmojiSuggestAddition},
/*disabled_features=*/{});
}
......
......@@ -590,11 +590,9 @@ bool InputImeEventRouter::RegisterImeExtension(
}
auto observer = std::make_unique<ImeObserverChromeOS>(extension_id, profile);
auto engine =
(extension_id == "jkghodnilhceideoidjikpgommlajknk" &&
base::FeatureList::IsEnabled(chromeos::features::kNativeRuleBasedTyping))
? std::make_unique<chromeos::NativeInputMethodEngine>()
: std::make_unique<chromeos::InputMethodEngine>();
auto engine = extension_id == "jkghodnilhceideoidjikpgommlajknk"
? std::make_unique<chromeos::NativeInputMethodEngine>()
: std::make_unique<chromeos::InputMethodEngine>();
engine->Initialize(std::move(observer), extension_id.c_str(), profile);
engine_map_[extension_id] = std::move(engine);
......
......@@ -417,9 +417,6 @@ void ChromeVirtualKeyboardDelegate::OnHasInputDevices(
features->AppendString(GenerateFeatureFlag(
"assistiveAutoCorrect",
base::FeatureList::IsEnabled(chromeos::features::kAssistAutoCorrect)));
features->AppendString(GenerateFeatureFlag(
"nativerulebased", base::FeatureList::IsEnabled(
chromeos::features::kNativeRuleBasedTyping)));
results->Set("features", std::move(features));
......
......@@ -322,10 +322,6 @@ const base::Feature kMinimumChromeVersion{"MinimumChromeVersion",
// ChromeOS Media App. https://crbug.com/996088.
const base::Feature kMediaApp{"MediaApp", base::FEATURE_ENABLED_BY_DEFAULT};
// Enable or disable native typing for rule-based input methods.
const base::Feature kNativeRuleBasedTyping{"NativeRuleBasedTyping",
base::FEATURE_ENABLED_BY_DEFAULT};
// Controls whether to use screen priorities to decide if transition from one
// Oobe screen to another is allowed.
// TODO(https://crbug.com/1064271): Remove this flag once the feature is stable.
......
......@@ -139,8 +139,6 @@ COMPONENT_EXPORT(CHROMEOS_CONSTANTS) extern const base::Feature kMediaApp;
COMPONENT_EXPORT(CHROMEOS_CONSTANTS)
extern const base::Feature kMinimumChromeVersion;
COMPONENT_EXPORT(CHROMEOS_CONSTANTS)
extern const base::Feature kNativeRuleBasedTyping;
COMPONENT_EXPORT(CHROMEOS_CONSTANTS)
extern const base::Feature kNewOsSettingsSearch;
COMPONENT_EXPORT(CHROMEOS_CONSTANTS)
extern const base::Feature kOobeScreensPriority;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment