Update Chrome Cloud Reporting test

1) Use raw string to avoid multiple escapes.
2) Add tests for plugins and signed in user data.
3) Add slash and quote in the test data to make sure they can be escaped
   properly by the report helper.

Bug: 924645
Change-Id: I00d6166d967d8ebae82ac8bba5cc698b3eb2e418
Reviewed-on: https://chromium-review.googlesource.com/c/1431335Reviewed-by: Marc-André Decoste <mad@chromium.org>
Commit-Queue: Owen Min <zmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625359}

chrome/browser/extensions/api/enterprise_reporting_private/chrome_desktop_report_request_helper_unittest.cc

@@ -33,7 +33,7 @@ TEST_F(ChromeDesktopReportRequestGeneratorTest, OSInfo) {
   std::string expected_os_info;
 
   expected_os_info = base::StringPrintf(
-      "{\"arch\":\"%s\",\"os\":\"%s\",\"os_version\":\"%s\"}",
+      R"({"arch":"%s","os":"%s","os_version":"%s"})",
       policy::GetOSArchitecture().c_str(), policy::GetOSPlatform().c_str(),
       policy::GetOSVersion().c_str());
   request =
@@ -46,7 +46,7 @@ TEST_F(ChromeDesktopReportRequestGeneratorTest, MachineName) {
   std::unique_ptr<em::ChromeDesktopReportRequest> request;
   std::string expected_machine_name;
 
-  expected_machine_name = base::StringPrintf("{\"computername\":\"%s\"}",
+  expected_machine_name = base::StringPrintf(R"({"computername":"%s"})",
                                              policy::GetMachineName().c_str());
   request =
       GenerateChromeDesktopReportRequest(base::DictionaryValue(), &profile_);
@@ -61,7 +61,7 @@ TEST_F(ChromeDesktopReportRequestGeneratorTest, OSUsername) {
   // The username needs to be escaped as the name can contain slashes.
   base::EscapeJSONString(policy::GetOSUsername(), false, &os_username_escaped);
   expected_os_username =
-      base::StringPrintf("{\"username\":\"%s\"}", os_username_escaped.c_str());
+      base::StringPrintf(R"({"username":"%s"})", os_username_escaped.c_str());
 
   request =
       GenerateChromeDesktopReportRequest(base::DictionaryValue(), &profile_);
@@ -93,7 +93,7 @@ TEST_F(ChromeDesktopReportRequestGeneratorTest, ExtensionList) {
   // Extension list will be a empty list by default.
   expected_extension_list = "[]";
   report = base::DictionaryValue::From(base::JSONReader::Read(
-      "{\"browserReport\": {\"chromeUserProfileReport\":[{}]}}"));
+      R"({"browserReport": {"chromeUserProfileReport":[{}]}})"));
   ASSERT_TRUE(report);
   request = GenerateChromeDesktopReportRequest(*report, &profile_);
   ASSERT_TRUE(request);
@@ -102,10 +102,15 @@ TEST_F(ChromeDesktopReportRequestGeneratorTest, ExtensionList) {
                                          .extension_data());
 
   // Extension list will be copied from the |report|.
-  expected_extension_list = "[{\"id\":\"1\"}]";
+  expected_extension_list = R"([{"id":"1\\\""}])";
   report = base::DictionaryValue::From(base::JSONReader::Read(
-      "{\"browserReport\": "
-      "{\"chromeUserProfileReport\":[{\"extensionData\":[{\"id\":\"1\"}]}]}}"));
+      R"({"browserReport":
+           {"chromeUserProfileReport":
+             [
+               {"extensionData": [{"id":"1\\\""}]}
+             ]
+           }
+         })"));
   ASSERT_TRUE(report);
   request = GenerateChromeDesktopReportRequest(*report, &profile_);
   ASSERT_TRUE(request);
@@ -114,6 +119,49 @@ TEST_F(ChromeDesktopReportRequestGeneratorTest, ExtensionList) {
                                          .extension_data());
 }
 
+TEST_F(ChromeDesktopReportRequestGeneratorTest, PluginList) {
+  std::unique_ptr<em::ChromeDesktopReportRequest> request;
+  std::unique_ptr<base::DictionaryValue> report;
+  std::string expected_plugin_list;
+
+  expected_plugin_list = R"([{"id":"1\\\""}])";
+  report = base::DictionaryValue::From(base::JSONReader::Read(
+      R"({"browserReport":
+           {"chromeUserProfileReport":
+             [
+               {"plugins": [{"id":"1\\\""}]}
+             ]
+           }
+         })"));
+  ASSERT_TRUE(report);
+  request = GenerateChromeDesktopReportRequest(*report, &profile_);
+  ASSERT_TRUE(request);
+  EXPECT_EQ(expected_plugin_list,
+            request->browser_report().chrome_user_profile_reports(0).plugins());
+}
+
+TEST_F(ChromeDesktopReportRequestGeneratorTest, SignedInUser) {
+  std::unique_ptr<em::ChromeDesktopReportRequest> request;
+  std::unique_ptr<base::DictionaryValue> report;
+  std::string expected_signed_in_user;
+
+  expected_signed_in_user = R"({"email":"a\\@example.com"})";
+  report = base::DictionaryValue::From(base::JSONReader::Read(
+      R"({"browserReport":
+           {"chromeUserProfileReport":
+             [
+               {"chromeSignInUser": {"email":"a\\@example.com"}}
+             ]
+           }
+         })"));
+  ASSERT_TRUE(report);
+  request = GenerateChromeDesktopReportRequest(*report, &profile_);
+  ASSERT_TRUE(request);
+  EXPECT_EQ(expected_signed_in_user, request->browser_report()
+                                         .chrome_user_profile_reports(0)
+                                         .chrome_signed_in_user());
+}
+
 TEST_F(ChromeDesktopReportRequestGeneratorTest, ProfileID) {
   std::unique_ptr<em::ChromeDesktopReportRequest> request;
 
@@ -126,10 +174,12 @@ TEST_F(ChromeDesktopReportRequestGeneratorTest, ProfileID) {
 
   // Profile ID will be merged into the first item of
   // |chrome_user_profile_reports|
-  std::unique_ptr<base::DictionaryValue> report = base::DictionaryValue::From(
-      base::JSONReader::Read("{\"browserReport\": "
-                             "{\"chromeUserProfileReport\":[{\"extensionData\":"
-                             "[{\"id\":\"1\"}]}]}}"));
+  std::unique_ptr<base::DictionaryValue> report =
+      base::DictionaryValue::From(base::JSONReader::Read(R"({"browserReport":
+                                  {"chromeUserProfileReport":[
+                                    {"extensionData": [{"id":"1"}]}
+                                  ]}
+                                })"));
   ASSERT_TRUE(report);
   request = GenerateChromeDesktopReportRequest(*report, &profile_);
   ASSERT_TRUE(request);
@@ -141,14 +191,14 @@ TEST_F(ChromeDesktopReportRequestGeneratorTest, InvalidInput) {
   // |request| will not be generated if the type of input is invalid.
   std::unique_ptr<base::DictionaryValue> report;
   report = base::DictionaryValue::From(base::JSONReader::Read(
-      "{\"browserReport\": "
-      "{\"chromeUserProfileReport\":[{\"extensionData\":{}}]}}"));
+      R"({"browserReport":
+         {"chromeUserProfileReport":[{"extensionData":{}}]}})"));
   ASSERT_TRUE(report);
   EXPECT_FALSE(GenerateChromeDesktopReportRequest(*report, &profile_));
 
   report = base::DictionaryValue::From(base::JSONReader::Read(
-      "{\"browserReport\": "
-      "{\"chromeUserProfileReport\":[{\"chromeSignInUser\":\"\"}]}}"));
+      R"({"browserReport":
+         {"chromeUserProfileReport":[{"chromeSignInUser":""}]}})"));
   ASSERT_TRUE(report);
   EXPECT_FALSE(GenerateChromeDesktopReportRequest(*report, &profile_));
 }
@@ -158,24 +208,33 @@ TEST_F(ChromeDesktopReportRequestGeneratorTest, SafeBrowsing) {
                                   true);
 
   std::unique_ptr<base::DictionaryValue> report;
-  report = base::DictionaryValue::From(
-      base::JSONReader::Read("{\"browserReport\": "
-                             "{\"chromeUserProfileReport\":[{"
-                             "\"safeBrowsingWarnings\":\"invalid\"}]}}"));
+  report =
+      base::DictionaryValue::From(base::JSONReader::Read(R"({"browserReport":
+                                  {"chromeUserProfileReport":[{
+                                    "safeBrowsingWarnings":"invalid"
+                                    }]
+                                  }
+                                })"));
   ASSERT_TRUE(report);
   EXPECT_FALSE(GenerateChromeDesktopReportRequest(*report, &profile_));
 
   report = base::DictionaryValue::From(base::JSONReader::Read(
-      "{\"browserReport\": "
-      "{\"chromeUserProfileReport\":[{\"safeBrowsingWarningsClickThrough\":"
-      "\"invalid\"}]}}"));
+      R"({"browserReport":
+           {"chromeUserProfileReport":[{
+             "safeBrowsingWarningsClickThrough": "invalid"}]
+           }
+         })"));
   ASSERT_TRUE(report);
   EXPECT_FALSE(GenerateChromeDesktopReportRequest(*report, &profile_));
 
   report = base::DictionaryValue::From(base::JSONReader::Read(
-      "{\"browserReport\": "
-      "{\"chromeUserProfileReport\":[{\"safeBrowsingWarnings\":3, "
-      "\"safeBrowsingWarningsClickThrough\":1}]}}"));
+      R"({"browserReport":
+           {"chromeUserProfileReport":[{
+              "safeBrowsingWarnings":3,
+              "safeBrowsingWarningsClickThrough":1
+             }]
+           }
+         })"));
   ASSERT_TRUE(report);
   std::unique_ptr<em::ChromeDesktopReportRequest> request =
       GenerateChromeDesktopReportRequest(*report, &profile_);