Commit a68c29b3 authored by Gabriel Charette's avatar Gabriel Charette Committed by Commit Bot

Migrate off BrowserThread::DeleteSoon in /content/browser/android/java

Instead use base::DeleteSoon which enforces usage of TaskTraits.

This CL is a no-op as-is. It was recently discovered however that some
callers did BrowserThread::DeleteSoon() with pending tasks running on
different task queues (different traits  -- e.g.

TaskTraits to make this more obvious. Please review whether calls in
this CL can be migrated as-is or need additional traits to match
potentially pending tasks.

Split from https://chromium-review.googlesource.com/c/chromium/src/+/1894109
for cursory review.

This CL was uploaded by git cl split.

R=torne@chromium.org


TaskPriority: :BEST_EFFORT) which can result in out-of-order deletion...
BrowserThread: :DeleteSoon() is being migrated to base::DeleteSoon() w/
Bug: 1019767
Change-Id: I39d0a74b1bec2148a9dec777ace504bb0a1de4d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1895642
Auto-Submit: Gabriel Charette <gab@chromium.org>
Reviewed-by: default avatarRichard Coles <torne@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#711819}
parent 9124e345
...@@ -5,10 +5,12 @@ ...@@ -5,10 +5,12 @@
#include "content/browser/android/java/gin_java_bridge_message_filter.h" #include "content/browser/android/java/gin_java_bridge_message_filter.h"
#include "base/auto_reset.h" #include "base/auto_reset.h"
#include "base/task/post_task.h"
#include "build/build_config.h" #include "build/build_config.h"
#include "content/browser/android/java/gin_java_bridge_dispatcher_host.h" #include "content/browser/android/java/gin_java_bridge_dispatcher_host.h"
#include "content/browser/android/java/java_bridge_thread.h" #include "content/browser/android/java/java_bridge_thread.h"
#include "content/common/gin_java_bridge_messages.h" #include "content/common/gin_java_bridge_messages.h"
#include "content/public/browser/browser_task_traits.h"
#include "content/public/browser/browser_thread.h" #include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_frame_host.h" #include "content/public/browser/render_frame_host.h"
#include "content/public/browser/render_process_host.h" #include "content/public/browser/render_process_host.h"
...@@ -38,7 +40,7 @@ void GinJavaBridgeMessageFilter::OnDestruct() const { ...@@ -38,7 +40,7 @@ void GinJavaBridgeMessageFilter::OnDestruct() const {
if (BrowserThread::CurrentlyOn(BrowserThread::UI)) { if (BrowserThread::CurrentlyOn(BrowserThread::UI)) {
delete this; delete this;
} else { } else {
BrowserThread::DeleteSoon(BrowserThread::UI, FROM_HERE, this); base::DeleteSoon(FROM_HERE, {BrowserThread::UI}, this);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment