Commit a6bbc4c8 authored by Mugdha Lakhani's avatar Mugdha Lakhani Committed by Commit Bot

[WebLayer] Return TabSpecificContentSettingsDelegate.

Return a valid TabSpecificContentSettingsDelegate from
PageInfoControllerDelegateImpl and add a browsertest to verify the same.

Bug: 1052375
Change-Id: I60db31480fbefc46b48851891ffaa0d977c7fdc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2170349
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: default avatarClark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#763440}
parent b669c771
...@@ -72,4 +72,13 @@ IN_PROC_BROWSER_TEST_F(PageInfoBrowserTest, PermissionStatus) { ...@@ -72,4 +72,13 @@ IN_PROC_BROWSER_TEST_F(PageInfoBrowserTest, PermissionStatus) {
.content_setting, .content_setting,
CONTENT_SETTING_BLOCK); CONTENT_SETTING_BLOCK);
} }
IN_PROC_BROWSER_TEST_F(PageInfoBrowserTest,
TabSpecificContentSettingsDelegate) {
std::unique_ptr<PageInfoDelegate> page_info_delegate =
page_info::GetPageInfoClient()->CreatePageInfoDelegate(GetWebContents());
ASSERT_TRUE(page_info_delegate);
EXPECT_TRUE(page_info_delegate->GetTabSpecificContentSettingsDelegate());
}
} // namespace weblayer } // namespace weblayer
...@@ -12,6 +12,7 @@ ...@@ -12,6 +12,7 @@
#include "weblayer/browser/permissions/permission_decision_auto_blocker_factory.h" #include "weblayer/browser/permissions/permission_decision_auto_blocker_factory.h"
#include "weblayer/browser/permissions/permission_manager_factory.h" #include "weblayer/browser/permissions/permission_manager_factory.h"
#include "weblayer/browser/stateful_ssl_host_state_delegate_factory.h" #include "weblayer/browser/stateful_ssl_host_state_delegate_factory.h"
#include "weblayer/browser/tab_specific_content_settings_delegate.h"
PageInfoDelegateImpl::PageInfoDelegateImpl(content::WebContents* web_contents) PageInfoDelegateImpl::PageInfoDelegateImpl(content::WebContents* web_contents)
: web_contents_(web_contents) { : web_contents_(web_contents) {
...@@ -103,9 +104,8 @@ PageInfoDelegateImpl::GetVisibleSecurityState() { ...@@ -103,9 +104,8 @@ PageInfoDelegateImpl::GetVisibleSecurityState() {
std::unique_ptr<content_settings::TabSpecificContentSettings::Delegate> std::unique_ptr<content_settings::TabSpecificContentSettings::Delegate>
PageInfoDelegateImpl::GetTabSpecificContentSettingsDelegate() { PageInfoDelegateImpl::GetTabSpecificContentSettingsDelegate() {
// TODO(crbug.com/1052375): Implement. return std::make_unique<weblayer::TabSpecificContentSettingsDelegate>(
NOTREACHED(); web_contents_);
return nullptr;
} }
content::BrowserContext* PageInfoDelegateImpl::GetBrowserContext() const { content::BrowserContext* PageInfoDelegateImpl::GetBrowserContext() const {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment