[macOS Capture] SBT: Improve IOSurface-less pixel buffer test coverage.
CL 2551665 fixed a bug relating to SampleBufferTransformer's fast path not considering IOSurface-less pixel buffers and added test coverage that the fast path always outputs a pixel buffer with an IOSurface. However, in CL 2551665 these IOSurface-less pixel buffers are created without content; CreateSampleBuffer is ignoring the RGB values. This CL addresses that and improves the test coverage, but because we pass all the tests, this CL won't have to be backmerged to M88. It's a testing-only change. This CL: - Creates IOSuface-less pixel buffers in the specified color. - Verifies that both the "pixel transfer" path and the "libyuv" path are able to scale IOSurface-less pixel buffers and that the color is correct. - Verifies that regardless of technique we output an IOSurface-backed pixel buffer. With this CL, all possible camera output formats are both supported and well tested. Bug: chromium:1148964 Change-Id: Ic016e3109de42d73a39b5a7e0a155b56c87e0cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553551Reviewed-by:Markus Handell <handellm@google.com> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#830145}
Showing
This diff is collapsed.
Please register or sign in to comment