[Passwords] Add flags enabling Saving UI for account-stored passwords

The new feature controls the saving UI only so that we can:
a) experiment with filling and saving independently
b) guard highly experimental and testing-only saving surfaces initially

Bug: 1018700
Change-Id: I44f190dac515a42cdf2173b89e9fded3ba4b3983
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926129Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#716985}

chrome/browser/about_flags.cc

@@ -4632,6 +4632,13 @@ const FeatureEntry kFeatureEntries[] = {
      FEATURE_VALUE_TYPE(
          password_manager::features::kEnablePasswordsAccountStorage)},
 
+    {"passwords-account-storage-saving-ui",
+     flag_descriptions::kEnablePasswordsAccountStorageSavingUiName,
+     flag_descriptions::kEnablePasswordsAccountStorageSavingUiDescription,
+     kOsWin | kOsMac | kOsLinux,
+     FEATURE_VALUE_TYPE(
+         password_manager::features::kEnablePasswordsAccountStorageSavingUi)},
+
 #if !defined(OS_ANDROID)
     {"improved-cookie-controls", flag_descriptions::kImprovedCookieControlsName,
      flag_descriptions::kImprovedCookieControlsDescription, kOsDesktop,

chrome/browser/flag-metadata.json

@@ -3008,6 +3008,11 @@
     "owners": ["mamir", "treib"],
     "expiry_milestone": 85
   },
+  {
+    "name": "passwords-account-storage-saving-ui",
+    "owners": ["mamir", "fhorschig"],
+    "expiry_milestone": 85
+  },
   {
     "name": "pdf-annotations",
     "owners": [ "dstockwell@google.com" ],

chrome/browser/flag_descriptions.cc

@@ -347,6 +347,13 @@ const char kEnablePasswordsAccountStorageDescription[] =
     "Enables storing passwords in a second, Gaia-account-scoped storage for "
     "signed-in but not syncing users";
 
+const char kEnablePasswordsAccountStorageSavingUiName[] =
+    "Enable the UI to save passwords to the account storage";
+const char kEnablePasswordsAccountStorageSavingUiDescription[] =
+    "Enables the UI that allows storing passwords to the Gaia-account-scoped "
+    "storage for signed-in but not syncing users. Requires enabling the "
+    "account storage #passwords-account-storage.";
+
 const char kFocusMode[] = "Focus Mode";
 const char kFocusModeDescription[] =
     "If enabled, allows the user to switch to Focus Mode";

chrome/browser/flag_descriptions.h

@@ -220,6 +220,9 @@ extern const char kDrawVerticallyEdgeToEdgeDescription[];
 extern const char kEnablePasswordsAccountStorageName[];
 extern const char kEnablePasswordsAccountStorageDescription[];
 
+extern const char kEnablePasswordsAccountStorageSavingUiName[];
+extern const char kEnablePasswordsAccountStorageSavingUiDescription[];
+
 extern const char kExperimentalAccessibilityFeaturesName[];
 extern const char kExperimentalAccessibilityFeaturesDescription[];
 

components/password_manager/core/common/password_manager_features.cc

@@ -30,6 +30,11 @@ const base::Feature kEnableOverwritingPlaceholderUsernames{
 const base::Feature kEnablePasswordsAccountStorage = {
     "EnablePasswordsAccountStorage", base::FEATURE_DISABLED_BY_DEFAULT};
 
+// Provides the UI to save Gaia-account-scoped passwords. Relies on the feature
+// "EnablePasswordsAccountStorage" to be active.
+const base::Feature kEnablePasswordsAccountStorageSavingUi = {
+    "EnablePasswordsAccountStorageSavingUi", base::FEATURE_DISABLED_BY_DEFAULT};
+
 const base::Feature KEnablePasswordGenerationForClearTextFields = {
     "EnablePasswordGenerationForClearTextFields",
     base::FEATURE_DISABLED_BY_DEFAULT};

components/password_manager/core/common/password_manager_features.h

@@ -21,6 +21,7 @@ extern const base::Feature kEditPasswordsInDesktopSettings;
 extern const base::Feature kDeleteCorruptedPasswords;
 extern const base::Feature kEnableOverwritingPlaceholderUsernames;
 extern const base::Feature kEnablePasswordsAccountStorage;
+extern const base::Feature kEnablePasswordsAccountStorageSavingUi;
 extern const base::Feature KEnablePasswordGenerationForClearTextFields;
 extern const base::Feature kFillOnAccountSelect;
 extern const base::Feature kGenerationNoOverwrites;

tools/metrics/histograms/enums.xml

@@ -37390,6 +37390,7 @@ from previous Chrome versions.
   </int>
   <int value="1343197" label="UseSearchClickForRightClick:enabled"/>
   <int value="1558582" label="ResamplingInputEvents:enabled"/>
+  <int value="2070488" label="EnablePasswordsAccountStorageSavingUi:disabled"/>
   <int value="3826348" label="DarkenWebsitesCheckboxInThemesSetting:disabled"/>
   <int value="5654819" label="CrostiniGpuSupport:disabled"/>
   <int value="7444737" label="NTPSuggestionsStandaloneUI:disabled"/>
@@ -38484,6 +38485,8 @@ from previous Chrome versions.
   <int value="1442830837" label="MemoryAblation:disabled"/>
   <int value="1447295459" label="SyncPseudoUSSApps:enabled"/>
   <int value="1448684258" label="TabHoverCardImages:enabled"/>
+  <int value="1449177114"
+      label="EnablePasswordsAccountStorageSavingUi:enabled"/>
   <int value="1452492841" label="TerminalSystemAppSplits:enabled"/>
   <int value="1452546183" label="PwaPersistentNotification:enabled"/>
   <int value="1454006695" label="BlinkHeapUnifiedGarbageCollection:disabled"/>