[Feed] Remove throttling and freshness checks for background fetches

Refresh suggestions in the background with more urgency to bring Feed's
background fetching in line with Zine's.

Bug: 988165
Change-Id: I412ad34a7ec6c1b6c3ec3bf5e089ee2a0854e77f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730090
Commit-Queue: Ian Wells <iwells@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#683656}

components/feed/core/feed_scheduler_host.cc

@@ -569,18 +569,22 @@ FeedSchedulerHost::ShouldRefreshResult FeedSchedulerHost::ShouldRefresh(
     return kDontRefreshRefreshSuppressed;
   }
 
-  if (attempt_age < GetTriggerThreshold(trigger)) {
-    DVLOG(2) << "Last attempt age of " << attempt_age
-             << " stopped refresh from trigger " << static_cast<int>(trigger);
-    return kDontRefreshNotStale;
-  }
+  // https://crbug.com/988165: When kThrottleBackgroundFetches == false, skip
+  // checks for quota and staleness for background fetching.
+  if (kThrottleBackgroundFetches.Get() || trigger != TriggerType::kFixedTimer) {
+    if (attempt_age < GetTriggerThreshold(trigger)) {
+      DVLOG(2) << "Last attempt age of " << attempt_age
+               << " stopped refresh from trigger " << static_cast<int>(trigger);
+      return kDontRefreshNotStale;
+    }
 
-  auto throttlerIter = throttlers_.find(user_class);
-  if (throttlerIter == throttlers_.end() ||
-      !throttlerIter->second->RequestQuota()) {
-    DVLOG(2) << "Throttler stopped refresh from trigger "
-             << static_cast<int>(trigger);
-    return kDontRefreshRefreshThrottled;
+    auto throttlerIter = throttlers_.find(user_class);
+    if (throttlerIter == throttlers_.end() ||
+        !throttlerIter->second->RequestQuota()) {
+      DVLOG(2) << "Throttler stopped refresh from trigger "
+               << static_cast<int>(trigger);
+      return kDontRefreshRefreshThrottled;
+    }
   }
 
   switch (trigger) {

components/feed/core/feed_scheduler_host_unittest.cc

@@ -654,6 +654,22 @@ TEST_F(FeedSchedulerHostTest, OnFixedTimerActiveSuggestionsConsumer) {
   EXPECT_EQ(3, refresh_call_count());
 }
 
+TEST_F(FeedSchedulerHostTest, OnFixedTimerThrottlingDisabled) {
+  base::test::ScopedFeatureList scoped_feature_list;
+  scoped_feature_list.InitAndEnableFeatureWithParameters(
+      kInterestFeedContentSuggestions,
+      {{kThrottleBackgroundFetches.name, "false"}});
+
+  // Every call to OnFixedTimer() should cause a fetch.
+  scheduler()->OnFixedTimer(base::OnceClosure());
+  EXPECT_EQ(1, refresh_call_count());
+  scheduler()->OnReceiveNewContent(test_clock()->Now());
+
+  scheduler()->OnFixedTimer(base::OnceClosure());
+  EXPECT_EQ(2, refresh_call_count());
+  scheduler()->OnReceiveNewContent(test_clock()->Now());
+}
+
 TEST_F(FeedSchedulerHostTest, ScheduleFixedTimerWakeUpOnSuccess) {
   // First wake up scheduled during Initialize().
   EXPECT_EQ(1U, schedule_wake_up_times().size());

components/feed/feed_feature_list.cc

@@ -15,6 +15,8 @@ const base::FeatureParam<int> kSuppressRefreshDurationMinutes{
     &kInterestFeedContentSuggestions, "suppress_refresh_duration_minutes", 30};
 const base::FeatureParam<int> kTimeoutDurationSeconds{
     &kInterestFeedContentSuggestions, "timeout_duration_seconds", 30};
+const base::FeatureParam<bool> kThrottleBackgroundFetches{
+    &kInterestFeedContentSuggestions, "throttle_background_fetches", true};
 
 const base::Feature kInterestFeedNotifications{
     "InterestFeedNotifications", base::FEATURE_DISABLED_BY_DEFAULT};

components/feed/feed_feature_list.h

@@ -17,6 +17,7 @@ extern const base::Feature kInterestFeedContentSuggestions;
 extern const base::FeatureParam<std::string> kDisableTriggerTypes;
 extern const base::FeatureParam<int> kSuppressRefreshDurationMinutes;
 extern const base::FeatureParam<int> kTimeoutDurationSeconds;
+extern const base::FeatureParam<bool> kThrottleBackgroundFetches;
 
 extern const base::Feature kInterestFeedNotifications;