Commit a704db97 authored by Donn Denman's avatar Donn Denman Committed by Commit Bot

[Ephemeral Tab] Fix histogram recording.

Speculative fix for histogram recording - int values are not registering
in UMA.  Maybe avoiding the converstion to long will fix.

BUG=960613

Change-Id: Ia639c3a4b16091af6c82c007bfde97ae7653e5d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600640
Auto-Submit: Donn Denman <donnd@chromium.org>
Reviewed-by: default avatarJinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#657687}
parent 27cf3c1e
...@@ -349,8 +349,8 @@ public class EphemeralTabPanel extends OverlayPanel { ...@@ -349,8 +349,8 @@ public class EphemeralTabPanel extends OverlayPanel {
private void finishPeekTimer() { private void finishPeekTimer() {
if (!mDidRecordFirstPeek && mPanelPeekedNanoseconds != 0) { if (!mDidRecordFirstPeek && mPanelPeekedNanoseconds != 0) {
mDidRecordFirstPeek = true; mDidRecordFirstPeek = true;
int durationPeeking = (int) ((System.nanoTime() - mPanelPeekedNanoseconds) long durationPeeking = (System.nanoTime() - mPanelPeekedNanoseconds)
/ TimeUtils.NANOSECONDS_PER_MILLISECOND); / TimeUtils.NANOSECONDS_PER_MILLISECOND;
RecordHistogram.recordMediumTimesHistogram( RecordHistogram.recordMediumTimesHistogram(
"EphemeralTab.DurationPeeked", durationPeeking); "EphemeralTab.DurationPeeked", durationPeeking);
} }
...@@ -365,8 +365,8 @@ public class EphemeralTabPanel extends OverlayPanel { ...@@ -365,8 +365,8 @@ public class EphemeralTabPanel extends OverlayPanel {
private void finishOpenTimer() { private void finishOpenTimer() {
if (!mDidRecordFirstOpen && mPanelOpenedNanoseconds != 0) { if (!mDidRecordFirstOpen && mPanelOpenedNanoseconds != 0) {
mDidRecordFirstOpen = true; mDidRecordFirstOpen = true;
int durationOpened = (int) ((System.nanoTime() - mPanelOpenedNanoseconds) long durationOpened = (System.nanoTime() - mPanelOpenedNanoseconds)
/ TimeUtils.NANOSECONDS_PER_MILLISECOND); / TimeUtils.NANOSECONDS_PER_MILLISECOND;
RecordHistogram.recordMediumTimesHistogram( RecordHistogram.recordMediumTimesHistogram(
"EphemeralTab.DurationOpened", durationOpened); "EphemeralTab.DurationOpened", durationOpened);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment