Commit a726d560 authored by Chris Hall's avatar Chris Hall Committed by Commit Bot

Fixing typo in field name and description.

'Accessibilty' -> 'Accessibility'.

R=jzw,michaeldo

Change-Id: I86bc111bde433933e60a0ff5a288faebe65d6089
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918798Reviewed-by: default avatarJohn Wu <jzw@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Hall <chrishall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#717513}
parent daa5e6f7
......@@ -8,6 +8,6 @@
#import <Foundation/Foundation.h>
// Accessibility identifier added to the text field of JavaScript prompts.
extern NSString* const kJavaScriptDialogTextFieldAccessibiltyIdentifier;
extern NSString* const kJavaScriptDialogTextFieldAccessibilityIdentifier;
#endif // IOS_CHROME_BROWSER_UI_DIALOGS_DIALOG_CONSTANTS_H_
......@@ -9,5 +9,5 @@
#endif
// Externed accessibility identifier.
NSString* const kJavaScriptDialogTextFieldAccessibiltyIdentifier =
@"JavaScriptDialogTextFieldAccessibiltyIdentifier";
NSString* const kJavaScriptDialogTextFieldAccessibilityIdentifier =
@"JavaScriptDialogTextFieldAccessibilityIdentifier";
......@@ -269,7 +269,7 @@ using completion_block_util::GetSafeHTTPAuthCompletion;
addTextFieldWithConfigurationHandler:^(UITextField* textField) {
textField.text = defaultText;
textField.accessibilityIdentifier =
kJavaScriptDialogTextFieldAccessibiltyIdentifier;
kJavaScriptDialogTextFieldAccessibilityIdentifier;
}];
[self addDialogCoordinator:alertCoordinator forWebState:webState];
......
......@@ -206,7 +206,7 @@ void WaitForJavaScriptDialog(const GURL& url, bool visible) {
void TypeInPrompt(NSString* input) {
id<GREYMatcher> text_field_matcher = grey_allOf(
grey_kindOfClass([UITextField class]),
grey_accessibilityID(kJavaScriptDialogTextFieldAccessibiltyIdentifier),
grey_accessibilityID(kJavaScriptDialogTextFieldAccessibilityIdentifier),
nil);
[[EarlGrey selectElementWithMatcher:text_field_matcher]
performAction:grey_typeText(input)];
......
......@@ -10,7 +10,7 @@
class OverlayRequest;
// The accessibility ID for prompt's text field.
extern NSString* const kJavaScriptPromptTextFieldAccessibiltyIdentifier;
extern NSString* const kJavaScriptPromptTextFieldAccessibilityIdentifier;
// Mediator object that uses a JavaScriptPromptOverlayRequestConfig to set
// up the UI for a JavaScript prompt overlay.
......
......@@ -23,8 +23,8 @@
#error "This file requires ARC support."
#endif
NSString* const kJavaScriptPromptTextFieldAccessibiltyIdentifier =
@"JavaScriptPromptTextFieldAccessibiltyIdentifier";
NSString* const kJavaScriptPromptTextFieldAccessibilityIdentifier =
@"JavaScriptPromptTextFieldAccessibilityIdentifier";
@interface JavaScriptPromptOverlayMediator ()
@property(nonatomic, readonly) OverlayRequest* request;
......@@ -80,7 +80,7 @@ NSString* const kJavaScriptPromptTextFieldAccessibiltyIdentifier =
return @[ [[TextFieldConfiguration alloc]
initWithText:defaultPromptValue
placeholder:nil
accessibilityIdentifier:kJavaScriptPromptTextFieldAccessibiltyIdentifier
accessibilityIdentifier:kJavaScriptPromptTextFieldAccessibilityIdentifier
secureTextEntry:NO] ];
}
......
......@@ -98,7 +98,7 @@ TEST_F(JavaScriptPromptOverlayMediatorTest, PromptSetupMainFrame) {
EXPECT_NSEQ(base::SysUTF8ToNSString(default_prompt_value()),
consumer().textFieldConfigurations[0].text);
EXPECT_FALSE(!!consumer().textFieldConfigurations[0].placeholder);
EXPECT_NSEQ(kJavaScriptPromptTextFieldAccessibiltyIdentifier,
EXPECT_NSEQ(kJavaScriptPromptTextFieldAccessibilityIdentifier,
consumer().textFieldConfigurations[0].accessibilityIdentifier);
ASSERT_EQ(2U, consumer().actions.count);
EXPECT_EQ(UIAlertActionStyleDefault, consumer().actions[0].style);
......@@ -117,7 +117,7 @@ TEST_F(JavaScriptPromptOverlayMediatorTest, PromptSetupIframe) {
EXPECT_NSEQ(base::SysUTF8ToNSString(default_prompt_value()),
consumer().textFieldConfigurations[0].text);
EXPECT_FALSE(!!consumer().textFieldConfigurations[0].placeholder);
EXPECT_NSEQ(kJavaScriptPromptTextFieldAccessibiltyIdentifier,
EXPECT_NSEQ(kJavaScriptPromptTextFieldAccessibilityIdentifier,
consumer().textFieldConfigurations[0].accessibilityIdentifier);
ASSERT_EQ(2U, consumer().actions.count);
EXPECT_EQ(UIAlertActionStyleDefault, consumer().actions[0].style);
......@@ -138,7 +138,7 @@ TEST_F(JavaScriptPromptOverlayMediatorTest, PromptSetupWithBlockingOption) {
EXPECT_NSEQ(base::SysUTF8ToNSString(default_prompt_value()),
consumer().textFieldConfigurations[0].text);
EXPECT_FALSE(!!consumer().textFieldConfigurations[0].placeholder);
EXPECT_NSEQ(kJavaScriptPromptTextFieldAccessibiltyIdentifier,
EXPECT_NSEQ(kJavaScriptPromptTextFieldAccessibilityIdentifier,
consumer().textFieldConfigurations[0].accessibilityIdentifier);
ASSERT_EQ(3U, consumer().actions.count);
EXPECT_EQ(UIAlertActionStyleDefault, consumer().actions[0].style);
......
......@@ -18,7 +18,7 @@ extern NSString* const kWebViewShellForwardButtonAccessibilityLabel;
extern NSString* const kWebViewShellAddressFieldAccessibilityLabel;
// Accessibility identifier added to the text field of JavaScript prompts.
extern NSString* const
kWebViewShellJavaScriptDialogTextFieldAccessibiltyIdentifier;
kWebViewShellJavaScriptDialogTextFieldAccessibilityIdentifier;
// Implements the main UI for ios_web_view_shell.
@interface ShellViewController : UIViewController
......
......@@ -18,8 +18,8 @@
NSString* const kWebViewShellBackButtonAccessibilityLabel = @"Back";
NSString* const kWebViewShellForwardButtonAccessibilityLabel = @"Forward";
NSString* const kWebViewShellAddressFieldAccessibilityLabel = @"Address field";
NSString* const kWebViewShellJavaScriptDialogTextFieldAccessibiltyIdentifier =
@"WebViewShellJavaScriptDialogTextFieldAccessibiltyIdentifier";
NSString* const kWebViewShellJavaScriptDialogTextFieldAccessibilityIdentifier =
@"WebViewShellJavaScriptDialogTextFieldAccessibilityIdentifier";
@interface ShellViewController ()<CWVDownloadTaskDelegate,
CWVNavigationDelegate,
......@@ -809,7 +809,7 @@ NSString* const kWebViewShellJavaScriptDialogTextFieldAccessibiltyIdentifier =
[alert addTextFieldWithConfigurationHandler:^(UITextField* textField) {
textField.text = defaultText;
textField.accessibilityIdentifier =
kWebViewShellJavaScriptDialogTextFieldAccessibiltyIdentifier;
kWebViewShellJavaScriptDialogTextFieldAccessibilityIdentifier;
}];
__weak UIAlertController* weakAlert = alert;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment