Commit a73e9ffe authored by jam's avatar jam Committed by Commit bot

Disable flaky ServiceProcessControlBrowserTest on Mac.

BUG=517420
TBR=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/1310553014

Cr-Commit-Position: refs/heads/master@{#346798}
parent 0323f04c
...@@ -172,7 +172,7 @@ IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, LaunchAndIPC) { ...@@ -172,7 +172,7 @@ IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, LaunchAndIPC) {
// This tests the case when a service process is launched when the browser // This tests the case when a service process is launched when the browser
// starts but we try to launch it again while setting up Cloud Print. // starts but we try to launch it again while setting up Cloud Print.
// Flaky on Mac ASan. http://crbug.com/517420 // Flaky on Mac. http://crbug.com/517420
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
#define MAYBE_LaunchTwice DISABLED_LaunchTwice #define MAYBE_LaunchTwice DISABLED_LaunchTwice
#else #else
...@@ -203,7 +203,7 @@ static void DecrementUntilZero(int* count) { ...@@ -203,7 +203,7 @@ static void DecrementUntilZero(int* count) {
FROM_HERE, base::MessageLoop::QuitClosure()); FROM_HERE, base::MessageLoop::QuitClosure());
} }
// Flaky on Mac ASan. http://crbug.com/517420 // Flaky on Mac. http://crbug.com/517420
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
#define MAYBE_MultipleLaunchTasks DISABLED_MultipleLaunchTasks #define MAYBE_MultipleLaunchTasks DISABLED_MultipleLaunchTasks
#else #else
...@@ -225,8 +225,14 @@ IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, ...@@ -225,8 +225,14 @@ IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest,
EXPECT_EQ(0, launch_count); EXPECT_EQ(0, launch_count);
} }
// Flaky on Mac. http://crbug.com/517420
#if defined(OS_MACOSX)
#define MAYBE_SameLaunchTask DISABLED_SameLaunchTask
#else
#define MAYBE_SameLaunchTask SameLaunchTask
#endif
// Make sure using the same task for success and failure tasks works. // Make sure using the same task for success and failure tasks works.
IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, SameLaunchTask) { IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, MAYBE_SameLaunchTask) {
ServiceProcessControl* process = ServiceProcessControl::GetInstance(); ServiceProcessControl* process = ServiceProcessControl::GetInstance();
int launch_count = 5; int launch_count = 5;
for (int i = 0; i < launch_count; i++) { for (int i = 0; i < launch_count; i++) {
...@@ -241,7 +247,7 @@ IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, SameLaunchTask) { ...@@ -241,7 +247,7 @@ IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, SameLaunchTask) {
// Tests whether disconnecting from the service IPC causes the service process // Tests whether disconnecting from the service IPC causes the service process
// to die. // to die.
// Flaky on Mac ASan. http://crbug.com/517420 // Flaky on Mac. http://crbug.com/517420
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
#define MAYBE_DieOnDisconnect DISABLED_DieOnDisconnect #define MAYBE_DieOnDisconnect DISABLED_DieOnDisconnect
#else #else
...@@ -256,7 +262,13 @@ IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, ...@@ -256,7 +262,13 @@ IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest,
Disconnect(); Disconnect();
} }
IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, ForceShutdown) { // Flaky on Mac. http://crbug.com/517420
#if defined(OS_MACOSX)
#define MAYBE_ForceShutdown DISABLED_ForceShutdown
#else
#define MAYBE_ForceShutdown ForceShutdown
#endif
IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, MAYBE_ForceShutdown) {
// Launch the service process. // Launch the service process.
LaunchServiceProcessControl(); LaunchServiceProcessControl();
// Make sure we are connected to the service process. // Make sure we are connected to the service process.
...@@ -267,7 +279,7 @@ IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, ForceShutdown) { ...@@ -267,7 +279,7 @@ IN_PROC_BROWSER_TEST_F(ServiceProcessControlBrowserTest, ForceShutdown) {
ForceServiceProcessShutdown(version_info::GetVersionNumber(), service_pid); ForceServiceProcessShutdown(version_info::GetVersionNumber(), service_pid);
} }
// Flaky on Mac ASan. http://crbug.com/517420 // Flaky on Mac. http://crbug.com/517420
#if defined(OS_MACOSX) #if defined(OS_MACOSX)
#define MAYBE_CheckPid DISABLED_CheckPid #define MAYBE_CheckPid DISABLED_CheckPid
#else #else
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment