Remove DEFINE_ELEMENT_TYPE_CASTS for blink directory

The goal of this CL is to clean the element.h file and remove
DEFINE_ELEMENT_TYPE_CASTS to adopt new downcast helpers.

This CL removes DEFINE_ELEMENT_TYPE_CASTS for SVG,Html and MathML
element.

Bug: 891908
Change-Id: I3f1ef7357780d49381e486dc01a09557c17ce39c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1958426Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#723051}

third_party/blink/renderer/core/dom/element.h

@@ -1384,13 +1384,6 @@ inline bool IsAtShadowBoundary(const Element* element) {
 // These macros do the same as their NODE equivalents but additionally provide a
 // template specialization for isElementOfType<>() so that the Traversal<> API
 // works for these Element types.
-#define DEFINE_ELEMENT_TYPE_CASTS(thisType, predicate)            \
-  template <>                                                     \
-  inline bool IsElementOfType<const thisType>(const Node& node) { \
-    return node.predicate;                                        \
-  }                                                               \
-  DEFINE_NODE_TYPE_CASTS(thisType, predicate)
-
 #define DEFINE_ELEMENT_TYPE_CASTS_WITH_FUNCTION(thisType)         \
   template <>                                                     \
   inline bool IsElementOfType<const thisType>(const Node& node) { \

third_party/blink/renderer/core/html/html_element.h

@@ -215,19 +215,20 @@ class CORE_EXPORT HTMLElement : public Element {
   void OnXMLLangAttrChanged(const AttributeModificationParams&);
 };
 
-DEFINE_ELEMENT_TYPE_CASTS(HTMLElement, IsHTMLElement());
-
-template <>
-struct DowncastTraits<HTMLElement> {
-  static bool AllowFrom(const Node& node) { return node.IsHTMLElement(); }
-};
-
 template <typename T>
 bool IsElementOfType(const HTMLElement&);
 template <>
 inline bool IsElementOfType<const HTMLElement>(const HTMLElement&) {
   return true;
 }
+template <>
+inline bool IsElementOfType<const HTMLElement>(const Node& node) {
+  return IsA<HTMLElement>(node);
+}
+template <>
+struct DowncastTraits<HTMLElement> {
+  static bool AllowFrom(const Node& node) { return node.IsHTMLElement(); }
+};
 
 inline HTMLElement::HTMLElement(const QualifiedName& tag_name,
                                 Document& document,

third_party/blink/renderer/core/input/event_handling_util.cc

@@ -105,7 +105,8 @@ ContainerNode* ParentForClickEventInteractiveElementSensitive(
     const Node& node) {
   // IE doesn't dispatch click events for mousedown/mouseup events across form
   // controls.
-  if (node.IsHTMLElement() && ToHTMLElement(node).IsInteractiveContent())
+  auto* html_element = DynamicTo<HTMLElement>(node);
+  if (html_element && html_element->IsInteractiveContent())
     return nullptr;
 
   return FlatTreeTraversal::Parent(node);

third_party/blink/renderer/core/mathml/mathml_element.h

@@ -37,19 +37,20 @@ class CORE_EXPORT MathMLElement : public Element {
       delete;  // This will catch anyone doing an unnecessary check.
 };
 
-DEFINE_ELEMENT_TYPE_CASTS(MathMLElement, IsMathMLElement());
-
-template <>
-struct DowncastTraits<MathMLElement> {
-  static bool AllowFrom(const Node& node) { return node.IsMathMLElement(); }
-};
-
 template <typename T>
 bool IsElementOfType(const MathMLElement&);
 template <>
 inline bool IsElementOfType<const MathMLElement>(const MathMLElement&) {
   return true;
 }
+template <>
+inline bool IsElementOfType<const MathMLElement>(const Node& node) {
+  return IsA<MathMLElement>(node);
+}
+template <>
+struct DowncastTraits<MathMLElement> {
+  static bool AllowFrom(const Node& node) { return node.IsMathMLElement(); }
+};
 
 inline bool Node::HasTagName(const MathMLQualifiedName& name) const {
   auto* mathml_element = DynamicTo<MathMLElement>(this);

third_party/blink/renderer/core/svg/svg_element.h

@@ -334,20 +334,20 @@ struct SVGAttributeHashTranslator {
   }
 };
 
-DEFINE_ELEMENT_TYPE_CASTS(SVGElement, IsSVGElement());
-
-template <>
-struct DowncastTraits<SVGElement> {
-  static bool AllowFrom(const Node& node) { return node.IsSVGElement(); }
-};
-
 template <typename T>
 bool IsElementOfType(const SVGElement&);
 template <>
 inline bool IsElementOfType<const SVGElement>(const SVGElement&) {
   return true;
 }
-
+template <>
+inline bool IsElementOfType<const SVGElement>(const Node& node) {
+  return IsA<SVGElement>(node);
+}
+template <>
+struct DowncastTraits<SVGElement> {
+  static bool AllowFrom(const Node& node) { return node.IsSVGElement(); }
+};
 inline bool Node::HasTagName(const SVGQualifiedName& name) const {
   auto* svg_element = DynamicTo<SVGElement>(this);
   return svg_element && svg_element->HasTagName(name);

third_party/blink/renderer/modules/accessibility/ax_object_test.cc

@@ -431,10 +431,10 @@ TEST_F(AccessibilityTest, InitRelationCache) {
   const AXObject* input_b = GetAXObjectByElementId("b");
   ASSERT_NE(nullptr, input_b);
 
-  EXPECT_TRUE(
-      GetAXObjectCache().MayHaveHTMLLabel(ToHTMLElement(*input_a->GetNode())));
-  EXPECT_FALSE(
-      GetAXObjectCache().MayHaveHTMLLabel(ToHTMLElement(*input_b->GetNode())));
+  EXPECT_TRUE(GetAXObjectCache().MayHaveHTMLLabel(
+      To<HTMLElement>(*input_a->GetNode())));
+  EXPECT_FALSE(GetAXObjectCache().MayHaveHTMLLabel(
+      To<HTMLElement>(*input_b->GetNode())));
 
   // Note: retrieve the LI first and check that its parent is not
   // the paragraph element. If we were to retrieve the UL element,