Commit a751329d authored by Tomasz Wiszkowski's avatar Tomasz Wiszkowski Committed by Commit Bot

Use rounded image view for Answer and Entity suggestions

This change updates the looks of the Answer- and Entity suggestions to
match the design:

http://docs/presentation/d/1uB8QFlhYqQetxNgJxucpKn-Eolx7CiqL88jGES_sjFk?pli=1#slide=id.g45b058cd36_0_146
http://docs/presentation/d/1uB8QFlhYqQetxNgJxucpKn-Eolx7CiqL88jGES_sjFk?pli=1#slide=id.g3ce78ec162_0_50

Bug: 930349
Change-Id: I7fa62d6349ee7b30b44a4c28a4a0dfd82e1f33ba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1632902
Commit-Queue: Ender <ender@google.com>
Reviewed-by: default avatarMatthew Jones <mdjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#664510}
parent 2da4a656
......@@ -22,7 +22,8 @@
android:layout_toStartOf="@+id/omnibox_answer_refine_icon"
android:layout_width="0dp">
<ImageView
<org.chromium.ui.widget.RoundedCornerImageView
style="@style/RoundedCornerImageViewDefault"
android:contentDescription="@null"
android:id="@+id/omnibox_answer_icon"
android:layout_centerVertical="true"
......
......@@ -20,14 +20,15 @@
android:focusable="true"
android:paddingVertical="10dp">
<ImageView
<org.chromium.ui.widget.RoundedCornerImageView
style="@style/RoundedCornerImageViewDefault"
android:id="@+id/omnibox_entity_image"
android:layout_width="@dimen/omnibox_suggestion_entity_icon_size"
android:layout_height="@dimen/omnibox_suggestion_entity_icon_size"
android:layout_centerVertical="true"
android:layout_marginEnd="8dp"
android:layout_marginStart="@dimen/omnibox_suggestion_icon_margin_start"
android:contentDescription="@null" />
android:contentDescription="@null"/>
<TextView
android:id="@+id/omnibox_entity_subject_text"
......
......@@ -3,7 +3,8 @@
Use of this source code is governed by a BSD-style license that can be
found in the LICENSE file. -->
<resources xmlns:tools="http://schemas.android.com/tools">
<resources
xmlns:tools="http://schemas.android.com/tools">
<!-- Q: Why put style resources under values-v17/ ?
A: Problem:
1. paddingStart causes a crash on Galaxy Tab&Note b/8351339.
......@@ -929,4 +930,10 @@
<item name="android:layout_height">@dimen/omnibox_suggestion_edit_url_min_height</item>
<item name="tint">@color/default_icon_color</item>
</style>
<style name="RoundedCornerImageViewDefault">
<item name="cornerRadiusTopStart">@dimen/default_rounded_corner_radius</item>
<item name="cornerRadiusTopEnd">@dimen/default_rounded_corner_radius</item>
<item name="cornerRadiusBottomStart">@dimen/default_rounded_corner_radius</item>
<item name="cornerRadiusBottomEnd">@dimen/default_rounded_corner_radius</item>
</style>
</resources>
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment