Skip to content

GitLab

T
tangled
Commit a75d9361 authored by dpapad's avatar dpapad Committed by Commit Bot
Browse files
Options

Delete leftover files from chrome://app-management/ page. 

The chrome://app-management page has been removed and those files
even though included in the ChromeOS build, were not actually used
anywhere.

Fixed: 1002782
Change-Id: I469ba0b975a396515c5f897859e1f56fc0c4d704
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2090458
Commit-Queue: Jeevan Shikaram <jshikaram@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: default avatarJeevan Shikaram <jshikaram@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747491}
parent 5b2f985e
Hide whitespace changes
Inline Side-by-side
Showing with 0 additions and 658 deletions
chrome/browser/browser_resources.grd
View file @ a75d9361
...@@ -121,12 +121,6 @@ ...@@ -121,12 +121,6 @@
<include name="IDR_APP_MANAGEMENT_IMAGE_MOJO_LITE_JS" file="${root_gen_dir}\ui\gfx\image\mojom\image.mojom-lite.js" compress="gzip" use_base_dir="false" type="BINDATA" /> <include name="IDR_APP_MANAGEMENT_IMAGE_MOJO_LITE_JS" file="${root_gen_dir}\ui\gfx\image\mojom\image.mojom-lite.js" compress="gzip" use_base_dir="false" type="BINDATA" />
<include name="IDR_APP_MANAGEMENT_MOJO_LITE_JS" file="${root_gen_dir}\chrome\browser\ui\webui\app_management\app_management.mojom-lite.js" compress="gzip" use_base_dir="false" type="BINDATA" /> <include name="IDR_APP_MANAGEMENT_MOJO_LITE_JS" file="${root_gen_dir}\chrome\browser\ui\webui\app_management\app_management.mojom-lite.js" compress="gzip" use_base_dir="false" type="BINDATA" />
<include name="IDR_APP_MANAGEMENT_TYPES_MOJO_LITE_JS" file="${root_gen_dir}\chrome\services\app_service\public\mojom\types.mojom-lite.js" compress="gzip" use_base_dir="false" type="BINDATA" /> <include name="IDR_APP_MANAGEMENT_TYPES_MOJO_LITE_JS" file="${root_gen_dir}\chrome\services\app_service\public\mojom\types.mojom-lite.js" compress="gzip" use_base_dir="false" type="BINDATA" />
<include name="IDR_APP_MANAGEMENT_APP_HTML" file="resources\app_management\app.html" compress="gzip" type="BINDATA" />
<include name="IDR_APP_MANAGEMENT_APP_JS" file="resources\app_management\app.js" compress="gzip" type="BINDATA" />
<include name="IDR_APP_MANAGEMENT_EXPANDABLE_APP_LIST_HTML" file="resources\app_management\expandable_app_list.html" compress="gzip" type="BINDATA" />
<include name="IDR_APP_MANAGEMENT_EXPANDABLE_APP_LIST_JS" file="resources\app_management\expandable_app_list.js" compress="gzip" type="BINDATA" />
<include name="IDR_APP_MANAGEMENT_INDEX_HTML" file="resources\app_management\index.html" compress="gzip" type="BINDATA" />
</if> </if>
<if expr="not is_android"> <if expr="not is_android">
......
chrome/browser/resources/app_management/BUILD.gn deleted 100644 → 0
View file @ 5b2f985e
# Copyright 2018 The Chromium Authors. All rights reserved.
# Use of this source code is governed by a BSD-style license that can be
# found in the LICENSE file.
import("//third_party/closure_compiler/compile_js.gni")
import("../optimize_webui.gni")
if (!is_android) {
js_type_check("closure_compile") {
deps = [
":actions",
":api_listener",
":app",
":app_item",
":arc_permission_view",
":browser_proxy",
":chrome_app_permission_view",
":constants",
":dom_switch",
":expandable_app_list",
":fake_page_handler",
":main_view",
":metadata_view",
":notifications_view",
":permission_item",
":permission_toggle",
":permission_view_header",
":pin_to_shelf_item",
":pwa_permission_view",
":reducers",
":router",
":search_view",
":store",
":store_client",
":toggle_row",
":types",
":util",
]
}
js_library("actions") {
deps = [
"//chrome/browser/ui/webui/app_management:mojo_bindings_js_library_for_compile",
"//ui/webui/resources/js:cr",
]
}
js_library("api_listener") {
deps = [
":actions",
":store",
":util",
"//ui/webui/resources/js:cr",
]
}
js_library("app") {
deps = [
":actions",
":arc_permission_view",
":browser_proxy",
":constants",
":dom_switch",
":main_view",
":metadata_view",
":pwa_permission_view",
":router",
":store",
":store_client",
":types",
":util",
"//chrome/browser/ui/webui/app_management:mojo_bindings_js_library_for_compile",
"//ui/webui/resources/cr_elements/cr_toolbar:cr_toolbar",
"//ui/webui/resources/cr_elements/cr_toolbar:cr_toolbar_search_field",
]
}
js_library("app_item") {
deps = [
":actions",
":store_client",
"//ui/webui/resources/js:load_time_data",
]
}
js_library("arc_permission_view") {
deps = [
":constants",
":fake_page_handler",
":metadata_view",
":permission_item",
":permission_view_header",
":pin_to_shelf_item",
":store_client",
]
}
js_library("browser_proxy") {
deps = [
":fake_page_handler",
"//chrome/browser/ui/webui/app_management:mojo_bindings_js_library_for_compile",
"//ui/webui/resources/js:cr",
]
}
js_library("chrome_app_permission_view") {
deps = [
":fake_page_handler",
":metadata_view",
":permission_view_header",
":pin_to_shelf_item",
":store_client",
]
}
js_library("constants") {
}
js_library("dom_switch") {
}
js_library("expandable_app_list") {
deps = [
":app_item",
":constants",
":store_client",
"//third_party/polymer/v1_0/components-chromium/iron-collapse:iron-collapse-extracted",
]
}
js_library("fake_page_handler") {
deps = [
":constants",
":types",
":util",
"//chrome/browser/ui/webui/app_management:mojo_bindings_js_library_for_compile",
"//ui/webui/resources/js:cr",
]
}
js_library("main_view") {
deps = [
":app_item",
":browser_proxy",
":constants",
":store_client",
"//ui/webui/resources/js:load_time_data",
]
}
js_library("metadata_view") {
deps = [
":browser_proxy",
":constants",
":fake_page_handler",
":store_client",
":types",
]
}
js_library("notifications_view") {
deps = [
":app_item",
":constants",
":fake_page_handler",
":store_client",
":util",
]
}
js_library("permission_item") {
deps = [
":fake_page_handler",
":permission_toggle",
":store_client",
":util",
]
}
js_library("permission_toggle") {
deps = [ ":util" ]
}
js_library("permission_view_header") {
deps = [
":browser_proxy",
":store_client",
]
}
js_library("pin_to_shelf_item") {
deps = [
":browser_proxy",
":toggle_row",
":types",
]
}
js_library("pwa_permission_view") {
deps = [
":constants",
":fake_page_handler",
":metadata_view",
":permission_item",
":permission_view_header",
":pin_to_shelf_item",
":store_client",
]
}
js_library("reducers") {
deps = [
":types",
":util",
"//ui/webui/resources/js:cr",
]
}
js_library("router") {
deps = [
":actions",
":constants",
":store_client",
]
}
js_library("search_view") {
deps = [
":app_item",
":store_client",
"//ui/webui/resources/js:load_time_data",
]
}
js_library("store") {
deps = [
":reducers",
":util",
"//ui/webui/resources/js:cr",
"//ui/webui/resources/js/cr/ui:store",
]
}
js_library("store_client") {
deps = [
":store",
":types",
"//ui/webui/resources/js:cr",
"//ui/webui/resources/js/cr/ui:store",
"//ui/webui/resources/js/cr/ui:store_client",
]
}
js_library("toggle_row") {
deps = [
":types",
"//ui/webui/resources/cr_elements/cr_toggle:cr_toggle",
]
}
js_library("types") {
deps = [ "//chrome/browser/ui/webui/app_management:mojo_bindings_js_library_for_compile" ]
}
js_library("util") {
deps = [
":constants",
":types",
"//ui/webui/resources/js:cr",
]
}
}
chrome/browser/resources/app_management/OWNERS deleted 100644 → 0
View file @ 5b2f985e
dominickn@chromium.org
jshikaram@chromium.org
# COMPONENT: Platform>Apps>Foundation
chrome/browser/resources/app_management/app.html deleted 100644 → 0
View file @ 5b2f985e
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="actions.html">
<link rel="import" href="arc_detail_view.html">
<link rel="import" href="browser_proxy.html">
<link rel="import" href="chrome_app_detail_view.html">
<link rel="import" href="dom_switch.html">
<link rel="import" href="main_view.html">
<link rel="import" href="notifications_view.html">
<link rel="import" href="pwa_detail_view.html">
<link rel="import" href="router.html">
<link rel="import" href="search_view.html">
<link rel="import" href="store.html">
<link rel="import" href="store_client.html">
<link rel="import" href="chrome://resources/cr_elements/cr_toolbar/cr_toolbar.html">
<link rel="import" href="api_listener.html">
<dom-module id="app-management-app">
<template>
<style include="app-management-shared-css">
:host {
display: flex;
flex-direction: column;
font-size: var(--app-management-font-size);
height: 100%;
line-height: var(--app-management-line-height);
overflow: hidden;
}
#main-container {
flex: 1;
overflow: auto;
padding: 0 40px;
}
</style>
<cr-toolbar
page-name="$i18n{title}"
search-prompt="$i18n{searchPrompt}"
on-search-changed="onSearchChanged_">
</cr-toolbar>
<div id="main-container">
<app-management-dom-switch id="view-selector"
route="[[selectedRouteId_(currentPage_, searchTerm_)]]">
<template>
<app-management-main-view route-id="main-view">
</app-management-main-view>
<app-management-notifications-view route-id="notifications-view">
</app-management-notifications-view>
<app-management-pwa-detail-view route-id="pwa-detail-view">
</app-management-pwa-detail-view>
<app-management-chrome-app-detail-view
route-id="chrome-app-detail-view">
</app-management-chrome-app-detail-view>
<app-management-arc-detail-view route-id="arc-detail-view">
</app-management-arc-detail-view>
<app-management-search-view route-id="search-view">
</app-management-search-view>
</template>
</app-management-dom-switch>
</div>
<app-management-router></app-management-router>
</template>
<script src="app.js"></script>
</dom-module>
chrome/browser/resources/app_management/app.js deleted 100644 → 0
View file @ 5b2f985e
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
Polymer({
is: 'app-management-app',
behaviors: [
app_management.StoreClient,
],
properties: {
/** @private */
searchTerm_: {
type: String,
observer: 'onSearchTermChanged_',
},
/**
* @private {Page}
*/
currentPage_: {
type: Object,
},
},
/**
* @override
*/
attached() {
this.watch('searchTerm_', function(state) {
return state.search.term;
});
this.watch('currentPage_', state => state.currentPage);
this.updateFromStore();
},
/** @return {CrToolbarSearchFieldElement} */
get searchField() {
return /** @type {CrToolbarElement} */ (this.$$('cr-toolbar'))
.getSearchField();
},
/** @private */
onSearchTermChanged_() {
this.searchField.setValue(this.searchTerm_ || '');
},
/**
* @param {Event} e
* @private
*/
onSearchChanged_(e) {
const searchTerm = /** @type {string} */ (e.detail);
if (searchTerm != this.searchTerm_) {
this.dispatch(app_management.actions.setSearchTerm(searchTerm));
}
},
/**
* @param {Page} currentPage
* @param {String} searchTerm
* @private
*/
selectedRouteId_(currentPage, searchTerm) {
if (searchTerm) {
return 'search-view';
}
// This is to prevent console error caused by currentPage being undefined.
if (currentPage) {
switch (currentPage.pageType) {
case (PageType.MAIN):
return 'main-view';
case (PageType.NOTIFICATIONS):
return 'notifications-view';
case (PageType.DETAIL):
const state = this.getState();
const selectedAppType =
state.apps[assert(state.currentPage.selectedAppId)].type;
switch (selectedAppType) {
case (AppType.kWeb):
return 'pwa-detail-view';
case (AppType.kExtension):
return 'chrome-app-detail-view';
case (AppType.kArc):
return 'arc-detail-view';
default:
assertNotReached();
}
default:
assertNotReached();
}
}
},
});
chrome/browser/resources/app_management/expandable_app_list.html deleted 100644 → 0
View file @ 5b2f985e
<link rel="import" href="chrome://resources/html/polymer.html">
<link rel="import" href="app_item.html">
<link rel="import" href="constants.html">
<link rel="import" href="shared_style.html">
<link rel="import" href="store_client.html">
<link rel="import" href="chrome://resources/polymer/v1_0/iron-collapse/iron-collapse.html">
<link rel="import" href="chrome://resources/cr_elements/cr_icon_button/cr_icon_button.html">
<link rel="import" href="chrome://resources/cr_elements/shared_style_css.html">
<dom-module id="app-management-expandable-app-list">
<template>
<style include="app-management-shared-css cr-shared-style">
#app-list-header {
align-items: center;
display: flex;
padding: 16px 12px;
}
#app-list-title {
margin-inline-start: 12px;
}
#collapse {
display: block;
min-height: var(--collapsed-height);
overflow: hidden;
}
</style>
<div class="card-container">
<div id="app-list-header">
<div id="app-list-title" class="cr-title-text header-text">
[[listTitle]]
</div>
</div>
<iron-collapse id="collapse">
<slot></slot>
</iron-collapse>
<div id="expander-row" class="expander-list-row"
on-click="toggleListExpanded_">
<span>[[moreAppsString_(apps.length, listExpanded_)]]</span>
<cr-icon-button class="expand-button"
iron-icon="[[getCollapsedIcon_(listExpanded_)]]"></cr-icon-button>
</div>
</div>
</template>
<script src="expandable_app_list.js"></script>
</dom-module>
chrome/browser/resources/app_management/expandable_app_list.js deleted 100644 → 0
View file @ 5b2f985e
// Copyright 2018 The Chromium Authors. All rights reserved.
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
/**
* This is an expanding container for a list of apps that shows some items by
* default and can be expanded to show more.
*
* Note: The implementation assumes children are all the same height.
*
* Example usage:
* <app-management-expandable-app-list apps="[[appsList]]">
* <template is="dom-repeat" items="[[appsList]]" as="app" notify-dom-change>
* <app-management-app-item app="[[app]]"></app-management-app-item>
* </template>
* </app-management-expandable-app-list>
*/
Polymer({
is: 'app-management-expandable-app-list',
properties: {
/**
* Title of the expandable list.
* @type {String}
*/
listTitle: {
type: String,
value: '',
observer: 'onListTitleChanged_',
},
/** The number of apps to collapse down to. */
collapsedSize: {
type: Number,
value: NUMBER_OF_APPS_DISPLAYED_DEFAULT,
},
/** @private {boolean} */
listExpanded_: {
type: Boolean,
observer: 'onListExpandedChanged_',
},
/** @private {number} */
numChildrenForTesting_: {
type: Number,
value: 0,
notify: true,
},
},
listeners: {
'dom-change': 'onDomChange_',
},
attached() {
// Hide on reattach.
this.listExpanded_ = false;
this.$.collapse.hide();
},
/** @private */
onAppsChanged_(change) {},
/** @private */
onListTitleChanged_() {
this.$['app-list-title'].hidden = !this.listTitle;
},
/** @private */
onDomChange_() {
let collapsedHeight = 0;
let numChildren = 0;
for (const child of this.$.collapse.getContentChildren()) {
// Wait until we have an actual child element rather than just the
// dom-repeat.
if (child.tagName == 'DOM-REPEAT' || child.tagName == 'TEMPLATE') {
continue;
}
if (numChildren < this.collapsedSize) {
collapsedHeight += child.offsetHeight;
}
numChildren++;
}
this.style.setProperty(
'--collapsed-height', String(collapsedHeight) + 'px');
this.$['expander-row'].hidden = numChildren <= this.collapsedSize;
this.numChildrenForTesting_ = numChildren;
},
/** @private */
toggleListExpanded_() {
this.listExpanded_ = !this.listExpanded_;
},
/** @private */
onListExpandedChanged_() {
// TODO(calamity): Hiding should display:none after the animation to prevent
// tabbing into hidden items.
const collapse = this.$.collapse;
// Since iron-collapse does not support a 'min-height' property, we force it
// to animate to the collapsed height.
if (this.listExpanded_) {
// Reset the opened state, or show won't work.
collapse.hide();
collapse.show();
} else {
// This technically leaves the collapse open.
collapse.updateSize('var(--collapsed-height)', true);
}
},
/**
* @param {boolean} listExpanded
* @return {string}
* @private
*/
getCollapsedIcon_(listExpanded) {
return listExpanded ? 'cr:expand-less' : 'cr:expand-more';
},
/**
* @param {number} numApps
* @param {boolean} listExpanded
* @return {string}
* @private
*/
moreAppsString_(numApps, listExpanded) {
return listExpanded ?
loadTimeData.getString('lessApps') :
loadTimeData.getStringF('moreApps', numApps - this.collapsedSize);
},
});
chrome/browser/resources/app_management/index.html deleted 100644 → 0
View file @ 5b2f985e
<!doctype html>
<html dir="$i18n{textdirection}" lang="$i18n{language}">
<head>
<meta charset="utf8">
<link rel="stylesheet" href="chrome://resources/css/text_defaults_md.css">
<link rel="stylesheet" href="chrome://resources/css/md_colors.css">
<style>
html {
/* Remove 300ms delay for 'click' event, when using touch interface. */
touch-action: manipulation;
}
html,
body {
background: var(--md-background-color);
height: 100%;
margin: 0;
}
</style>
</head>
<body>
<app-management-app></app-management-app>
<script src="chrome://resources/js/load_time_data.js"></script>
<script src="strings.js"></script>
<link rel="import" href="app.html">
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment