Reland "[Telemetry] Provide abridged story sets for rendering and system health."
This reverts commit 76dc2efe. Reason for revert: https://chromium-review.googlesource.com/c/catapult/+/1896356 landed, so relanding this is fine. NOw this will have no impact on anything unless you pass in the --run-abridged-story-set flag. Original change's description: > Revert "[Telemetry] Provide abridged story sets for rendering and system health." > > This reverts commit 9867b18b. > > Reason for revert: This causes unexpected behavior per Ross's comment on https://chromium-review.googlesource.com/c/catapult/+/1874453 . I will reland this once I fix Telemetry. > > Original change's description: > > [Telemetry] Provide abridged story sets for rendering and system health. > > > > Note that this will have no impact on what is currently running > > on the waterfall because all benchmarks are labeled as > > abridged: False right now. > > > > This change is now possible because: > > > > 1. Pinpoint was taught to use the --run-full-story-set flag by > > https://chromium-review.googlesource.com/c/catapult/+/1874451 > > > > 2. benchmark_smoke_unittest.py was fixed: > > https://chromium-review.googlesource.com/c/chromium/src/+/1874821 > > > > Note that system_health_smoke_test.py is fixed as part of this > > change. > > I tested this fix by running > > /run_tests benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:game > > and seeing that the stories, a mix of health_check stories > > and stories without the health_check tag were all run. > > > > Bug: 965158 > > Change-Id: I42ca28543155536da62d9b02d9bf31d8eb311ac3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687783 > > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711017} > > TBR=sadrul@chromium.org,perezju@chromium.org,crouleau@chromium.org > > Change-Id: I9e7ae496ef48ed00bcf2a8d67df42c577d3162d3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 965158 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893738 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711311} TBR=sadrul@chromium.org,perezju@chromium.org,crouleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965158 Change-Id: I6420ec079c4738913bc701a6490fcd6b47b4aa3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932895Reviewed-by:Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#718938}
Showing
Please register or sign in to comment