Commit a79d034c authored by oka's avatar oka Committed by Commit bot

Quick View: Rename Resolution to Dimension.

The metadata stands for the pixel size of the image or the video.
Dimension is more appropriate name for this than resolution.

TEST=manually.
BUG=680011
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2622393003
Cr-Commit-Position: refs/heads/master@{#443171}
parent cf75b740
...@@ -803,6 +803,9 @@ Press any key to continue exploring. ...@@ -803,6 +803,9 @@ Press any key to continue exploring.
<message name="IDS_FILE_BROWSER_METADATA_BOX_CREATION_TIME" desc="Label for file creation time."> <message name="IDS_FILE_BROWSER_METADATA_BOX_CREATION_TIME" desc="Label for file creation time.">
Created Time Created Time
</message> </message>
<message name="IDS_FILE_BROWSER_METADATA_BOX_DIMENSION" desc="Label for image dimension.">
Dimension
</message>
<message name="IDS_FILE_BROWSER_METADATA_BOX_DURATION" desc="Label for audio/video duration."> <message name="IDS_FILE_BROWSER_METADATA_BOX_DURATION" desc="Label for audio/video duration.">
Duration Duration
</message> </message>
...@@ -851,9 +854,6 @@ Press any key to continue exploring. ...@@ -851,9 +854,6 @@ Press any key to continue exploring.
<message name="IDS_FILE_BROWSER_METADATA_BOX_PAGE_COUNT" desc="Label for pdf page count."> <message name="IDS_FILE_BROWSER_METADATA_BOX_PAGE_COUNT" desc="Label for pdf page count.">
Page Count Page Count
</message> </message>
<message name="IDS_FILE_BROWSER_METADATA_BOX_RESOLUTION" desc="Label for image resolution.">
Resolution
</message>
<message name="IDS_FILE_BROWSER_METADATA_BOX_SOURCE" desc="Label for the device used to capture the image."> <message name="IDS_FILE_BROWSER_METADATA_BOX_SOURCE" desc="Label for the device used to capture the image.">
Source Source
</message> </message>
......
...@@ -495,6 +495,7 @@ ExtensionFunction::ResponseAction FileManagerPrivateGetStringsFunction::Run() { ...@@ -495,6 +495,7 @@ ExtensionFunction::ResponseAction FileManagerPrivateGetStringsFunction::Run() {
IDS_FILE_BROWSER_METADATA_BOX_CREATED_BY); IDS_FILE_BROWSER_METADATA_BOX_CREATED_BY);
SET_STRING("METADATA_BOX_CREATION_TIME", SET_STRING("METADATA_BOX_CREATION_TIME",
IDS_FILE_BROWSER_METADATA_BOX_CREATION_TIME); IDS_FILE_BROWSER_METADATA_BOX_CREATION_TIME);
SET_STRING("METADATA_BOX_DIMENSION", IDS_FILE_BROWSER_METADATA_BOX_DIMENSION);
SET_STRING("METADATA_BOX_DURATION", IDS_FILE_BROWSER_METADATA_BOX_DURATION); SET_STRING("METADATA_BOX_DURATION", IDS_FILE_BROWSER_METADATA_BOX_DURATION);
SET_STRING("METADATA_BOX_EXIF_DEVICE_MODEL", SET_STRING("METADATA_BOX_EXIF_DEVICE_MODEL",
IDS_FILE_BROWSER_METADATA_BOX_EXIF_DEVICE_MODEL); IDS_FILE_BROWSER_METADATA_BOX_EXIF_DEVICE_MODEL);
...@@ -523,8 +524,6 @@ ExtensionFunction::ResponseAction FileManagerPrivateGetStringsFunction::Run() { ...@@ -523,8 +524,6 @@ ExtensionFunction::ResponseAction FileManagerPrivateGetStringsFunction::Run() {
IDS_FILE_BROWSER_METADATA_BOX_MODIFIED_BY); IDS_FILE_BROWSER_METADATA_BOX_MODIFIED_BY);
SET_STRING("METADATA_BOX_PAGE_COUNT", SET_STRING("METADATA_BOX_PAGE_COUNT",
IDS_FILE_BROWSER_METADATA_BOX_PAGE_COUNT); IDS_FILE_BROWSER_METADATA_BOX_PAGE_COUNT);
SET_STRING("METADATA_BOX_RESOLUTION",
IDS_FILE_BROWSER_METADATA_BOX_RESOLUTION);
SET_STRING("METADATA_BOX_SOURCE", IDS_FILE_BROWSER_METADATA_BOX_SOURCE); SET_STRING("METADATA_BOX_SOURCE", IDS_FILE_BROWSER_METADATA_BOX_SOURCE);
SET_STRING("METADATA_BOX_TRACK", IDS_FILE_BROWSER_METADATA_BOX_TRACK); SET_STRING("METADATA_BOX_TRACK", IDS_FILE_BROWSER_METADATA_BOX_TRACK);
SET_STRING("METADATA_BOX_VIDEO_INFO", SET_STRING("METADATA_BOX_VIDEO_INFO",
......
...@@ -51,7 +51,7 @@ ...@@ -51,7 +51,7 @@
<div class="category" hidden="[[!isImage_(type)]]" i18n-content="METADATA_BOX_IMAGE_INFO"></div> <div class="category" hidden="[[!isImage_(type)]]" i18n-content="METADATA_BOX_IMAGE_INFO"></div>
<div class="category" hidden="[[!isAudio_(type)]]" i18n-content="METADATA_BOX_AUDIO_INFO"></div> <div class="category" hidden="[[!isAudio_(type)]]" i18n-content="METADATA_BOX_AUDIO_INFO"></div>
<div class="category" hidden="[[!isVideo_(type)]]" i18n-content="METADATA_BOX_VIDEO_INFO"></div> <div class="category" hidden="[[!isVideo_(type)]]" i18n-content="METADATA_BOX_VIDEO_INFO"></div>
<files-metadata-entry i18n-values="key:METADATA_BOX_RESOLUTION" value="[[resolution_(imageWidth, imageHeight)]]"></files-metadata-entry> <files-metadata-entry i18n-values="key:METADATA_BOX_DIMENSION" value="[[dimension_(imageWidth, imageHeight)]]"></files-metadata-entry>
<files-metadata-entry i18n-values="key:METADATA_BOX_ALBUM_TITLE" value="[[mediaAlbum]]"></files-metadata-entry> <files-metadata-entry i18n-values="key:METADATA_BOX_ALBUM_TITLE" value="[[mediaAlbum]]"></files-metadata-entry>
<files-metadata-entry i18n-values="key:METADATA_BOX_MEDIA_TITLE" value="[[mediaTitle]]"></files-metadata-entry> <files-metadata-entry i18n-values="key:METADATA_BOX_MEDIA_TITLE" value="[[mediaTitle]]"></files-metadata-entry>
<files-metadata-entry i18n-values="key:METADATA_BOX_MEDIA_ARTIST" value="[[mediaArtist]]"></files-metadata-entry> <files-metadata-entry i18n-values="key:METADATA_BOX_MEDIA_ARTIST" value="[[mediaArtist]]"></files-metadata-entry>
......
...@@ -153,7 +153,7 @@ var FilesMetadataBox = Polymer({ ...@@ -153,7 +153,7 @@ var FilesMetadataBox = Polymer({
* *
* @private * @private
*/ */
resolution_: function(imageWidth, imageHeight) { dimension_: function(imageWidth, imageHeight) {
if (imageWidth && imageHeight) if (imageWidth && imageHeight)
return imageWidth + " x " + imageHeight; return imageWidth + " x " + imageHeight;
return ''; return '';
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment